[Security Solution][Onboarding] Fix broken "add integrations" links #183765
Assignees
Labels
8.15 candidate
bug
Fixes for quality problems that affect the customer experience
impact:low
Addressing this issue will have a low level of impact on the quality/strength of our product.
Team: SecuritySolution
Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Team:Threat Hunting:Explore
Team:Threat Hunting
Security Solution Threat Hunting Team
Comments
semd
added
bug
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
|
Pinging @elastic/security-threat-hunting-explore (Team:Threat Hunting:Explore) |
semd
added
impact:low
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Oct 11, 2024
## Summary Issue: elastic#189487 This PR is the final implementation of the Onboarding page redesign. It has been developed in collaboration with @angorayc and @agusruidiazgd, using this branch as a feature branch. It already includes 2 smaller PRs that have already been reviewed and approved by the @elastic/security-threat-hunting-explore team: - semd#8 - semd#9 ### Changes - Onboarding page architecture refactor ([issue](elastic#174766)) - Fixes elastic#183765 (from [this Meta issue](elastic#183760)) --- - The progress bar has been removed <img width="903" alt="progress bar" src="https://github.com/user-attachments/assets/f16f3b6d-609f-4178-b83e-3b2106ba56ea"> --- - Card styles updated: - Icons updated to custom SVGs to have the correct color - Icon with circle background - Card internal content border removed | Old | New | | - | - | |<img width="1172" alt="Old styles" src="https://github.com/user-attachments/assets/5a75cd84-a30d-4621-88e3-17d837165016">|<img width="1172" alt="New styles" src="https://github.com/user-attachments/assets/8059bcbc-2f3d-4c7e-ba4f-041a58b51372">| --- - Completed card styles updated: - Icon with green circle background | Old | New | | - | - | |<img width="1172" alt="Old styles complete" src="https://github.com/user-attachments/assets/3258c7be-4ffe-4d25-9cdb-d4fce66ce451">|<img width="1172" alt="New styles complete" src="https://github.com/user-attachments/assets/7dac6ec0-d78d-4881-ae84-3b46562c6d7d">| --- - Improved "Add data with integrations" card | Old | New | | - | - | |<img width="1174" alt="old integrations card" src="https://github.com/user-attachments/assets/3c65c4f5-004b-4619-aa92-26ec0656a8e5">|<img width="1174" alt="new integrations card" src="https://github.com/user-attachments/assets/634e5249-b169-4c93-865e-b82453db90bf">| --- - New "Configure AI assistant" card in a new "Discover Elastic AI" group https://github.com/user-attachments/assets/39bd0dd4-88ba-47df-a77b-6b9b2a185cef --------- Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Angela Chuang <[email protected]> Co-authored-by: Agustina Nahir Ruidiaz <[email protected]> (cherry picked from commit d39c75a)
kibanamachine
added a commit
that referenced
this issue
Oct 11, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] Onboarding redesign (#192247)](#192247) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sergi Massaneda","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-11T19:00:26Z","message":"[Security Solution] Onboarding redesign (#192247)\n\n## Summary\r\n\r\nIssue: #189487 PR is the final implementation of the Onboarding page redesign.\r\n\r\nIt has been developed in collaboration with @angorayc and\r\n@agusruidiazgd, using this branch as a feature branch.\r\nIt already includes 2 smaller PRs that have already been reviewed and\r\napproved by the @elastic/security-threat-hunting-explore team:\r\n- https://github.com/semd/kibana/pull/8\r\n- https://github.com/semd/kibana/pull/9\r\n\r\n### Changes\r\n- Onboarding page architecture refactor\r\n([issue](https://github.com/elastic/kibana/issues/174766))\r\n- Fixes #183765 (from [this Meta\r\nissue](https://github.com/elastic/kibana/issues/183760))\r\n\r\n---\r\n\r\n- The progress bar has been removed\r\n<img width=\"903\" alt=\"progress bar\"\r\nsrc=\"https://github.com/user-attachments/assets/f16f3b6d-609f-4178-b83e-3b2106ba56ea\">\r\n\r\n---\r\n\r\n- Card styles updated:\r\n - Icons updated to custom SVGs to have the correct color\r\n - Icon with circle background\r\n - Card internal content border removed\r\n\r\n| Old | New |\r\n| - | - |\r\n|<img width=\"1172\" alt=\"Old styles\"\r\nsrc=\"https://github.com/user-attachments/assets/5a75cd84-a30d-4621-88e3-17d837165016\">|<img\r\nwidth=\"1172\" alt=\"New styles\"\r\nsrc=\"https://github.com/user-attachments/assets/8059bcbc-2f3d-4c7e-ba4f-041a58b51372\">|\r\n\r\n---\r\n\r\n- Completed card styles updated:\r\n - Icon with green circle background\r\n\r\n| Old | New |\r\n| - | - |\r\n|<img width=\"1172\" alt=\"Old styles complete\"\r\nsrc=\"https://github.com/user-attachments/assets/3258c7be-4ffe-4d25-9cdb-d4fce66ce451\">|<img\r\nwidth=\"1172\" alt=\"New styles complete\"\r\nsrc=\"https://github.com/user-attachments/assets/7dac6ec0-d78d-4881-ae84-3b46562c6d7d\">|\r\n\r\n---\r\n\r\n- Improved \"Add data with integrations\" card\r\n\r\n| Old | New |\r\n| - | - |\r\n|<img width=\"1174\" alt=\"old integrations card\"\r\nsrc=\"https://github.com/user-attachments/assets/3c65c4f5-004b-4619-aa92-26ec0656a8e5\">|<img\r\nwidth=\"1174\" alt=\"new integrations card\"\r\nsrc=\"https://github.com/user-attachments/assets/634e5249-b169-4c93-865e-b82453db90bf\">|\r\n\r\n---\r\n\r\n- New \"Configure AI assistant\" card in a new \"Discover Elastic AI\" group\r\n\r\n\r\nhttps://github.com/user-attachments/assets/39bd0dd4-88ba-47df-a77b-6b9b2a185cef\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Angela Chuang <[email protected]>\r\nCo-authored-by: Agustina Nahir Ruidiaz <[email protected]>","sha":"d39c75a837e705637adc329887bc3b30ad90e79c","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","v9.0.0","Team: SecuritySolution","Team:Threat Hunting:Explore","backport:prev-minor","ci:cloud-deploy","ci:cloud-persist-deployment","v8.16.0"],"title":"[Security Solution] Onboarding redesign","number":192247,"url":"https://github.com/elastic/kibana/pull/192247","mergeCommit":{"message":"[Security Solution] Onboarding redesign (#192247)\n\n## Summary\r\n\r\nIssue: #189487 PR is the final implementation of the Onboarding page redesign.\r\n\r\nIt has been developed in collaboration with @angorayc and\r\n@agusruidiazgd, using this branch as a feature branch.\r\nIt already includes 2 smaller PRs that have already been reviewed and\r\napproved by the @elastic/security-threat-hunting-explore team:\r\n- https://github.com/semd/kibana/pull/8\r\n- https://github.com/semd/kibana/pull/9\r\n\r\n### Changes\r\n- Onboarding page architecture refactor\r\n([issue](https://github.com/elastic/kibana/issues/174766))\r\n- Fixes #183765 (from [this Meta\r\nissue](https://github.com/elastic/kibana/issues/183760))\r\n\r\n---\r\n\r\n- The progress bar has been removed\r\n<img width=\"903\" alt=\"progress bar\"\r\nsrc=\"https://github.com/user-attachments/assets/f16f3b6d-609f-4178-b83e-3b2106ba56ea\">\r\n\r\n---\r\n\r\n- Card styles updated:\r\n - Icons updated to custom SVGs to have the correct color\r\n - Icon with circle background\r\n - Card internal content border removed\r\n\r\n| Old | New |\r\n| - | - |\r\n|<img width=\"1172\" alt=\"Old styles\"\r\nsrc=\"https://github.com/user-attachments/assets/5a75cd84-a30d-4621-88e3-17d837165016\">|<img\r\nwidth=\"1172\" alt=\"New styles\"\r\nsrc=\"https://github.com/user-attachments/assets/8059bcbc-2f3d-4c7e-ba4f-041a58b51372\">|\r\n\r\n---\r\n\r\n- Completed card styles updated:\r\n - Icon with green circle background\r\n\r\n| Old | New |\r\n| - | - |\r\n|<img width=\"1172\" alt=\"Old styles complete\"\r\nsrc=\"https://github.com/user-attachments/assets/3258c7be-4ffe-4d25-9cdb-d4fce66ce451\">|<img\r\nwidth=\"1172\" alt=\"New styles complete\"\r\nsrc=\"https://github.com/user-attachments/assets/7dac6ec0-d78d-4881-ae84-3b46562c6d7d\">|\r\n\r\n---\r\n\r\n- Improved \"Add data with integrations\" card\r\n\r\n| Old | New |\r\n| - | - |\r\n|<img width=\"1174\" alt=\"old integrations card\"\r\nsrc=\"https://github.com/user-attachments/assets/3c65c4f5-004b-4619-aa92-26ec0656a8e5\">|<img\r\nwidth=\"1174\" alt=\"new integrations card\"\r\nsrc=\"https://github.com/user-attachments/assets/634e5249-b169-4c93-865e-b82453db90bf\">|\r\n\r\n---\r\n\r\n- New \"Configure AI assistant\" card in a new \"Discover Elastic AI\" group\r\n\r\n\r\nhttps://github.com/user-attachments/assets/39bd0dd4-88ba-47df-a77b-6b9b2a185cef\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Angela Chuang <[email protected]>\r\nCo-authored-by: Agustina Nahir Ruidiaz <[email protected]>","sha":"d39c75a837e705637adc329887bc3b30ad90e79c"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/192247","number":192247,"mergeCommit":{"message":"[Security Solution] Onboarding redesign (#192247)\n\n## Summary\r\n\r\nIssue: #189487 PR is the final implementation of the Onboarding page redesign.\r\n\r\nIt has been developed in collaboration with @angorayc and\r\n@agusruidiazgd, using this branch as a feature branch.\r\nIt already includes 2 smaller PRs that have already been reviewed and\r\napproved by the @elastic/security-threat-hunting-explore team:\r\n- https://github.com/semd/kibana/pull/8\r\n- https://github.com/semd/kibana/pull/9\r\n\r\n### Changes\r\n- Onboarding page architecture refactor\r\n([issue](https://github.com/elastic/kibana/issues/174766))\r\n- Fixes #183765 (from [this Meta\r\nissue](https://github.com/elastic/kibana/issues/183760))\r\n\r\n---\r\n\r\n- The progress bar has been removed\r\n<img width=\"903\" alt=\"progress bar\"\r\nsrc=\"https://github.com/user-attachments/assets/f16f3b6d-609f-4178-b83e-3b2106ba56ea\">\r\n\r\n---\r\n\r\n- Card styles updated:\r\n - Icons updated to custom SVGs to have the correct color\r\n - Icon with circle background\r\n - Card internal content border removed\r\n\r\n| Old | New |\r\n| - | - |\r\n|<img width=\"1172\" alt=\"Old styles\"\r\nsrc=\"https://github.com/user-attachments/assets/5a75cd84-a30d-4621-88e3-17d837165016\">|<img\r\nwidth=\"1172\" alt=\"New styles\"\r\nsrc=\"https://github.com/user-attachments/assets/8059bcbc-2f3d-4c7e-ba4f-041a58b51372\">|\r\n\r\n---\r\n\r\n- Completed card styles updated:\r\n - Icon with green circle background\r\n\r\n| Old | New |\r\n| - | - |\r\n|<img width=\"1172\" alt=\"Old styles complete\"\r\nsrc=\"https://github.com/user-attachments/assets/3258c7be-4ffe-4d25-9cdb-d4fce66ce451\">|<img\r\nwidth=\"1172\" alt=\"New styles complete\"\r\nsrc=\"https://github.com/user-attachments/assets/7dac6ec0-d78d-4881-ae84-3b46562c6d7d\">|\r\n\r\n---\r\n\r\n- Improved \"Add data with integrations\" card\r\n\r\n| Old | New |\r\n| - | - |\r\n|<img width=\"1174\" alt=\"old integrations card\"\r\nsrc=\"https://github.com/user-attachments/assets/3c65c4f5-004b-4619-aa92-26ec0656a8e5\">|<img\r\nwidth=\"1174\" alt=\"new integrations card\"\r\nsrc=\"https://github.com/user-attachments/assets/634e5249-b169-4c93-865e-b82453db90bf\">|\r\n\r\n---\r\n\r\n- New \"Configure AI assistant\" card in a new \"Discover Elastic AI\" group\r\n\r\n\r\nhttps://github.com/user-attachments/assets/39bd0dd4-88ba-47df-a77b-6b9b2a185cef\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Angela Chuang <[email protected]>\r\nCo-authored-by: Agustina Nahir Ruidiaz <[email protected]>","sha":"d39c75a837e705637adc329887bc3b30ad90e79c"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Sergi Massaneda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug:
From: #183760
On the Security Onboarding page, users who are not able to access the integrations page are still prompted to add integrations.
Screen.Recording.2024-05-17.at.17.52.16.mov
Kibana/Elasticsearch Stack version:
8.14
Functional Area (e.g. Endpoint management, timelines, resolver, etc.):
Onboarding page.
Steps to reproduce:
Current behavior:
The "Add data with Integrations" step with the buttons still appears but once clicked the page shows an error since it's inaccessible.
Expected behavior:
The "Add data with Integrations" step should not appear for users that can not add integrations.
Any additional context (logs, chat logs, magical formulas, etc.):
It will be good to re-check what predefined roles should be able to add integrations in serverless, I have only been able to access the integrations page using
platform_engineerrole.The text was updated successfully, but these errors were encountered: