Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[One Discover] Breakdown the unified histogram by log.level for logs data sources #183498

Closed
gbamparop opened this issue May 15, 2024 · 3 comments · Fixed by #200584
Closed

[One Discover] Breakdown the unified histogram by log.level for logs data sources #183498

gbamparop opened this issue May 15, 2024 · 3 comments · Fixed by #200584
Assignees
Labels
Project:OneDiscover Enrich Discover with contextual awareness Team:obs-ux-logs Observability Logs User Experience Team

Comments

@gbamparop
Copy link
Contributor

📓 Summary

Logs Explorer currently uses log.level as the default breakdown field for the unified histogram. This field should also be the default when the logs context is enabled in Discover.

This depends on the work for contextual awareness.

@gbamparop gbamparop added Team:obs-ux-logs Observability Logs User Experience Team Project:OneDiscover Enrich Discover with contextual awareness labels May 15, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

@weltenwort
Copy link
Member

Once this has been implemented natively in Discover we need to remove the corresponding functionality in the Logs Explorer.

@kertal
Copy link
Member

kertal commented Jul 18, 2024

linking #186369 because this is a requirement for ES|QL

@tonyghiani tonyghiani changed the title Breakdown the unified histogram by log.level for logs data sources [One Discover] Breakdown the unified histogram by log.level for logs data sources Nov 18, 2024
@tonyghiani tonyghiani self-assigned this Nov 18, 2024
tonyghiani added a commit to tonyghiani/kibana that referenced this issue Nov 28, 2024
## 📓 Summary

Closes elastic#183498

This work sets the Breakdown selector for the Histogram to the
`log.level` field once a logs data source is resolved.
It also applies to ES|QL queries, the change is applied/removed on each
source change.

---------

Co-authored-by: Marco Antonio Ghiani <[email protected]>
Co-authored-by: Davis McPhee <[email protected]>
(cherry picked from commit ac6025e)

# Conflicts:
#	src/plugins/discover/public/application/main/state_management/discover_data_state_container.ts
#	src/plugins/discover/public/application/main/state_management/utils/change_data_view.ts
tonyghiani added a commit that referenced this issue Nov 28, 2024
#202105)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[One Discover] Breakdown by log.level for logs sources
(#200584)](#200584)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Marco Antonio
Ghiani","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-28T08:12:47Z","message":"[One
Discover] Breakdown by log.level for logs sources (#200584)\n\n## 📓
Summary\r\n\r\nCloses #183498 \r\n\r\nThis work sets the Breakdown
selector for the Histogram to the\r\n`log.level` field once a logs data
source is resolved.\r\nIt also applies to ES|QL queries, the change is
applied/removed on each\r\nsource
change.\r\n\r\n---------\r\n\r\nCo-authored-by: Marco Antonio Ghiani
<[email protected]>\r\nCo-authored-by: Davis McPhee
<[email protected]>","sha":"ac6025eaa1b5e0e733bab0110b60928e27ee6860","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:DataDiscovery","backport:prev-minor","Team:obs-ux-logs","Project:OneDiscover"],"number":200584,"url":"https://github.com/elastic/kibana/pull/200584","mergeCommit":{"message":"[One
Discover] Breakdown by log.level for logs sources (#200584)\n\n## 📓
Summary\r\n\r\nCloses #183498 \r\n\r\nThis work sets the Breakdown
selector for the Histogram to the\r\n`log.level` field once a logs data
source is resolved.\r\nIt also applies to ES|QL queries, the change is
applied/removed on each\r\nsource
change.\r\n\r\n---------\r\n\r\nCo-authored-by: Marco Antonio Ghiani
<[email protected]>\r\nCo-authored-by: Davis McPhee
<[email protected]>","sha":"ac6025eaa1b5e0e733bab0110b60928e27ee6860"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200584","number":200584,"mergeCommit":{"message":"[One
Discover] Breakdown by log.level for logs sources (#200584)\n\n## 📓
Summary\r\n\r\nCloses #183498 \r\n\r\nThis work sets the Breakdown
selector for the Histogram to the\r\n`log.level` field once a logs data
source is resolved.\r\nIt also applies to ES|QL queries, the change is
applied/removed on each\r\nsource
change.\r\n\r\n---------\r\n\r\nCo-authored-by: Marco Antonio Ghiani
<[email protected]>\r\nCo-authored-by: Davis McPhee
<[email protected]>","sha":"ac6025eaa1b5e0e733bab0110b60928e27ee6860"}}]}]
BACKPORT-->
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Dec 12, 2024
## 📓 Summary

Closes elastic#183498 

This work sets the Breakdown selector for the Histogram to the
`log.level` field once a logs data source is resolved.
It also applies to ES|QL queries, the change is applied/removed on each
source change.

---------

Co-authored-by: Marco Antonio Ghiani <[email protected]>
Co-authored-by: Davis McPhee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Project:OneDiscover Enrich Discover with contextual awareness Team:obs-ux-logs Observability Logs User Experience Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants