Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ES|QL] [Discover] Clicking the chart should create a where clause #183425

Closed
kertal opened this issue May 14, 2024 · 3 comments · Fixed by #184420
Closed

[ES|QL] [Discover] Clicking the chart should create a where clause #183425

kertal opened this issue May 14, 2024 · 3 comments · Fixed by #184420
Assignees
@stratoula
Labels
Feature:Discover Discover Application Feature:ES|QL ES|QL related features in Kibana impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Team:ESQL ES|QL related features in Kibana

Comments

@kertal
Copy link
Member

kertal commented May 14, 2024

Describe the feature:

One missing feature in Discover in ES|QL mode, is the ability to create filters by the Chart

  • the histogram should just update the time picker (this can be available on the dashboard too)
  • the charts created with transformational commands should append to the query (this can't be available on the dashboard)
@kertal kertal added Feature:Discover Discover Application impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana labels May 14, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

@kertal kertal mentioned this issue May 14, 2024
Closed
@stratoula stratoula mentioned this issue May 23, 2024
Merged
1 task
stratoula added a commit that referenced this issue May 27, 2024
@stratoula @dej611
[ES|QL] Filter by brushing a date histogram (#184012)
a2c2f65 
## Summary

Part of #183425

Adds support of brushing an ES|QL chart. It updates the timepicker.

![meow
(2)](https://github.com/elastic/kibana/assets/17003240/05ac4e92-ea88-4ab7-93f7-3e7c9e300176)


### Checklist

- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Marco Liberati <[email protected]>
@stratoula
Copy link
Contributor

The brushing a timeseries has already been merged #184012 and i am currently working on the second bullet point

@stratoula stratoula mentioned this issue Jun 3, 2024
Merged
2 tasks
@stratoula stratoula self-assigned this Jun 3, 2024
stratoula added a commit that referenced this issue Jun 10, 2024
@stratoula @kibanamachine @lukasolson
Creates ES|QL where filters for ordinal charts (#184420)
e1c86f1 
## Summary

Closes #183425


![meow](https://github.com/elastic/kibana/assets/17003240/88baec65-5c35-41f8-b01e-bbce88536c7d)

This PR enables the creation of where clause filters by clicking a chart
in Discover and wherever the ES|QL editor exists. This means that this
is not available in dashboards.

This is possible only for ordinal charts. For date fields is quite
difficult to know the interval so I don't allow it for now. We already
support brushing so time filtering is already available.

### Checklist
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Lukas Olson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stratoula stratoula

Labels
Feature:Discover Discover Application Feature:ES|QL ES|QL related features in Kibana impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Team:ESQL ES|QL related features in Kibana
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Creates ES|QL where filters for ordinal charts stratoula/kibana
3 participants
@kertal @elasticmachine @stratoula