Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Switching from vertical stacked bar chart to horizontal is flawed #182677

Closed
gvnmagni opened this issue May 6, 2024 · 3 comments · Fixed by #187475
Closed

[Lens] Switching from vertical stacked bar chart to horizontal is flawed #182677

gvnmagni opened this issue May 6, 2024 · 3 comments · Fixed by #187475
Assignees
@mbondyra
Labels
bug Fixes for quality problems that affect the customer experience Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@gvnmagni
Copy link

gvnmagni commented May 6, 2024

If users move from Barchart Stacked Vertical to Barchart Stacked Horizontal, instead of doing that Lens will display a generic barchart with all the categories divided. This is probably not the expected behavior

May-03-2024 14-21-00
@gvnmagni gvnmagni added the bug Fixes for quality problems that affect the customer experience label May 6, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label May 6, 2024
@gvnmagni
Copy link
Author

gvnmagni commented May 6, 2024

adding here response by @mbondyra:

that’s a flaw in our suggestion system… We differentiate ‘stacked’ vs ‘non-stacked’ as subtypes of our charts (if breakdown series will be stacked or side by side), but we always prioritize vertical dimension over the breakdown when switching between charts in chart switcher and don’t care about this usecase.

@lukasolson lukasolson added Team:Visualizations Visualization editors, elastic-charts and infrastructure and removed needs-team Issues missing a team label labels May 14, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@mbondyra mbondyra self-assigned this Aug 26, 2024
@mbondyra mbondyra mentioned this issue Aug 26, 2024
Merged
@mbondyra
Copy link
Contributor

This issue will not exist after merging the chart switch redesign, as it will impossible to move from vertical to horizontal using chart switcher. I'll close it beforehand.

mbondyra added a commit that referenced this issue Sep 5, 2024
@mbondyra
[Lens] Chart switch redesign (#187475)
9e8244f 
## Summary

1. The main change is chart switch redesign:

<img width="401" alt="Screenshot 2024-08-26 at 15 08 50"
src="https://github.com/user-attachments/assets/a2da17d5-b068-4eeb-9723-0b64cc6cbcf0">

2. Toolbar changes for most of the visualization (refer to design files)

<img width="930" alt="Screenshot 2024-08-26 at 15 09 14"
src="https://github.com/user-attachments/assets/7f76aed3-99d8-438b-b304-91042c99381d">

<img width="942" alt="Screenshot 2024-08-26 at 15 08 56"
src="https://github.com/user-attachments/assets/5bed1916-8723-42b5-8f7d-4b363c5736c9">



#### Subtasks
- reorders the elements in the charts switch
- redesigns chart switch visually
- adds deprecated group (metric)
- changes the add subtype layer menu
- adds description to chart switch
- subselect for bar/gauge visualizations
- adds border to workspace panel
- changes `boxesHorizontal` icon to `boxesVertical`

Resolves #179260 also fixes
#182677
switching between chart types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbondyra mbondyra

Labels
bug Fixes for quality problems that affect the customer experience Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Lens] Chart switch redesign mbondyra/kibana
6 participants
@dej611 @lukasolson @JasonStoltz @mbondyra @elasticmachine @gvnmagni