-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Deprecations] Report on # of external calls to deprecated Saved Objects APIs in Upgrade Assistant #182319
Comments
Pinging @elastic/kibana-core (Team:Core) |
@alisonelizabeth How feasible would this be? |
Pinging @elastic/kibana-management (Team:Kibana Management) |
@TinaHeiligers here is documentation on the current core deprecations service. Please have a look and let me know if you think that will help with your use case - https://github.com/elastic/kibana/blob/main/src/core/server/docs/kib_core_deprecations_service.mdx |
@gerard and I are considering 2 approaches to answer the question of "has this cluster made external calls to the deprecated APIs":
Ideally, we can go with option 1 to get an aggregated view of the number of times the APIs have been called over 6 months. This requires read access to the upstream cluster. If not possible, or there are security concerns, we'll have to go with option 2. |
I feel like this will indeed be a security concern, doesn't it? |
It's only a security concern if we connect to the cluster directly and expose sensitive info. The alternatives (less accurate but might be ok), are:
The first option's drawback is that we'll only get info for the current session since telemetry was last sent Not ideal, but certainly "safer" than reading the data from upstream. |
@Bamieh can you see how much effort it would be to extract usage counters from SO non-kibana requests in our telemetry data and surface that in the Upgrade Assistant? If it's not too much work, we can go with that implementation to make it visible that a deployment has an integration with the APIs. Alternative: |
@alisonelizabeth the issue we have with surfacing core's deprecations is that the deprecation service is in core!. Right now, we don't have a plugin to use the "standard" implementation. |
Ah, I see. Are you looking for further assistance from the Management team on this, or are you going to explore other options? |
I'm looking for any advice on the best option to get this done with the least overhead. Has the management team had to handle cases like this before? In your opinion, what would be the best? |
Once #117241 is complete any APIs with the |
The Saved Objects Global HTTP APIs were deprecated in 8.7.
Can we use the Upgrade Assistant to report the number of external requests to these APIs?
The text was updated successfully, but these errors were encountered: