[Discover][Observability] Register Logs Explorer top navigation #182230
Comments
gbamparop
added
Team:obs-ux-logs
|
Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs) |
@gbamparop My take is that we should keep it, aligning to a single actions design as the one we used for the project view since the beginning: 
This also means moving the beta badge (for the time we will still keep it), but the effort doesn't change since we already have this template in place for the project view top bar. Wdyt? |
|
@ninoslavmiskovic @alex-fedotyev what are your thoughts about having a different form per project type? The goal in this case would be to get feedback for the logs flavour. |
|
@gbamparop Do you mean per data type/source e.g. when users are exploring logs then they get one survey, and when they are exploring security events in Discover, then they get another ? This might be too granular. I think we should have one form for "One discover" and then we can have a question.. What kind of data are you exploring.. Logs, Metrics, Traces etc... |
|
Be aware that serverless has an overall "Give feedback" This means that there are 2 x Give feedback.. We need to consider a better UI for this.
|
|
@gbamparop I agree having two feedback CTA might be confusing, shall we remove the current link we have for Logs Explorer in favour of a One Discover link once the MVP is ready as @ninoslavmiskovic suggested? |
|
Another point to discuss is whether we want to keep the link "Open to Discover". I don't think there are many more benefits now in bringing the user in vanilla Discover switching tab with this link, given also that we'll soon have a single experience for all of this. My 2 cents is that we can remove it, wdyt? @gbamparop @ruflin |
|
I suggest to remove the If a user clicks on |
|
I agree that having two buttons up there is a little weird, but the behavior of keeping the current filters is pretty nice. Also we don't know whether we have the two tabs yet in all cases (on stateful it relies on the new navigation). Is it a lot of work to keep the current "Open in Discover" logic for now? If not, I think it's OK just retaining it and removing it with the final merge of the apps. |
Different behaviours, although it's not specified in any way that "Open in Discover" moves to discover with the current search from Logs Explorer. I find it quite confusing now that they appear on the same topnav. |
+1 if we can have one form. Good point for serverless, we could also consider removing it as Nicolas suggested, we haven't received many responses yet but we have recently changed the email validation settings.
This sounds good to me. |
|
I would bring the behaviour from "Open in Discover" to "Click on Tab" if possible that users keep state and remove the button. Is this complex to do? Otherwise, lets keep it for now temporary until the two apps have merged. |
This makes a lot of sense, although @flash1293 made a good point about still having the classic navigation bar without the tabs, so let's keep it temporary until the merge 👌 |
|
I now spent some time on the codebase for this task, here are some considerations that made me consider postponing this work until we remove the tabs for some limits it currently has: 1. There are currently 4 different scenarios for displaying the top nav. The current implementation between for tabs and navbar menu treats it as a unique topbar, so we cannot act and factor out the specific navbar menu without affecting the tabs' implementation.
This requires quite a lot of work to split the tabs and the navbar menu customization. 2. The logic to keep the filters applied on the "Open in Discover" menu item strongly depends on the data source selection and the Logs Explorer state logic, trying to register it as an external menu item in Discover would over-engineer the implementation, which I believe is not worth to mess it up now since it does its work well and will soon be removed. 3. With the context awareness in place, this observability navbar menu will become one of the available menus directly moved into Discover, it doesn't require the overhead of registering this externally since we'll be able to know in which context it should be displayed directly in Discover. As soon as we remove the tabs, we'll need to touch this part anyway to resolve the Obs logs navbar menu, but it will be much easier since it will just result in a cut/paste work from Logs Explorer to Discover for the remaining menu items. Also, all the above-described work wouldn't benefit the user experience if we do it now as there are no perceived changes on the UX, but it would just add more noise we have to clean up when removing the tabs. My take is that we should pause this work until we move forward with the next steps on the One Discover context resolution, please let me know if there is any concern around this. |
|
I think it makes sense to not invest in this until we are merging Log Explorer and Discover as part of "One Discover", and then revisit it again. |
|
@gbamparop @ninoslavmiskovic now that the contextual awareness architecture is in place, we can consider moving on with this. There are some changes in terms of scope:
The menu entries for logs should be applied one the logs data source context is resolved, and those are:
Is this still relevant? Is there any change to the above definition? |
These are the two items that need changing. We can explore whether we can have an extension point for these individual items instead of the whole top navigation bar. This can mean that for Alerts the extension point would be the popup that opens when the |
|
I'm interested how the
This is how it looks like in Logs explorer
We can definitely make the right side of the toolbar / top navigation bar configureable , this is something @davismcphee and I discussed yesterday, however this definitely needs design input, should it be another button, a link, something different? |
|
@kertal What I was thinking of is to use a separator between the saved search control and custom menu items: 
It doesn't convince me 100% having twice the solid button (the screen is purely copy/paste of some html), so we surely need some design input 👍 |
|
Hey team, This needs not only design but specifications, as per the One Discover program the stage of this initiative is "Not started", so let's start a PRD with relevant user stories etc. before we move forward and pass the specification to begin designing. I will add it to our sync. |
|
Hey @timductive I unassigned me here, because this is O11y that has the responsibility to register. I am on the work for the actual extension point. |
|
The dependency has now been resolved and the extension point is available. |
|
@LucaWintergerst @gbamparop Given the resolved dependency and that we can start working on this, a couple of unresolved questions:
|
…ic#198987) ## 📓 Summary Closes elastic#182230 This work introduces a new observability root profile and uses the new extension point to register custom actions on the app menu. The registered actions and link will appear only with the new project navigation enabled on an Observability project: - A link to the data sets quality page - On the alerts sub menu... - replace the default search rule creation with the observability custom threshold rule - add an entry to directly create an SLO for the current search To access the SLO capabilities without breaking the dependencies hierarchy of the new sustainable architecture, the feature is registered by the common plugin `discover-shared` in SLO and consumed then by Discover using the IoC principle. ## 🖼️ Screenshots ### Observability project solution - show new menu <img width="3004" alt="Screenshot 2024-11-06 at 12 37 02" src="https://github.com/user-attachments/assets/d70b532d-1889-4d5b-b2ee-de2f048560f4"> ### Search project solution - hide new menu <img width="3006" alt="Screenshot 2024-11-06 at 12 36 19" src="https://github.com/user-attachments/assets/660893c3-f6b5-4b06-b8de-50a61a6bdb98"> ### Default navigation mode - hide new menu <img width="3002" alt="Screenshot 2024-11-06 at 12 35 43" src="https://github.com/user-attachments/assets/674c5a08-0084-40e5-ae34-a56c363cacce"> ## 🎥 Demo https://github.com/user-attachments/assets/104e6074-0401-4fd2-a8e6-8b05f2c070d7 --------- Co-authored-by: Marco Antonio Ghiani <[email protected]> Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 9d38922) # Conflicts: # x-pack/plugins/observability_solution/slo/public/pages/slo_edit/shared_flyout/get_create_slo_flyout.tsx # x-pack/plugins/observability_solution/slo/public/plugin.ts # x-pack/plugins/observability_solution/slo/public/types.ts # x-pack/plugins/observability_solution/slo/tsconfig.json # x-pack/test_serverless/functional/test_suites/common/discover_ml_uptime/discover/search_source_alert.ts
…198987) (#200145) # Backport This will backport the following commits from `main` to `8.x`: - [[One Discover] Add app menu actions for Observability projects (#198987)](#198987) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Marco Antonio Ghiani","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-14T10:00:38Z","message":"[One Discover] Add app menu actions for Observability projects (#198987)\n\n## 📓 Summary\r\n\r\nCloses #182230 \r\n\r\nThis work introduces a new observability root profile and uses the new\r\nextension point to register custom actions on the app menu.\r\nThe registered actions and link will appear only with the new project\r\nnavigation enabled on an Observability project:\r\n- A link to the data sets quality page\r\n- On the alerts sub menu...\r\n- replace the default search rule creation with the observability custom\r\nthreshold rule\r\n - add an entry to directly create an SLO for the current search\r\n\r\nTo access the SLO capabilities without breaking the dependencies\r\nhierarchy of the new sustainable architecture, the feature is registered\r\nby the common plugin `discover-shared` in SLO and consumed then by\r\nDiscover using the IoC principle.\r\n\r\n## 🖼️ Screenshots\r\n\r\n### Observability project solution - show new menu\r\n\r\n<img width=\"3004\" alt=\"Screenshot 2024-11-06 at 12 37 02\"\r\nsrc=\"https://github.com/user-attachments/assets/d70b532d-1889-4d5b-b2ee-de2f048560f4\">\r\n\r\n### Search project solution - hide new menu\r\n\r\n<img width=\"3006\" alt=\"Screenshot 2024-11-06 at 12 36 19\"\r\nsrc=\"https://github.com/user-attachments/assets/660893c3-f6b5-4b06-b8de-50a61a6bdb98\">\r\n\r\n### Default navigation mode - hide new menu\r\n\r\n<img width=\"3002\" alt=\"Screenshot 2024-11-06 at 12 35 43\"\r\nsrc=\"https://github.com/user-attachments/assets/674c5a08-0084-40e5-ae34-a56c363cacce\">\r\n\r\n## 🎥 Demo\r\n\r\n\r\nhttps://github.com/user-attachments/assets/104e6074-0401-4fd2-a8e6-8b05f2c070d7\r\n\r\n---------\r\n\r\nCo-authored-by: Marco Antonio Ghiani <[email protected]>\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"9d38922401d0bbd0d95d750f68fec77ca22758fb","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-logs","Team:obs-ux-management","Project:OneDiscover"],"number":198987,"url":"https://github.com/elastic/kibana/pull/198987","mergeCommit":{"message":"[One Discover] Add app menu actions for Observability projects (#198987)\n\n## 📓 Summary\r\n\r\nCloses #182230 \r\n\r\nThis work introduces a new observability root profile and uses the new\r\nextension point to register custom actions on the app menu.\r\nThe registered actions and link will appear only with the new project\r\nnavigation enabled on an Observability project:\r\n- A link to the data sets quality page\r\n- On the alerts sub menu...\r\n- replace the default search rule creation with the observability custom\r\nthreshold rule\r\n - add an entry to directly create an SLO for the current search\r\n\r\nTo access the SLO capabilities without breaking the dependencies\r\nhierarchy of the new sustainable architecture, the feature is registered\r\nby the common plugin `discover-shared` in SLO and consumed then by\r\nDiscover using the IoC principle.\r\n\r\n## 🖼️ Screenshots\r\n\r\n### Observability project solution - show new menu\r\n\r\n<img width=\"3004\" alt=\"Screenshot 2024-11-06 at 12 37 02\"\r\nsrc=\"https://github.com/user-attachments/assets/d70b532d-1889-4d5b-b2ee-de2f048560f4\">\r\n\r\n### Search project solution - hide new menu\r\n\r\n<img width=\"3006\" alt=\"Screenshot 2024-11-06 at 12 36 19\"\r\nsrc=\"https://github.com/user-attachments/assets/660893c3-f6b5-4b06-b8de-50a61a6bdb98\">\r\n\r\n### Default navigation mode - hide new menu\r\n\r\n<img width=\"3002\" alt=\"Screenshot 2024-11-06 at 12 35 43\"\r\nsrc=\"https://github.com/user-attachments/assets/674c5a08-0084-40e5-ae34-a56c363cacce\">\r\n\r\n## 🎥 Demo\r\n\r\n\r\nhttps://github.com/user-attachments/assets/104e6074-0401-4fd2-a8e6-8b05f2c070d7\r\n\r\n---------\r\n\r\nCo-authored-by: Marco Antonio Ghiani <[email protected]>\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"9d38922401d0bbd0d95d750f68fec77ca22758fb"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198987","number":198987,"mergeCommit":{"message":"[One Discover] Add app menu actions for Observability projects (#198987)\n\n## 📓 Summary\r\n\r\nCloses #182230 \r\n\r\nThis work introduces a new observability root profile and uses the new\r\nextension point to register custom actions on the app menu.\r\nThe registered actions and link will appear only with the new project\r\nnavigation enabled on an Observability project:\r\n- A link to the data sets quality page\r\n- On the alerts sub menu...\r\n- replace the default search rule creation with the observability custom\r\nthreshold rule\r\n - add an entry to directly create an SLO for the current search\r\n\r\nTo access the SLO capabilities without breaking the dependencies\r\nhierarchy of the new sustainable architecture, the feature is registered\r\nby the common plugin `discover-shared` in SLO and consumed then by\r\nDiscover using the IoC principle.\r\n\r\n## 🖼️ Screenshots\r\n\r\n### Observability project solution - show new menu\r\n\r\n<img width=\"3004\" alt=\"Screenshot 2024-11-06 at 12 37 02\"\r\nsrc=\"https://github.com/user-attachments/assets/d70b532d-1889-4d5b-b2ee-de2f048560f4\">\r\n\r\n### Search project solution - hide new menu\r\n\r\n<img width=\"3006\" alt=\"Screenshot 2024-11-06 at 12 36 19\"\r\nsrc=\"https://github.com/user-attachments/assets/660893c3-f6b5-4b06-b8de-50a61a6bdb98\">\r\n\r\n### Default navigation mode - hide new menu\r\n\r\n<img width=\"3002\" alt=\"Screenshot 2024-11-06 at 12 35 43\"\r\nsrc=\"https://github.com/user-attachments/assets/674c5a08-0084-40e5-ae34-a56c363cacce\">\r\n\r\n## 🎥 Demo\r\n\r\n\r\nhttps://github.com/user-attachments/assets/104e6074-0401-4fd2-a8e6-8b05f2c070d7\r\n\r\n---------\r\n\r\nCo-authored-by: Marco Antonio Ghiani <[email protected]>\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"9d38922401d0bbd0d95d750f68fec77ca22758fb"}}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <[email protected]>
…ic#198987) ## 📓 Summary Closes elastic#182230 This work introduces a new observability root profile and uses the new extension point to register custom actions on the app menu. The registered actions and link will appear only with the new project navigation enabled on an Observability project: - A link to the data sets quality page - On the alerts sub menu... - replace the default search rule creation with the observability custom threshold rule - add an entry to directly create an SLO for the current search To access the SLO capabilities without breaking the dependencies hierarchy of the new sustainable architecture, the feature is registered by the common plugin `discover-shared` in SLO and consumed then by Discover using the IoC principle. ## 🖼️ Screenshots ### Observability project solution - show new menu <img width="3004" alt="Screenshot 2024-11-06 at 12 37 02" src="https://github.com/user-attachments/assets/d70b532d-1889-4d5b-b2ee-de2f048560f4"> ### Search project solution - hide new menu <img width="3006" alt="Screenshot 2024-11-06 at 12 36 19" src="https://github.com/user-attachments/assets/660893c3-f6b5-4b06-b8de-50a61a6bdb98"> ### Default navigation mode - hide new menu <img width="3002" alt="Screenshot 2024-11-06 at 12 35 43" src="https://github.com/user-attachments/assets/674c5a08-0084-40e5-ae34-a56c363cacce"> ## 🎥 Demo https://github.com/user-attachments/assets/104e6074-0401-4fd2-a8e6-8b05f2c070d7 --------- Co-authored-by: Marco Antonio Ghiani <[email protected]> Co-authored-by: kibanamachine <[email protected]>
…ic#198987) ## 📓 Summary Closes elastic#182230 This work introduces a new observability root profile and uses the new extension point to register custom actions on the app menu. The registered actions and link will appear only with the new project navigation enabled on an Observability project: - A link to the data sets quality page - On the alerts sub menu... - replace the default search rule creation with the observability custom threshold rule - add an entry to directly create an SLO for the current search To access the SLO capabilities without breaking the dependencies hierarchy of the new sustainable architecture, the feature is registered by the common plugin `discover-shared` in SLO and consumed then by Discover using the IoC principle. ## 🖼️ Screenshots ### Observability project solution - show new menu <img width="3004" alt="Screenshot 2024-11-06 at 12 37 02" src="https://github.com/user-attachments/assets/d70b532d-1889-4d5b-b2ee-de2f048560f4"> ### Search project solution - hide new menu <img width="3006" alt="Screenshot 2024-11-06 at 12 36 19" src="https://github.com/user-attachments/assets/660893c3-f6b5-4b06-b8de-50a61a6bdb98"> ### Default navigation mode - hide new menu <img width="3002" alt="Screenshot 2024-11-06 at 12 35 43" src="https://github.com/user-attachments/assets/674c5a08-0084-40e5-ae34-a56c363cacce"> ## 🎥 Demo https://github.com/user-attachments/assets/104e6074-0401-4fd2-a8e6-8b05f2c070d7 --------- Co-authored-by: Marco Antonio Ghiani <[email protected]> Co-authored-by: kibanamachine <[email protected]>
📓 Summary
The top navigation in Logs Explorer includes links to the Observability onboarding guides as well as actions to create rules and SLOs while maintaining context. This functionality will be moved to Discover for Observability projects.
✔ Acceptance Criteria
as a feature using the DiscoverFeaturesRegistry provided by theusing the newly created extension point.discover-sharedplugin❓ Open questions
The text was updated successfully, but these errors were encountered: