-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SecuritySolution] Risk contributions panel displays negative zero when criticality is Medium #182224
Labels
bug
Fixes for quality problems that affect the customer experience
Feature:Entity Analytics
Security Solution Entity Analytics features
Team:Entity Analytics
Security Entity Analytics Team
Team: SecuritySolution
Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Comments
machadoum
added
bug
Fixes for quality problems that affect the customer experience
Team: SecuritySolution
Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Feature:Entity Analytics
Security Solution Entity Analytics features
Team:Entity Analytics
Security Entity Analytics Team
labels
May 1, 2024
Pinging @elastic/security-entity-analytics (Team:Entity Analytics) |
Pinging @elastic/security-solution (Team: SecuritySolution) |
hop-dev
added a commit
that referenced
this issue
May 7, 2024
… less than -0.01 (#182356) Closes #182224 If an asset criticality contribution score was below -0.01 e.g 0.0000001 then we would display it as -0.0.0 Skipping release notes as this feature was introduced in 8.14 and I'm back-porting. Before: <img width="686" alt="Screenshot 2024-05-02 at 13 13 36" src="https://github.com/elastic/kibana/assets/3315046/8d4fa427-6762-486c-b6e2-ac0f1c544f09"> After: <img width="604" alt="Screenshot 2024-05-02 at 13 13 56" src="https://github.com/elastic/kibana/assets/3315046/a6f8808b-cf0c-4c86-8286-f8d3998ae69e"> --------- Co-authored-by: Kibana Machine <[email protected]>
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
May 7, 2024
… less than -0.01 (elastic#182356) Closes elastic#182224 If an asset criticality contribution score was below -0.01 e.g 0.0000001 then we would display it as -0.0.0 Skipping release notes as this feature was introduced in 8.14 and I'm back-porting. Before: <img width="686" alt="Screenshot 2024-05-02 at 13 13 36" src="https://github.com/elastic/kibana/assets/3315046/8d4fa427-6762-486c-b6e2-ac0f1c544f09"> After: <img width="604" alt="Screenshot 2024-05-02 at 13 13 56" src="https://github.com/elastic/kibana/assets/3315046/a6f8808b-cf0c-4c86-8286-f8d3998ae69e"> --------- Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit a8a6003)
kibanamachine
added a commit
that referenced
this issue
May 7, 2024
…butions less than -0.01 (#182356) (#182777) # Backport This will backport the following commits from `main` to `8.14`: - [[Entity Analytics] Do not display -0.00 for criticality contributions less than -0.01 (#182356)](#182356) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Mark Hopkin","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-05-07T08:18:34Z","message":"[Entity Analytics] Do not display -0.00 for criticality contributions less than -0.01 (#182356)\n\nCloses #182224\r\n\r\nIf an asset criticality contribution score was below -0.01 e.g 0.0000001\r\nthen we would display it as -0.0.0\r\n\r\nSkipping release notes as this feature was introduced in 8.14 and I'm\r\nback-porting.\r\n\r\nBefore:\r\n<img width=\"686\" alt=\"Screenshot 2024-05-02 at 13 13 36\"\r\nsrc=\"https://github.com/elastic/kibana/assets/3315046/8d4fa427-6762-486c-b6e2-ac0f1c544f09\">\r\n\r\nAfter:\r\n<img width=\"604\" alt=\"Screenshot 2024-05-02 at 13 13 56\"\r\nsrc=\"https://github.com/elastic/kibana/assets/3315046/a6f8808b-cf0c-4c86-8286-f8d3998ae69e\">\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"a8a6003c406099ada70e16ded665eea0778b99f5","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","Team:Entity Analytics","v8.15.0"],"title":"[Entity Analytics] Do not display -0.00 for criticality contributions less than -0.01","number":182356,"url":"https://github.com/elastic/kibana/pull/182356","mergeCommit":{"message":"[Entity Analytics] Do not display -0.00 for criticality contributions less than -0.01 (#182356)\n\nCloses #182224\r\n\r\nIf an asset criticality contribution score was below -0.01 e.g 0.0000001\r\nthen we would display it as -0.0.0\r\n\r\nSkipping release notes as this feature was introduced in 8.14 and I'm\r\nback-porting.\r\n\r\nBefore:\r\n<img width=\"686\" alt=\"Screenshot 2024-05-02 at 13 13 36\"\r\nsrc=\"https://github.com/elastic/kibana/assets/3315046/8d4fa427-6762-486c-b6e2-ac0f1c544f09\">\r\n\r\nAfter:\r\n<img width=\"604\" alt=\"Screenshot 2024-05-02 at 13 13 56\"\r\nsrc=\"https://github.com/elastic/kibana/assets/3315046/a6f8808b-cf0c-4c86-8286-f8d3998ae69e\">\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"a8a6003c406099ada70e16ded665eea0778b99f5"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/182356","number":182356,"mergeCommit":{"message":"[Entity Analytics] Do not display -0.00 for criticality contributions less than -0.01 (#182356)\n\nCloses #182224\r\n\r\nIf an asset criticality contribution score was below -0.01 e.g 0.0000001\r\nthen we would display it as -0.0.0\r\n\r\nSkipping release notes as this feature was introduced in 8.14 and I'm\r\nback-porting.\r\n\r\nBefore:\r\n<img width=\"686\" alt=\"Screenshot 2024-05-02 at 13 13 36\"\r\nsrc=\"https://github.com/elastic/kibana/assets/3315046/8d4fa427-6762-486c-b6e2-ac0f1c544f09\">\r\n\r\nAfter:\r\n<img width=\"604\" alt=\"Screenshot 2024-05-02 at 13 13 56\"\r\nsrc=\"https://github.com/elastic/kibana/assets/3315046/a6f8808b-cf0c-4c86-8286-f8d3998ae69e\">\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"a8a6003c406099ada70e16ded665eea0778b99f5"}}]}] BACKPORT--> Co-authored-by: Mark Hopkin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Fixes for quality problems that affect the customer experience
Feature:Entity Analytics
Security Solution Entity Analytics features
Team:Entity Analytics
Security Entity Analytics Team
Team: SecuritySolution
Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Kibana version:
8.15.0 (main branch)
Elasticsearch version:
8.15.0 (main branch)
Describe the bug:
When assigning an asset with the criticality level "Medium Impact", it displays negative zero ("-0.00") risk score contribution inside the risk contributions panel.
Steps to reproduce:
Expected behavior:
It should display zero without the negative sign
Screenshots (if relevant):
The text was updated successfully, but these errors were encountered: