Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning when deleting integration policy to notify about being used by agent policies #182218

Closed
1 task
Tracked by #75867
juliaElastic opened this issue May 1, 2024 · 2 comments · Fixed by #186316
Closed
1 task
Tracked by #75867

Add warning when deleting integration policy to notify about being used by agent policies #182218

juliaElastic opened this issue May 1, 2024 · 2 comments · Fixed by #186316
Assignees
@criamico
Labels
QA:Needs Validation Issue needs to be validated by QA Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@juliaElastic
Copy link
Contributor

juliaElastic commented May 1, 2024 •
edited
Loading

Part of the reusable integration policies work.

Currently there is a warning on integration policy delete action if it is being used by an agent policy with enrolled agents.

  • Enhance this warning to warn about the integration policy being shared by multiple agent policies: "WARNING: this integration is shared by other agent policies"
image image
@juliaElastic juliaElastic mentioned this issue May 1, 2024
Closed
@botelastic botelastic bot added the needs-team Issues missing a team label label May 1, 2024
@juliaElastic juliaElastic added the Team:Fleet Team label for Observability Data Collection Fleet team label May 1, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@botelastic botelastic bot removed the needs-team Issues missing a team label label May 1, 2024
@kpollich kpollich added the QA:Needs Validation Issue needs to be validated by QA label Jun 6, 2024
@criamico
Copy link
Contributor

@juliaElastic do you think this way is clear enough?

Screenshot 2024-06-17 at 11 57 50

otherwise I could add a warning callout to the existing danger one but I think it gets confusing. What do you think?

@criamico criamico mentioned this issue Jun 18, 2024
Merged
3 tasks
criamico added a commit that referenced this issue Jun 19, 2024
@criamico @kibanamachine
[Fleet] Adjust delete package policy warning for multiple agent polic…
6e905c2 
…ies (#186316)

Fixes #182218

## Summary
Add a warning to integration policy delete action in case of multiple
agent policies.

![Screenshot 2024-06-19 at 10 17
52](https://github.com/elastic/kibana/assets/16084106/dacca9f8-afd1-4290-bf6e-ea8cb468a5b7)
![Screenshot 2024-06-19 at 10 17
56](https://github.com/elastic/kibana/assets/16084106/6c2322c1-e9a6-4028-9ea4-e84659445e19)


## Testing
- Enable `enableReusableIntegrationPolicies`
- Get an integration that has multiple agent policies and navigate to
`integrations/detail/{pkgName-Version}/policies`
- From the actions on the rigth, select `Delete integration`
- A warning with `This integration is shared by multiple agent
policies.` should be displayed

### Checklist

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@criamico criamico

Labels
QA:Needs Validation Issue needs to be validated by QA Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fleet] Adjust delete package policy warning for multiple agent policies criamico/kibana
4 participants
@kpollich @elasticmachine @criamico @juliaElastic