Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Observability Onboarding] Selecting a collection should scroll to the integration grid instead of focussing the search term field #180814

Closed
thomheymann opened this issue Apr 15, 2024 · 1 comment · Fixed by #180961
Closed

[Observability Onboarding] Selecting a collection should scroll to the integration grid instead of focussing the search term field #180814

thomheymann opened this issue Apr 15, 2024 · 1 comment · Fixed by #180961
Assignees
@justinkambic
Labels
Team:obs-ux-logs Observability Logs User Experience Team

Comments

@thomheymann
Copy link
Contributor

thomheymann commented Apr 15, 2024 •
edited
Loading

When selecting a collection the UI currently places focus on and scrolls to the search term field.

Instead the UI should smoothly scroll to the integrations grid since that's the next field the user is expected to interact with.

Image
@thomheymann thomheymann changed the title [Observability Onboarding] Selecting a collection should scroll to and focus the grid, not the search term field (scrolling should be smooth) [Observability Onboarding] Selecting a collection should scroll to the integration grid instead of focussing the search term field Apr 15, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Apr 15, 2024
@dej611 dej611 added the Team:obs-ux-logs Observability Logs User Experience Team label Apr 16, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Apr 16, 2024
@justinkambic justinkambic self-assigned this Apr 16, 2024
@justinkambic justinkambic mentioned this issue Apr 16, 2024
Merged
flash1293 added a commit that referenced this issue Apr 22, 2024
@justinkambic @flash1293
[Observability Onboarding] Scroll to Package List on collection click (…
fa936db 
…#180961)

## Summary

Resolves #180814.

When the user clicks a collection, we are presently focusing the search
bar and scrolling to it.

This patch will change the behavior to _not_ change the focus
programmatically, and smooth scroll the package list into view.

### Note

I am open to suggestions on how to make
[this](https://github.com/elastic/kibana/pull/180961/files#diff-23a1716beb9bc5c1c0ef8b6f30f0f805fb7f148770f3dc82a035fcd4bbdb1658R94)
less of a hack, but it make the experience better because we give the
component time to render before doing the scroll. Here's a before/after:

#### Before

On initial click of the Azure collection, we only see two rows from the
scroll.


![20240416120336](https://github.com/elastic/kibana/assets/18429259/665e99ed-861d-4ba1-acc4-8cf5422973e9)



#### After

With the delay, we see the full row.


![20240416122920](https://github.com/elastic/kibana/assets/18429259/2fd9f7c4-c81a-45a8-876f-eb2b1d94db73)

---------

Co-authored-by: Joe Reuter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@justinkambic justinkambic

Labels
Team:obs-ux-logs Observability Logs User Experience Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Observability Onboarding] Scroll to Package List on collection click justinkambic/kibana
4 participants
@thomheymann @dej611 @elasticmachine @justinkambic