Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Detection Engine][FTR] Unskip skipped tests in x-pack/test/security_solution_api_integration/test_suites/detections_response/detection_engine/alerts/basic_license_essentials_tier/ess_specific_index_logic/create_index.ts #179208

Closed
1 task
yctercero opened this issue Mar 22, 2024 · 1 comment
Closed
1 task

[Detection Engine][FTR] Unskip skipped tests in x-pack/test/security_solution_api_integration/test_suites/detections_response/detection_engine/alerts/basic_license_essentials_tier/ess_specific_index_logic/create_index.ts #179208

yctercero opened this issue Mar 22, 2024 · 1 comment
Assignees
@vitaliidm
Labels
skipped-test Team:Detection Engine Security Solution Detection Engine Area tests_needed

Comments

@yctercero
Copy link
Contributor

The following tests in the suite are skipped and have been for some time. Need to evaluate what it is testing, if it's still needed, and if so how to unskip it.

Skipped tests
Preview Give feedback
@yctercero yctercero added tests_needed skipped-test Team:Detection Engine Security Solution Detection Engine Area labels Mar 22, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-engine (Team:Detection Engine)

@yctercero yctercero mentioned this issue Mar 22, 2024
Merged
@vitaliidm vitaliidm self-assigned this Jun 19, 2024
@vitaliidm vitaliidm mentioned this issue Jun 24, 2024
Merged
vitaliidm added a commit that referenced this issue Jun 25, 2024
@vitaliidm
[Security solution][Detection Engine] removes skipped "alerts index d…
c47f483 
…oes not exist" FTR test (#186789)

## Summary

- addresses #179208 by removing
skipped test

I tracked skipped test to this PR:
#115290

Test was added already skipped
https://github.com/elastic/kibana/pull/115290/files#diff-16cebcbaef99c1aab50640a5bee66351bcbfd7575361d97eee4d2ca6753f5a27R38-R41

In the tested route itself, when index does not exist, it returns 200:
https://github.com/elastic/kibana/pull/115290/files#diff-a4e27aaa05560a7737e153e53fe4bdaf839056180347c338e8d0842ab39f1240R79-R84

So, test from the very beginning was not testing valid use case.

After talking to PR author @marshallmain , we agreed to remove that test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vitaliidm vitaliidm

Labels
skipped-test Team:Detection Engine Security Solution Detection Engine Area tests_needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yctercero @elasticmachine @vitaliidm