Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Remove @ts-expect-error from v4.9.5 upgrade (Rule Management area) #176287

Closed
banderror opened this issue Feb 6, 2024 · 5 comments · Fixed by #179273
Closed

[Security Solution] Remove @ts-expect-error from v4.9.5 upgrade (Rule Management area) #176287

banderror opened this issue Feb 6, 2024 · 5 comments · Fixed by #179273
Assignees
@banderror
Labels
8.14 candidate Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. technical debt Improvement of the software architecture and operational architecture

Comments

@banderror
Copy link
Contributor

Summary

When #175178 is merged, we will need to address:
@banderror banderror added technical debt Improvement of the software architecture and operational architecture Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team labels Feb 6, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management)

@banderror banderror self-assigned this Feb 6, 2024
@yctercero
Copy link
Contributor

Hey @banderror ! I think we can close this one as a duplicate of #176126

@banderror
Copy link
Contributor Author

@yctercero This one is for fixes in the code owned by @elastic/security-detection-rule-management.

@banderror banderror mentioned this issue Mar 22, 2024
Merged
banderror added a commit that referenced this issue Mar 27, 2024
@banderror
[Security Solution] Remove @ts-expect-error from v4.9.5 upgrade in De…
f96818a 
…tection and Response areas (#179273)

**Resolves: #176287
**Resolves: #176126

## Summary

In #175178 Kibana was upgraded to
TypeScript v4.9.5. That PR introduced a few type errors which were
skipped by adding `@ts-expect-error` comments. This PR attempts to fix
those type errors and remove the comments.
banderror added a commit to banderror/kibana that referenced this issue Mar 27, 2024
@banderror
[Security Solution] Remove @ts-expect-error from v4.9.5 upgrade in De…
c6216ef 
…tection and Response areas (elastic#179273)

**Resolves: elastic#176287
**Resolves: elastic#176126

## Summary

In elastic#175178 Kibana was upgraded to
TypeScript v4.9.5. That PR introduced a few type errors which were
skipped by adding `@ts-expect-error` comments. This PR attempts to fix
those type errors and remove the comments.

(cherry picked from commit f96818a)

# Conflicts:
#	packages/kbn-securitysolution-utils/src/add_remove_id_to_item/index.ts
#	x-pack/plugins/security_solution/server/lib/detection_engine/routes/utils.ts
#	x-pack/plugins/security_solution/server/lib/detection_engine/rule_management/logic/bulk_actions/utils.ts
#	x-pack/plugins/security_solution/server/lib/detection_engine/rule_management/logic/bulk_actions/validations.ts
banderror referenced this issue Mar 28, 2024
@banderror
[8.13] [Security Solution] Remove @ts-expect-error from v4.9.5 upgrad…
e11c3c9 
…e in Detection and Response areas (#179273) (#179569)

# Backport

This will backport the following commits from `main` to `8.13`:
- [[Security Solution] Remove @ts-expect-error from v4.9.5 upgrade in
Detection and Response areas
(#179273)](#179273)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Georgii
Gorbachev","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-03-27T12:01:53Z","message":"[Security
Solution] Remove @ts-expect-error from v4.9.5 upgrade in Detection and
Response areas (#179273)\n\n**Resolves:
https://github.com/elastic/kibana/issues/176287**\r\n**Resolves:
https://github.com/elastic/kibana/issues/176126**\r\n\r\n##
Summary\r\n\r\nIn #175178 Kibana
was upgraded to\r\nTypeScript v4.9.5. That PR introduced a few type
errors which were\r\nskipped by adding `@ts-expect-error` comments. This
PR attempts to fix\r\nthose type errors and remove the
comments.","sha":"f96818a0cb4cf20eeddf90f36aea4e0e67abefbd","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["chore","technical
debt","release_note:skip","Team:Detections and Resp","Team:
SecuritySolution","Team:Detection Rule Management","Team:Detection
Engine","v8.14.0","v8.13.1"],"number":179273,"url":"https://github.com/elastic/kibana/pull/179273","mergeCommit":{"message":"[Security
Solution] Remove @ts-expect-error from v4.9.5 upgrade in Detection and
Response areas (#179273)\n\n**Resolves:
https://github.com/elastic/kibana/issues/176287**\r\n**Resolves:
https://github.com/elastic/kibana/issues/176126**\r\n\r\n##
Summary\r\n\r\nIn #175178 Kibana
was upgraded to\r\nTypeScript v4.9.5. That PR introduced a few type
errors which were\r\nskipped by adding `@ts-expect-error` comments. This
PR attempts to fix\r\nthose type errors and remove the
comments.","sha":"f96818a0cb4cf20eeddf90f36aea4e0e67abefbd"}},"sourceBranch":"main","suggestedTargetBranches":["8.13"],"targetPullRequestStates":[{"branch":"main","label":"v8.14.0","labelRegex":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/179273","number":179273,"mergeCommit":{"message":"[Security
Solution] Remove @ts-expect-error from v4.9.5 upgrade in Detection and
Response areas (#179273)\n\n**Resolves:
https://github.com/elastic/kibana/issues/176287**\r\n**Resolves:
https://github.com/elastic/kibana/issues/176126**\r\n\r\n##
Summary\r\n\r\nIn #175178 Kibana
was upgraded to\r\nTypeScript v4.9.5. That PR introduced a few type
errors which were\r\nskipped by adding `@ts-expect-error` comments. This
PR attempts to fix\r\nthose type errors and remove the
comments.","sha":"f96818a0cb4cf20eeddf90f36aea4e0e67abefbd"}},{"branch":"8.13","label":"v8.13.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@banderror banderror

Labels
8.14 candidate Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
3 participants
@banderror @yctercero @elasticmachine