-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failing test: Serverless Observability Feature Flags API Integration Tests.x-pack/test_serverless/api_integration/test_suites/observability/custom_threshold_rule/group_by_fired·ts - Serverless observability API - feature flags Custom Threshold Rule Custom Threshold rule - GROUP_BY - FIRED Rule creation should set correct action variables #175776
Comments
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
From the 4 instances above, 2 of them were wrong values in test that was fixed in the PR, and for the other 2, the root cause mentioned in the logs is:
In both cases, we have the following error log in task manager:
Started a discussion in Slack. UpdateIt seems eventually a document is found but the information in that document is not as we expetected:
|
…hod from retryService (#178515) Related to #176401, #175776 ## Summary This PR: - Improves logging (I've added debug logs to the helpers that does an API request such as creating a data view) - Uses retryService instead of pRetry - In case of throwing an error in pRetry, when we have 10 retries, it does not log the retry attempts and we end up in the situation that is mentioned in this [comment, item 3](#176401 (comment)) |Before|After| |---|---| |![image](https://github.com/elastic/kibana/assets/12370520/576146f2-09da-4221-a570-6d47e047f229)|![image](https://github.com/elastic/kibana/assets/12370520/0a0897a3-0bd3-4d44-9b79-8f99fb580b4a)| - Attempts to fix flakiness in rate reason message due to having different data ![image](https://github.com/elastic/kibana/assets/12370520/dff48ac1-a9bf-4b93-addb-fd40acae382e) ### Flaky test runner #### Current (after adding refresh index and adjusting timeout) - [25] https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5463 ✅ - [200] https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5465 ✅ #### Old - [25] https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5452 ✅ - [200] https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5454 [1 Failed : 25 Canceled: 174 Passed ] ##### After checking data is generated in metric threshold - [25] https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5460 ✅ - [200] https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5462 [1 Failed : 199 Canceled ] Inspired by #173998, special thanks to @jpdjere and @dmlemeshko for their support and knowledge sharing.
I made some improvements in this PR and will close this issue as I didn't see a failure when I ran the test 200 times after the improvement. I've also added some logs, so if it happens again, hopefully, it will be easier to investigate it. |
New failure: CI Build - 8.14 |
A test failed on a tracked branch
First failure: CI Build - main
The text was updated successfully, but these errors were encountered: