Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fullscreen URL param no longer works #174561

Closed
cbake886 opened this issue Jan 10, 2024 · 3 comments · Fixed by #196275
Closed

Fullscreen URL param no longer works #174561

cbake886 opened this issue Jan 10, 2024 · 3 comments · Fixed by #196275
Labels
bug Fixes for quality problems that affect the customer experience impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort regression Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@cbake886
Copy link

cbake886 commented Jan 10, 2024 •
edited
Loading

Kibana version:
8.10.4, 8.11, 8.12
Elasticsearch version:
n/a
Server OS version:
Linux
Browser version:
Chrome 120
Describe the bug:
I have a client that utilizes Elastic for various high level reporting and dashboarding tasks. Recently we migrated them over to 8.x versions but now the &_a=(fullScreenMode:!t) URL param to have their Dashboards go to full screen by default is not working. This was working prior to 8.x Kibana
Steps to reproduce:

  1. install / load up kibana 8.x+
  2. go to a dashboard and add &_a=(fullScreenMode:!t) to the end of url
  3. Does not go full screen

Expected behavior:
adding &_a=(fullScreenMode:!t) to the end of url should make it go full screen
Screenshots (if relevant):
n/a
Errors in browser console (if relevant):
none
Provide logs and/or server output (if relevant):
none
Any additional context:
this is used by many large corps to have the default route for a space to auto load into a full screen dash.
@cbake886 cbake886 added the bug Fixes for quality problems that affect the customer experience label Jan 10, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Jan 10, 2024
@jughosta jughosta added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Jan 15, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 15, 2024
@Heenawter
Copy link
Contributor

Heenawter commented Jan 15, 2024 •
edited
Loading

Looks like this problem dates all the way back to the portable dashboards work - tested on that PR and the fullscreenMode param didn't work; tested on the PR that came right before that one was merged, and it worked.

@Heenawter Heenawter added loe:small Small Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Jan 15, 2024
@ThomThomson ThomThomson changed the title fullscreen URL param no longer works Fullscreen URL param no longer works Jan 16, 2024
@cbake886
Copy link
Author

Is there an ETA on when a fix will be in place?

@lsq645599166 lsq645599166 mentioned this issue Oct 15, 2024
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 24, 2024
@lsq645599166
[Dashboard] show fullscreen mode when url has fullScreenMode param (e…
e210530 
…lastic#196275)

## Summary

Closes elastic#174561

Show fullscreen mode when url has fullScreenMode param
`&_a=(fullScreenMode:!t)`

### Screenshot

![20241015-184503](https://github.com/user-attachments/assets/fae01dcc-f081-4314-84f9-3923adc76e5b)

---------

Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: Hannah Mudge <[email protected]>
(cherry picked from commit 72c0b81)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 24, 2024
@lsq645599166
[Dashboard] show fullscreen mode when url has fullScreenMode param (e…
2d222ba 
…lastic#196275)

## Summary

Closes elastic#174561

Show fullscreen mode when url has fullScreenMode param
`&_a=(fullScreenMode:!t)`

### Screenshot

![20241015-184503](https://github.com/user-attachments/assets/fae01dcc-f081-4314-84f9-3923adc76e5b)

---------

Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: Hannah Mudge <[email protected]>
(cherry picked from commit 72c0b81)
kibanamachine added a commit that referenced this issue Oct 24, 2024
@kibanamachine @lsq645599166
[8.16] [Dashboard] show fullscreen mode when url has fullScreenMode p…
a25a84f 
…aram (#196275) (#197728)

# Backport

This will backport the following commits from `main` to `8.16`:
- [[Dashboard] show fullscreen mode when url has fullScreenMode param
(#196275)](#196275)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Henry
Liu","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-24T20:49:39Z","message":"[Dashboard]
show fullscreen mode when url has fullScreenMode param (#196275)\n\n##
Summary\r\n\r\nCloses #174561\r\n\r\nShow fullscreen mode when url has
fullScreenMode param\r\n`&_a=(fullScreenMode:!t)`\r\n\r\n###
Screenshot\r\n\r\n\r\n![20241015-184503](https://github.com/user-attachments/assets/fae01dcc-f081-4314-84f9-3923adc76e5b)\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>\r\nCo-authored-by: Hannah
Mudge
<[email protected]>","sha":"72c0b81994d28f3983c2d21d662bd025653054fa","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Presentation","loe:small","impact:medium","💝community","v9.0.0","backport:prev-major"],"title":"[Dashboard]
show fullscreen mode when url has fullScreenMode
param","number":196275,"url":"https://github.com/elastic/kibana/pull/196275","mergeCommit":{"message":"[Dashboard]
show fullscreen mode when url has fullScreenMode param (#196275)\n\n##
Summary\r\n\r\nCloses #174561\r\n\r\nShow fullscreen mode when url has
fullScreenMode param\r\n`&_a=(fullScreenMode:!t)`\r\n\r\n###
Screenshot\r\n\r\n\r\n![20241015-184503](https://github.com/user-attachments/assets/fae01dcc-f081-4314-84f9-3923adc76e5b)\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>\r\nCo-authored-by: Hannah
Mudge
<[email protected]>","sha":"72c0b81994d28f3983c2d21d662bd025653054fa"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196275","number":196275,"mergeCommit":{"message":"[Dashboard]
show fullscreen mode when url has fullScreenMode param (#196275)\n\n##
Summary\r\n\r\nCloses #174561\r\n\r\nShow fullscreen mode when url has
fullScreenMode param\r\n`&_a=(fullScreenMode:!t)`\r\n\r\n###
Screenshot\r\n\r\n\r\n![20241015-184503](https://github.com/user-attachments/assets/fae01dcc-f081-4314-84f9-3923adc76e5b)\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>\r\nCo-authored-by: Hannah
Mudge
<[email protected]>","sha":"72c0b81994d28f3983c2d21d662bd025653054fa"}}]}]
BACKPORT-->

Co-authored-by: Henry Liu <[email protected]>
kibanamachine added a commit that referenced this issue Oct 24, 2024
@kibanamachine @lsq645599166
[8.x] [Dashboard] show fullscreen mode when url has fullScreenMode pa…
97de35b 
…ram (#196275) (#197729)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Dashboard] show fullscreen mode when url has fullScreenMode param
(#196275)](#196275)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Henry
Liu","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-24T20:49:39Z","message":"[Dashboard]
show fullscreen mode when url has fullScreenMode param (#196275)\n\n##
Summary\r\n\r\nCloses #174561\r\n\r\nShow fullscreen mode when url has
fullScreenMode param\r\n`&_a=(fullScreenMode:!t)`\r\n\r\n###
Screenshot\r\n\r\n\r\n![20241015-184503](https://github.com/user-attachments/assets/fae01dcc-f081-4314-84f9-3923adc76e5b)\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>\r\nCo-authored-by: Hannah
Mudge
<[email protected]>","sha":"72c0b81994d28f3983c2d21d662bd025653054fa","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Presentation","loe:small","impact:medium","💝community","v9.0.0","backport:prev-major"],"title":"[Dashboard]
show fullscreen mode when url has fullScreenMode
param","number":196275,"url":"https://github.com/elastic/kibana/pull/196275","mergeCommit":{"message":"[Dashboard]
show fullscreen mode when url has fullScreenMode param (#196275)\n\n##
Summary\r\n\r\nCloses #174561\r\n\r\nShow fullscreen mode when url has
fullScreenMode param\r\n`&_a=(fullScreenMode:!t)`\r\n\r\n###
Screenshot\r\n\r\n\r\n![20241015-184503](https://github.com/user-attachments/assets/fae01dcc-f081-4314-84f9-3923adc76e5b)\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>\r\nCo-authored-by: Hannah
Mudge
<[email protected]>","sha":"72c0b81994d28f3983c2d21d662bd025653054fa"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196275","number":196275,"mergeCommit":{"message":"[Dashboard]
show fullscreen mode when url has fullScreenMode param (#196275)\n\n##
Summary\r\n\r\nCloses #174561\r\n\r\nShow fullscreen mode when url has
fullScreenMode param\r\n`&_a=(fullScreenMode:!t)`\r\n\r\n###
Screenshot\r\n\r\n\r\n![20241015-184503](https://github.com/user-attachments/assets/fae01dcc-f081-4314-84f9-3923adc76e5b)\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>\r\nCo-authored-by: Hannah
Mudge
<[email protected]>","sha":"72c0b81994d28f3983c2d21d662bd025653054fa"}}]}]
BACKPORT-->

Co-authored-by: Henry Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort regression Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Dashboard] show fullscreen mode when url has fullScreenMode param lsq645599166/kibana
5 participants
@jughosta @Heenawter @ThomThomson @elasticmachine @cbake886