[SLO] Burn rate rule - Burn rate rate keyboard controls seem broken #172400
Assignees
Labels
bug
Fixes for quality problems that affect the customer experience
Team:obs-ux-management
Observability Management User Experience Team
v8.12.0
Comments
dominiqueclarke
added
bug
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
dominiqueclarke
added a commit
that referenced
this issue
Dec 11, 2023
…urn rate threshold (#172526) ## Summary Resolves #172400 Adjusts the burn rate rule budget consumed and burn rate threshold text box to format only on blur. Removes the dependency on numeral in favor of using `toFixed`. ### Testing In order to test, you'll need to create a SLO burn rate rule. If you currently have SLOs set up, you can either do so by going to the observability rules management page and selecting the SLO burn rate rule. If you do not have SLOs set up, you can go to the SLO page, create an SLI and make sure the `create burn rate rule` checkbox is checked. The rule creation flyout will then appear. In the burn rate windows, ensure that you are able to change the burn rate threshold or budget consumed easily. When the field is blurred, the value should be formatted. Co-authored-by: Shahzad <[email protected]>
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Dec 11, 2023
…urn rate threshold (elastic#172526) ## Summary Resolves elastic#172400 Adjusts the burn rate rule budget consumed and burn rate threshold text box to format only on blur. Removes the dependency on numeral in favor of using `toFixed`. ### Testing In order to test, you'll need to create a SLO burn rate rule. If you currently have SLOs set up, you can either do so by going to the observability rules management page and selecting the SLO burn rate rule. If you do not have SLOs set up, you can go to the SLO page, create an SLI and make sure the `create burn rate rule` checkbox is checked. The rule creation flyout will then appear. In the burn rate windows, ensure that you are able to change the burn rate threshold or budget consumed easily. When the field is blurred, the value should be formatted. Co-authored-by: Shahzad <[email protected]> (cherry picked from commit 134012b)
kibanamachine
referenced
this issue
Dec 11, 2023
…d and burn rate threshold (#172526) (#173067) # Backport This will backport the following commits from `main` to `8.12`: - [[SLO] adjust burn rate rule number selector for budget consumed and burn rate threshold (#172526)](#172526) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dominique Clarke","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-12-11T14:12:14Z","message":"[SLO] adjust burn rate rule number selector for budget consumed and burn rate threshold (#172526)\n\n## Summary\r\n\r\nResolves https://github.com/elastic/kibana/issues/172400\r\n\r\nAdjusts the burn rate rule budget consumed and burn rate threshold text\r\nbox to format only on blur.\r\n\r\nRemoves the dependency on numeral in favor of using `toFixed`.\r\n\r\n### Testing\r\n\r\nIn order to test, you'll need to create a SLO burn rate rule. \r\n\r\nIf you currently have SLOs set up, you can either do so by going to the\r\nobservability rules management page and selecting the SLO burn rate\r\nrule.\r\n\r\nIf you do not have SLOs set up, you can go to the SLO page, create an\r\nSLI and make sure the `create burn rate rule` checkbox is checked. The\r\nrule creation flyout will then appear.\r\n\r\nIn the burn rate windows, ensure that you are able to change the burn\r\nrate threshold or budget consumed easily. When the field is blurred, the\r\nvalue should be formatted.\r\n\r\nCo-authored-by: Shahzad <[email protected]>","sha":"134012be32c2ede76ba700a089bee7a2b2afe0cb","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Feature:SLO","v8.12.0","Team:obs-ux-management","v8.13.0"],"number":172526,"url":"https://github.com/elastic/kibana/pull/172526","mergeCommit":{"message":"[SLO] adjust burn rate rule number selector for budget consumed and burn rate threshold (#172526)\n\n## Summary\r\n\r\nResolves https://github.com/elastic/kibana/issues/172400\r\n\r\nAdjusts the burn rate rule budget consumed and burn rate threshold text\r\nbox to format only on blur.\r\n\r\nRemoves the dependency on numeral in favor of using `toFixed`.\r\n\r\n### Testing\r\n\r\nIn order to test, you'll need to create a SLO burn rate rule. \r\n\r\nIf you currently have SLOs set up, you can either do so by going to the\r\nobservability rules management page and selecting the SLO burn rate\r\nrule.\r\n\r\nIf you do not have SLOs set up, you can go to the SLO page, create an\r\nSLI and make sure the `create burn rate rule` checkbox is checked. The\r\nrule creation flyout will then appear.\r\n\r\nIn the burn rate windows, ensure that you are able to change the burn\r\nrate threshold or budget consumed easily. When the field is blurred, the\r\nvalue should be formatted.\r\n\r\nCo-authored-by: Shahzad <[email protected]>","sha":"134012be32c2ede76ba700a089bee7a2b2afe0cb"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/172526","number":172526,"mergeCommit":{"message":"[SLO] adjust burn rate rule number selector for budget consumed and burn rate threshold (#172526)\n\n## Summary\r\n\r\nResolves https://github.com/elastic/kibana/issues/172400\r\n\r\nAdjusts the burn rate rule budget consumed and burn rate threshold text\r\nbox to format only on blur.\r\n\r\nRemoves the dependency on numeral in favor of using `toFixed`.\r\n\r\n### Testing\r\n\r\nIn order to test, you'll need to create a SLO burn rate rule. \r\n\r\nIf you currently have SLOs set up, you can either do so by going to the\r\nobservability rules management page and selecting the SLO burn rate\r\nrule.\r\n\r\nIf you do not have SLOs set up, you can go to the SLO page, create an\r\nSLI and make sure the `create burn rate rule` checkbox is checked. The\r\nrule creation flyout will then appear.\r\n\r\nIn the burn rate windows, ensure that you are able to change the burn\r\nrate threshold or budget consumed easily. When the field is blurred, the\r\nvalue should be formatted.\r\n\r\nCo-authored-by: Shahzad <[email protected]>","sha":"134012be32c2ede76ba700a089bee7a2b2afe0cb"}}]}] BACKPORT--> Co-authored-by: Dominique Clarke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Kibana version: 8.12.0
Description of the problem including expected versus actual behavior:
When attempting to change the burn rate threshold on the burn rate threshold rules, I have an incredibly hard time doing so on keyboard. It's impossible to simply clear out a value using the delete/backspace key and to add a new one.
Edit.-.Test.for.rules.-.SLOs.-.Observability.-.Elastic.mp4
Steps to reproduce:
The text was updated successfully, but these errors were encountered: