Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SLO] Add document count to "Custom Metric" SLI #170905

Closed
simianhacker opened this issue Nov 8, 2023 · 2 comments · Fixed by #170913
Closed

[SLO] Add document count to "Custom Metric" SLI #170905

simianhacker opened this issue Nov 8, 2023 · 2 comments · Fixed by #170913
Assignees
@simianhacker
Labels
Feature:SLO Team:obs-ux-management Observability Management User Experience Team

Comments

@simianhacker
Copy link
Member

🍒 Summary

Users should be able to use doc_count in the custom metric SLI so they can use a combination of sum of field along with doc_count.
@simianhacker simianhacker added Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" Feature:SLO Team:obs-ux-management Observability Management User Experience Team labels Nov 8, 2023
@simianhacker simianhacker self-assigned this Nov 8, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@simianhacker simianhacker mentioned this issue Nov 8, 2023
Merged
@emma-raffenne emma-raffenne removed the Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" label Nov 9, 2023
simianhacker added a commit that referenced this issue Nov 9, 2023
@simianhacker
[SLO] Add support for document count to custom metric indicator (#170913
b9c08ba 
)

## 🍒 Summary

This PR fixes #170905 by adding the aggregation menu to the Custom
Metric indicator to allow the user to pick either `doc_count` or `sum`
for the aggregation.

<img width="1152" alt="image"
src="https://github.com/elastic/kibana/assets/41702/35aea8bd-d21c-4780-bad6-1efe5fc8902b">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simianhacker simianhacker

Labels
Feature:SLO Team:obs-ux-management Observability Management User Experience Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[SLO] Add support for document count to custom metric indicator simianhacker/kibana
3 participants
@simianhacker @elasticmachine @emma-raffenne