Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Log Explorer] Log Flyout header and table #169501

Closed
Tracked by #169498
tonyghiani opened this issue Oct 23, 2023 · 2 comments · Fixed by #169832
Closed
Tracked by #169498

[Log Explorer] Log Flyout header and table #169501

tonyghiani opened this issue Oct 23, 2023 · 2 comments · Fixed by #169832
Assignees
Labels
Feature:LogsExplorer Logs Explorer feature Team:obs-ux-logs Observability Logs User Experience Team

Comments

@tonyghiani
Copy link
Contributor

tonyghiani commented Oct 23, 2023

📓 Summary

We want to add a flyout heading section with the most relevant details of a log such as the level, timestamp and the log message.
Also, we want to keep in view the original tabbed content already present in vanilla Discover.

🎨 Design

header_table

✔️ Acceptance criteria

  • Should display a log.level badge. The badge should be coloured accordingly with the level (normalized to lowercase values for unique entries), a hypothetical colour mapping can be:
    • error ➡️ danger
    • warning ➡️ warning
    • info ➡️ primary
    • any other ➡️ default
  • Should display a timestamp badge in ISO 8601 date format.
  • Should display the log message field. This one...
    • should be limited to 100px height to prevent taking to much space, with the option to scroll the content and expand it in fullscreen mode.
    • should be copyable.
  • Should display the original flyout content at the end of the page, which means including the tabbed content for Table and JSON sections.

💡 Implementation hints

@tonyghiani tonyghiani added Feature:Logs UI Logs UI feature Team:obs-ux-logs Observability Logs User Experience Team labels Oct 23, 2023
@ruflin
Copy link
Contributor

ruflin commented Oct 25, 2023

Should display the log message field. This one...

We need to discuss in more detail on what happens if message is empty. @weltenwort is thinking more about this.

@tonyghiani
Copy link
Contributor Author

We need to discuss in more detail on what happens if message is empty.

Totally, we already had a sync yesterday about this and we'll probably talk more about this.
Meanwhile, we'll proceed with this implementation as planned to not block the other flyout tasks.

@tonyghiani tonyghiani self-assigned this Oct 25, 2023
@tonyghiani tonyghiani added Feature:LogsExplorer Logs Explorer feature and removed Feature:Logs UI Logs UI feature labels Oct 31, 2023
tonyghiani added a commit that referenced this issue Nov 3, 2023
## 📓 Summary

Closes #169501 

🛑 ~**Merge blocked by:** #169634

This work implements the first frame for a detailed log flyout.
It adds highlight on the log level, timestamp and message details for a
log.
This first layer of customization will work as a base for all the
upcoming enhancements on the flyout detail.


https://github.com/elastic/kibana/assets/34506779/a1c2997c-5fef-4899-836f-ff810de3f148

---------

Co-authored-by: Marco Antonio Ghiani <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Achyut Jhunjhunwala <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:LogsExplorer Logs Explorer feature Team:obs-ux-logs Observability Logs User Experience Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants