Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution]Custom Fields not drag gable #169348

Closed
ghost opened this issue Oct 19, 2023 · 10 comments
Closed

[Security Solution]Custom Fields not drag gable #169348

ghost opened this issue Oct 19, 2023 · 10 comments
Assignees
@cnasikas
Labels
enhancement New value added to drive a business result Feature:Cases Cases feature impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. triage_needed

Comments

@ghost
Copy link

ghost commented Oct 19, 2023

Describe the bug:
Custom Fields not drag gable

Kibana/Elasticsearch Stack version
Version: 8.11.0 BC3
Commit: 714189f
Build: 67923

Browser and Browser OS Version:
Firefox for windows OS
Version: 118.0.1

Elastic Endpoint Version:
8.11

Original install method:
None

Functional Area:
Cases

Initial Setup:

  • None

Steps to reproduce

  • Go to Cases
  • Click on Setting
  • Create some custom field at least 3
  • Observed that user is not able to drag the field order

Additional Result

  • We have observed that user is able to create 2 field with same name so please check that also if that is intended behavior

image

Current Result

  • Custom Fields not drag gable

Expected behavior:

  • Custom Fields should be drag gable

image

Screen-Shot:

image
@ghost ghost added bug Fixes for quality problems that affect the customer experience triage_needed Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Oct 19, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@ghost ghost added the impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. label Oct 19, 2023
@ghost ghost assigned MadameSheema Oct 19, 2023
@MadameSheema MadameSheema added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Cases Cases feature labels Oct 19, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

@cnasikas
Copy link
Member

Thanks for the feedback @karanbirsingh-qasource! This is intended. We plan to support dragging in future releases. Maybe we can remove the icon on the left to avoid confusion. Wdyt?

@ghost
Copy link
Author

ghost commented Oct 19, 2023

agreed @cnasikas that will be good

@ghost
Copy link
Author

ghost commented Oct 19, 2023

one more observation we have added that is user is able to create 2 field with same name so could you please check that also if that is intended behavior.

@cnasikas
Copy link
Member

This is also an intended behavior.

@ghost
Copy link
Author

ghost commented Oct 19, 2023

ok thanks @cnasikas 👍

@cnasikas cnasikas added enhancement New value added to drive a business result impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. and removed bug Fixes for quality problems that affect the customer experience impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Oct 19, 2023
@ghost
Copy link
Author

ghost commented Oct 19, 2023

closed as completed ✔️

@ghost ghost closed this as completed Oct 19, 2023
@js-jankisalvi js-jankisalvi mentioned this issue Oct 24, 2023
Merged
@cnasikas
Copy link
Member

@karanbirsingh-qasource The drag and drop icon got removed in #169676

js-jankisalvi added a commit that referenced this issue Oct 25, 2023
@js-jankisalvi @kibanamachine
[Cases] remove grab icon from custom field list (#169676)
9816126 
## Summary

Removing drag icon as discussed in
#169348


![image](https://github.com/elastic/kibana/assets/117571355/a496473f-5969-4ea0-95fb-e37b055a8124)

---------

Co-authored-by: kibanamachine <[email protected]>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 25, 2023
@js-jankisalvi
[Cases] remove grab icon from custom field list (elastic#169676)
0327d17 
## Summary

Removing drag icon as discussed in
elastic#169348

![image](https://github.com/elastic/kibana/assets/117571355/a496473f-5969-4ea0-95fb-e37b055a8124)

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 9816126)
kibanamachine added a commit that referenced this issue Oct 25, 2023
@kibanamachine @js-jankisalvi
[8.11] [Cases] remove grab icon from custom field list (#169676) (#16…
a583ef9 
…9752)

# Backport

This will backport the following commits from `main` to `8.11`:
- [[Cases] remove grab icon from custom field list
(#169676)](#169676)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Janki
Salvi","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-10-25T07:42:01Z","message":"[Cases]
remove grab icon from custom field list (#169676)\n\n##
Summary\r\n\r\nRemoving drag icon as discussed
in\r\nhttps://github.com//issues/169348\r\n\r\n\r\n![image](https://github.com/elastic/kibana/assets/117571355/a496473f-5969-4ea0-95fb-e37b055a8124)\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"98161265887f6a72f2a147003c107fd6a4f42adf","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:ResponseOps","Feature:Cases","v8.11.0","v8.12.0"],"number":169676,"url":"https://github.com/elastic/kibana/pull/169676","mergeCommit":{"message":"[Cases]
remove grab icon from custom field list (#169676)\n\n##
Summary\r\n\r\nRemoving drag icon as discussed
in\r\nhttps://github.com//issues/169348\r\n\r\n\r\n![image](https://github.com/elastic/kibana/assets/117571355/a496473f-5969-4ea0-95fb-e37b055a8124)\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"98161265887f6a72f2a147003c107fd6a4f42adf"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/169676","number":169676,"mergeCommit":{"message":"[Cases]
remove grab icon from custom field list (#169676)\n\n##
Summary\r\n\r\nRemoving drag icon as discussed
in\r\nhttps://github.com//issues/169348\r\n\r\n\r\n![image](https://github.com/elastic/kibana/assets/117571355/a496473f-5969-4ea0-95fb-e37b055a8124)\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"98161265887f6a72f2a147003c107fd6a4f42adf"}}]}]
BACKPORT-->

Co-authored-by: Janki Salvi <[email protected]>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cnasikas cnasikas

Labels
enhancement New value added to drive a business result Feature:Cases Cases feature impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. triage_needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cnasikas @elasticmachine @MadameSheema