Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit visualization panel on dashboard is not displaying the error for the missing field #169175

Closed
bhavyarm opened this issue Oct 17, 2023 · 5 comments · Fixed by #172791
Closed

Edit visualization panel on dashboard is not displaying the error for the missing field #169175

bhavyarm opened this issue Oct 17, 2023 · 5 comments · Fixed by #172791
Assignees
@mbondyra
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@bhavyarm
Copy link
Contributor

Kibana version: 8.11.0 BC3

Browser version: chrome latest

Original install method (e.g. download page, yum, from source, etc.): From staging

Describe the bug: I upgraded from 7.17.4 to 8.11.0 BC3 and I have a panel which has a missing field. If you click on edit in versions older than 8.11.0 - you would be in lens and Kibana would display the error but now in 8.11.0 the edit visualization panel which opens up on dashboard doesn't show any indication of the error. Error gets displayed if you click on edit in lens with x in red visual indication.

No error for the missing field on viz panel:
Screenshot 2023-10-17 at 4 49 20 PM

Error is displayed in lens app:
Screenshot 2023-10-17 at 4 49 58 PM
@bhavyarm bhavyarm added bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Oct 17, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@kibanamachine kibanamachine added loe:needs-research This issue requires some research before it can be worked on or estimated impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Oct 17, 2023
@stratoula stratoula added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. and removed impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Oct 18, 2023
@stratoula
Copy link
Contributor

@drewdaemon any idea why this doesn't work in inline editing? I had tested erroring in general and was displayed correctly but maybe this has a different implementation?

@drewdaemon
Copy link
Contributor

I'm surprised to see this behavior differ. I see that it is working in the embeddable context, but not in the config panel on dashboard.

The call stack to look at is

  1. datasource.getUserMessages
  2. getLayerErrorMessages
  3. getErrorMessages
  4. operation.getErrorMessage (in this case, the terms operation)
  5. getInvalidFieldMessage
  6. missing field detection logic
  7. generateMissingFieldMessage

Let me know if you'd like me to take a closer look!

@stratoula
Copy link
Contributor

Thanx, let's go back on it during the 8.12 fixing it week.

@stratoula
Copy link
Contributor

getUserMessages is missing from the flyout, this is why it is happening. @mbondyra had fixed it in her PR #168948 ❤️

@mbondyra mbondyra self-assigned this Dec 6, 2023
@mbondyra mbondyra mentioned this issue Dec 7, 2023
Merged
mbondyra added a commit that referenced this issue Dec 7, 2023
@mbondyra
[Lens] Pass user messages to the config panel (#172791)
8f7a12c 
## Summary

Fixes #169175
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Dec 7, 2023
@mbondyra
[Lens] Pass user messages to the config panel (elastic#172791)
31e9b42 
## Summary

Fixes elastic#169175

(cherry picked from commit 8f7a12c)
kibanamachine referenced this issue Dec 7, 2023
@kibanamachine @mbondyra
[8.12] [Lens] Pass user messages to the config panel (#172791) (#172811)
7837193 
# Backport

This will backport the following commits from `main` to `8.12`:
- [[Lens] Pass user messages to the config panel
(#172791)](#172791)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Marta
Bondyra","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-12-07T13:10:27Z","message":"[Lens]
Pass user messages to the config panel (#172791)\n\n##
Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/169175","sha":"8f7a12cc42b4c0d2e14fc8084e2ab0c479d0aa9f","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Visualizations","release_note:skip","Feature:Lens","backport:prev-minor","v8.12.0","v8.13.0"],"number":172791,"url":"https://github.com/elastic/kibana/pull/172791","mergeCommit":{"message":"[Lens]
Pass user messages to the config panel (#172791)\n\n##
Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/169175","sha":"8f7a12cc42b4c0d2e14fc8084e2ab0c479d0aa9f"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/172791","number":172791,"mergeCommit":{"message":"[Lens]
Pass user messages to the config panel (#172791)\n\n##
Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/169175","sha":"8f7a12cc42b4c0d2e14fc8084e2ab0c479d0aa9f"}}]}]
BACKPORT-->

Co-authored-by: Marta Bondyra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbondyra mbondyra

Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Lens] Pass user messages to the config panel mbondyra/kibana
6 participants
@drewdaemon @mbondyra @bhavyarm @elasticmachine @stratoula @kibanamachine