Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node 18.18.2 is not notarized on MacOS #169170

Closed
bhavyarm opened this issue Oct 17, 2023 · 7 comments
Closed

Node 18.18.2 is not notarized on MacOS #169170

bhavyarm opened this issue Oct 17, 2023 · 7 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Team:Docs Team:Operations Team label for Operations Team

Comments

@bhavyarm
Copy link
Contributor

bhavyarm commented Oct 17, 2023

Kibana version: 8.11.0 BC3

Elasticsearch version: 8.11.0 BC3

Server OS version: darwin_aarch

Mac OS version: 13.6 (22G120)

Describe the bug: Node is not notarized for BC3 of 8.11.0. Please note it was notarized for BC1.
Screenshot 2023-10-17 at 4 18 52 PM

@bhavyarm bhavyarm added bug Fixes for quality problems that affect the customer experience Team:Operations Team label for Operations Team labels Oct 17, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@mistic
Copy link
Member

mistic commented Oct 17, 2023

Probably related with nodejs/build#3385

@mistic
Copy link
Member

mistic commented Oct 23, 2023

@bhavyarm this is now confirmed to be a problem on the Node.js notarization side and not on ours. Developments could be followed at nodejs/build#3538

@bhavyarm
Copy link
Contributor Author

awesome thanks @mistic

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@jrodewig
Copy link
Contributor

👋 Hello! Based on the Team:Docs label, it seems like this issue may need some docs help. If so, can someone please explain what we should do? Thanks!

@jbudz
Copy link
Member

jbudz commented Oct 27, 2023

^ Sorry :) you beat me to the writeup.

lukeelmers suggested (and I'm +1) we should include a release note mentioning this regression if it's not fixed upstream in time for the next release.

The blocker flag is to make sure this is revisited - either with a notarized node.js update, or a release note. I can take lead on folowing up.

@jbudz jbudz self-assigned this Oct 27, 2023
@jbudz jbudz changed the title Node is not notarized for BC3 of 8.11.0 Node 18.18.2 is not notarized on MacOS Oct 27, 2023
jbudz added a commit that referenced this issue Nov 6, 2023
Adds a known issue for #169170

---------

Co-authored-by: James Rodewig <[email protected]>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Nov 6, 2023
Adds a known issue for elastic#169170

---------

Co-authored-by: James Rodewig <[email protected]>
(cherry picked from commit 02758c5)
kibanamachine added a commit that referenced this issue Nov 6, 2023
# Backport

This will backport the following commits from `main` to `8.11`:
- [[docs] Add gatekeeper error as known issue
(#170668)](#170668)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Jon","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-11-06T21:17:12Z","message":"[docs]
Add gatekeeper error as known issue (#170668)\n\nAdds a known issue for
#169170\r\n\r\n---------\r\n\r\nCo-authored-by: James Rodewig
<[email protected]>","sha":"02758c5bfbfd72ed1be45cd8b321a2efa6abc2b7","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Docs","Team:Operations","release_note:skip","backport:prev-minor","v8.12.0"],"number":170668,"url":"https://github.com/elastic/kibana/pull/170668","mergeCommit":{"message":"[docs]
Add gatekeeper error as known issue (#170668)\n\nAdds a known issue for
#169170\r\n\r\n---------\r\n\r\nCo-authored-by: James Rodewig
<[email protected]>","sha":"02758c5bfbfd72ed1be45cd8b321a2efa6abc2b7"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/170668","number":170668,"mergeCommit":{"message":"[docs]
Add gatekeeper error as known issue (#170668)\n\nAdds a known issue for
#169170\r\n\r\n---------\r\n\r\nCo-authored-by: James Rodewig
<[email protected]>","sha":"02758c5bfbfd72ed1be45cd8b321a2efa6abc2b7"}}]}]
BACKPORT-->

Co-authored-by: Jon <[email protected]>
@jbudz jbudz removed the v8.11.0 label Nov 6, 2023
@jbudz jbudz closed this as completed Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Team:Docs Team:Operations Team label for Operations Team
Projects
None yet
Development

No branches or pull requests

5 participants