Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cloud Security] [Findings++ Phase 2] [Vulnerabilities] Custom renderer for Group by cloud accounts #169052

Closed
4 tasks
opauloh opened this issue Oct 17, 2023 · 2 comments · Fixed by #174950
Closed
4 tasks

[Cloud Security] [Findings++ Phase 2] [Vulnerabilities] Custom renderer for Group by cloud accounts #169052

opauloh opened this issue Oct 17, 2023 · 2 comments · Fixed by #174950
Assignees
@opauloh
Labels
8.13 candidate Feature:Cloud-Security Cloud Security related features Team:Cloud Security Cloud Security team related

Comments

@opauloh
Copy link
Contributor

opauloh commented Oct 17, 2023

Motivation

When grouping by Resource, the group component shows a title on the left with badges with counters in the grouped row

Definition of done

  • Custom rendering for Group by Resource, based on the Mock provided
  • In the Grouping by resource view there is a horizontal bar chart with the severity mapping for each group.
  • It should show the Cloud Provider Icon on the left of the Grouped View.
  • The icon should match the Icons shown on the CSPM integration install screen

Out of scope

  • Custom rendering for other group views

Team tag

@elastic/kibana-cloud-security-posture

Image
@opauloh opauloh added Team:Cloud Security Cloud Security team related 8.12 candidate labels Oct 17, 2023
@kfirpeled kfirpeled added the Feature:Cloud-Security Cloud Security related features label Nov 5, 2023
@opauloh opauloh mentioned this issue Jan 16, 2024
Merged
opauloh added a commit that referenced this issue Jan 25, 2024
@opauloh
[Cloud Security] [Vulnerabilities] Custom renderers for Group by Reso…
2a27b83 
…urce, Cloud account and CVE (#174950)

## Summary

It closes #169052, #169048 and
[#172197](#172197)

This PR adds the following changes to the Findings -> Vulnerabilities
page:

- Added Severity mapping component to all Vulnerabilities grouping
- Added Cloud account grouping to the Vulnerabilities default groups
(groups by `cloud.account.name`)
- Added CVE grouping to the Vulnerabilities default groups (groups by
`vulnerability.id`)

It also introduced the following changes:

- Added utility to retrieve cloud providers names from a cloud provider
abbreviation (aws, azure, gcp)
- Added component to retrieve cloud provider icons from a cloud provider
abbreviation (aws, azure, gcp)
- Fixed Benchmarks page was displaying `Google Cloud Provider` for GCP
instead of `Google Cloud Platform`.
- Added / Updated FTR tests for vulnerability grouping

## Screenshots


![image](https://github.com/elastic/kibana/assets/19270322/cb79fc81-1b0d-4ce2-a456-af270390b1c9)


<img width="1498" alt="image"
src="https://github.com/elastic/kibana/assets/19270322/245d6c06-67bd-429b-963f-ddc67cca5af4">


<img width="1509" alt="image"
src="https://github.com/elastic/kibana/assets/19270322/028be6e4-3543-4fd8-8bee-f23535aec7b8">

<img width="1501" alt="image"
src="https://github.com/elastic/kibana/assets/19270322/c691f8b8-fca5-4d65-a182-ca26448a7ede">

<img width="1502" alt="image"
src="https://github.com/elastic/kibana/assets/19270322/caa4fe29-a542-4e33-b609-be50d29f6e37">



## Recording



https://github.com/elastic/kibana/assets/19270322/2e8d2c9d-2e3c-459c-a9e5-29f046b9ed9e
@opauloh opauloh mentioned this issue Feb 2, 2024
Closed
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this issue Feb 15, 2024
@opauloh @CoenWarmer
[Cloud Security] [Vulnerabilities] Custom renderers for Group by Reso…
63b3c67 
…urce, Cloud account and CVE (elastic#174950)

## Summary

It closes elastic#169052, elastic#169048 and
[elastic#172197](elastic#172197)

This PR adds the following changes to the Findings -> Vulnerabilities
page:

- Added Severity mapping component to all Vulnerabilities grouping
- Added Cloud account grouping to the Vulnerabilities default groups
(groups by `cloud.account.name`)
- Added CVE grouping to the Vulnerabilities default groups (groups by
`vulnerability.id`)

It also introduced the following changes:

- Added utility to retrieve cloud providers names from a cloud provider
abbreviation (aws, azure, gcp)
- Added component to retrieve cloud provider icons from a cloud provider
abbreviation (aws, azure, gcp)
- Fixed Benchmarks page was displaying `Google Cloud Provider` for GCP
instead of `Google Cloud Platform`.
- Added / Updated FTR tests for vulnerability grouping

## Screenshots


![image](https://github.com/elastic/kibana/assets/19270322/cb79fc81-1b0d-4ce2-a456-af270390b1c9)


<img width="1498" alt="image"
src="https://github.com/elastic/kibana/assets/19270322/245d6c06-67bd-429b-963f-ddc67cca5af4">


<img width="1509" alt="image"
src="https://github.com/elastic/kibana/assets/19270322/028be6e4-3543-4fd8-8bee-f23535aec7b8">

<img width="1501" alt="image"
src="https://github.com/elastic/kibana/assets/19270322/c691f8b8-fca5-4d65-a182-ca26448a7ede">

<img width="1502" alt="image"
src="https://github.com/elastic/kibana/assets/19270322/caa4fe29-a542-4e33-b609-be50d29f6e37">



## Recording



https://github.com/elastic/kibana/assets/19270322/2e8d2c9d-2e3c-459c-a9e5-29f046b9ed9e
@romulets
Copy link
Member

✅ QA Verified

  • Custom rendering for Cloud Accounts
    image

@CohenIdo
Copy link
Contributor

CohenIdo commented Mar 12, 2024 •
edited
Loading

Serverless QA 8.13 BC4:
✅ verified
Kibana commit: 552e8adcca053bbe13cbc087eb7cd6cad473dbb2
Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@opauloh opauloh

Labels
8.13 candidate Feature:Cloud-Security Cloud Security related features Team:Cloud Security Cloud Security team related
Projects
None yet
Milestone
No milestone
4 participants
@romulets @opauloh @kfirpeled @CohenIdo