Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: Jest Tests.x-pack/plugins/cases/public/components/add_comment - AddComment should call onFocus when adding a quote #168507

Closed
kibanamachine opened this issue Oct 10, 2023 · 5 comments · Fixed by #170400 or #170394
Closed

Failing test: Jest Tests.x-pack/plugins/cases/public/components/add_comment - AddComment should call onFocus when adding a quote #168507

kibanamachine opened this issue Oct 10, 2023 · 5 comments · Fixed by #170400 or #170394
Assignees
@adcoelho
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Feature:Cases Cases feature Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 10, 2023 •
edited
Loading

A test failed on a tracked branch

TypeError: Cannot read properties of null (reading 'editor')
    at Object.editor (/var/lib/buildkite-agent/builds/kb-n2-4-spot-4fc618f967d526e5/elastic/kibana-on-merge/kibana/x-pack/plugins/cases/public/components/add_comment/index.test.tsx:153:18)
    at Promise.then.completed (/var/lib/buildkite-agent/builds/kb-n2-4-spot-4fc618f967d526e5/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/utils.js:300:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/var/lib/buildkite-agent/builds/kb-n2-4-spot-4fc618f967d526e5/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/utils.js:233:10)
    at _callCircusTest (/var/lib/buildkite-agent/builds/kb-n2-4-spot-4fc618f967d526e5/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/run.js:314:40)
    at _runTest (/var/lib/buildkite-agent/builds/kb-n2-4-spot-4fc618f967d526e5/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/run.js:250:3)
    at _runTestsForDescribeBlock (/var/lib/buildkite-agent/builds/kb-n2-4-spot-4fc618f967d526e5/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/run.js:125:9)
    at _runTestsForDescribeBlock (/var/lib/buildkite-agent/builds/kb-n2-4-spot-4fc618f967d526e5/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/run.js:120:9)
    at run (/var/lib/buildkite-agent/builds/kb-n2-4-spot-4fc618f967d526e5/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/run.js:70:3)
    at runAndTransformResultsToJestFormat (/var/lib/buildkite-agent/builds/kb-n2-4-spot-4fc618f967d526e5/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (/var/lib/buildkite-agent/builds/kb-n2-4-spot-4fc618f967d526e5/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (/var/lib/buildkite-agent/builds/kb-n2-4-spot-4fc618f967d526e5/elastic/kibana-on-merge/kibana/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (/var/lib/buildkite-agent/builds/kb-n2-4-spot-4fc618f967d526e5/elastic/kibana-on-merge/kibana/node_modules/jest-runner/build/runTest.js:444:34)

First failure: CI Build - 8.11
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Oct 10, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Oct 10, 2023
@kibanamachine kibanamachine added the Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) label Oct 10, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Oct 10, 2023
@cnasikas cnasikas added the Feature:Cases Cases feature label Oct 10, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

mistic added a commit that referenced this issue Oct 25, 2023
@mistic
skip flaky suite (#168507)
cb0bc97
mistic added a commit that referenced this issue Oct 25, 2023
@mistic
skip flaky suite (#168507)
767be2b
@mistic
Copy link
Member

mistic commented Oct 25, 2023

Skipped.

main: cb0bc97
8.11: 767be2b

@adcoelho adcoelho self-assigned this Nov 2, 2023
@adcoelho adcoelho mentioned this issue Nov 2, 2023
Merged
1 task
@jcger jcger mentioned this issue Nov 3, 2023
Merged
adcoelho added a commit that referenced this issue Nov 6, 2023
@adcoelho @kibanamachine
[Cases] Fix flaky "add comment" tests. (#170400)
96a4d5b 
Fixes #168505
Fixes #168506
Fixes #168507
Fixes #168508
Fixes #168509
(I hope)

## Summary

Covered most of the logic in e2e tests.

Flaky test runner:
-
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3869

## Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: kibanamachine <[email protected]>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Nov 6, 2023
@adcoelho
[Cases] Fix flaky "add comment" tests. (elastic#170400)
daeb2d7 
Fixes elastic#168505
Fixes elastic#168506
Fixes elastic#168507
Fixes elastic#168508
Fixes elastic#168509
(I hope)

## Summary

Covered most of the logic in e2e tests.

Flaky test runner:
-
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3869

## Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 96a4d5b)
kibanamachine added a commit that referenced this issue Nov 6, 2023
@kibanamachine @adcoelho
[8.11] [Cases] Fix flaky "add comment" tests. (#170400) (#170625)
1a65a4a 
# Backport

This will backport the following commits from `main` to `8.11`:
- [[Cases] Fix flaky "add comment" tests.
(#170400)](#170400)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Antonio","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-11-06T10:45:16Z","message":"[Cases]
Fix flaky \"add comment\" tests. (#170400)\n\nFixes #168505\r\nFixes
#168506\r\nFixes #168507\r\nFixes #168508\r\nFixes #168509\r\n(I
hope)\r\n\r\n## Summary\r\n\r\nCovered most of the logic in e2e
tests.\r\n\r\nFlaky test
runner:\r\n-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3869\r\n\r\n##
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"96a4d5b63fd2fedc94905729edf06e5df7cac2aa","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","Feature:Cases","v8.11.0","v8.12.0"],"number":170400,"url":"https://github.com/elastic/kibana/pull/170400","mergeCommit":{"message":"[Cases]
Fix flaky \"add comment\" tests. (#170400)\n\nFixes #168505\r\nFixes
#168506\r\nFixes #168507\r\nFixes #168508\r\nFixes #168509\r\n(I
hope)\r\n\r\n## Summary\r\n\r\nCovered most of the logic in e2e
tests.\r\n\r\nFlaky test
runner:\r\n-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3869\r\n\r\n##
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"96a4d5b63fd2fedc94905729edf06e5df7cac2aa"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/170400","number":170400,"mergeCommit":{"message":"[Cases]
Fix flaky \"add comment\" tests. (#170400)\n\nFixes #168505\r\nFixes
#168506\r\nFixes #168507\r\nFixes #168508\r\nFixes #168509\r\n(I
hope)\r\n\r\n## Summary\r\n\r\nCovered most of the logic in e2e
tests.\r\n\r\nFlaky test
runner:\r\n-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3869\r\n\r\n##
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"96a4d5b63fd2fedc94905729edf06e5df7cac2aa"}}]}]
BACKPORT-->

Co-authored-by: Antonio <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adcoelho adcoelho

Labels
failed-test A test failure on a tracked branch, potentially flaky-test Feature:Cases Cases feature Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Milestone
No milestone
5 participants
@adcoelho @mistic @cnasikas @elasticmachine @kibanamachine