Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: Serverless Observability Functional Tests.x-pack/test_serverless/functional/test_suites/observability/landing_page·ts - serverless observability UI landing page "after all" hook for "stream log files onboarding" #168037

Open
kibanamachine opened this issue Oct 4, 2023 · 4 comments
Open

Failing test: Serverless Observability Functional Tests.x-pack/test_serverless/functional/test_suites/observability/landing_page·ts - serverless observability UI landing page "after all" hook for "stream log files onboarding" #168037

kibanamachine opened this issue Oct 4, 2023 · 4 comments
Assignees
@kdelemme
Labels
blocker failed-test A test failure on a tracked branch, potentially flaky-test skipped-test Team:Observability Team label for Observability Team (for things that are handled across all of observability) v8.13.0

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 4, 2023 •
edited
Loading

A test failed on a tracked branch

Error: timed out waiting for Waiting for logout to complete
    at onFailure (retry_for_truthy.ts:39:13)
    at retryForSuccess (retry_for_success.ts:59:13)
    at retryForTruthy (retry_for_truthy.ts:27:3)
    at RetryService.waitFor (retry.ts:59:5)
    at SecurityPageObject.forceLogout (security_page.ts:319:7)
    at Object.forceLogout (svl_common_page.ts:95:7)
    at Context.<anonymous> (landing_page.ts:22:7)
    at Object.apply (wrap_function.js:73:16)

First failure: CI Build - main
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Oct 4, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Oct 4, 2023
@mistic mistic added the Team:Observability Team label for Observability Team (for things that are handled across all of observability) label Oct 4, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/unified-observability (Team:Observability)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Oct 4, 2023
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

mistic added a commit that referenced this issue Jan 29, 2024
@mistic
skip flaky suite (#168037)
597a8c9
@mistic
Copy link
Member

mistic commented Jan 29, 2024

Skipped.

main: 597a8c9

CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this issue Feb 15, 2024
@mistic @CoenWarmer
skip flaky suite (elastic#168037)
ebe6ea1
fkanout pushed a commit to fkanout/kibana that referenced this issue Mar 4, 2024
@mistic @fkanout
skip flaky suite (elastic#168037)
0a9de1f
@gergoabraham gergoabraham mentioned this issue May 24, 2024
Merged
gergoabraham added a commit to gergoabraham/kibana that referenced this issue May 24, 2024
@gergoabraham
enable landing_page tests (elastic#168037)
1d1efb6
gergoabraham added a commit to gergoabraham/kibana that referenced this issue May 24, 2024
@gergoabraham
Revert "enable landing_page tests (elastic#168037)"
c561d2b 
This reverts commit 1d1efb6.
gergoabraham added a commit that referenced this issue May 31, 2024
@gergoabraham @kibanamachine
[Serverless][Testing] Improve serverless force logout and enable some…
22c2a67 
… related tests (#184202)

## Summary

Looks like there are some tests being flaky because redirect after
`forceLogout` is not performed correctly on
`https://cloud.elastic.co/logout?redirectTo=%2Fprojects%2F`.
So far there has been tries to increase timeout to improve flakiness but
there are still random fails.

This PR tries to improve on this by simply adding a **retry** for the
force logout process, therefore the logout page will be reloaded, in
order to retrigger the redirect process.

There are some other cases when there was an error message in the
browser: `Failed to decode downloaded font:
https://cloud.elastic.co/449450163f45882ebfc2.woff`. This also looks
flakiness, so I'm hoping that the retry/reload mechanism helps with
those cases, too.

### For future flakiness
In case we still experience flakiness, maybe we can simply don't expect
the redirection to finish - i don't think we care about it: when we are
on this redirect page, we are already logged out.

The redirect is an external dependency from the perspective of these
tests - if [cloud.elastic.co](http://cloud.elastic.co/) cannot redirect,
it shouldn't really matter.

### Seemingly related tests

#### Skipped tests that are enabled in this PR
fixes #180401
fixes #184319

#### Failed but not yet skipped tests
closes #174975
closes #175159
closes #167818
closes #176413
closes #175612
closes #175785
closes #175606
closes #175599
closes #175083
closes #174439
closes #174346
closes #174566
closes #173192
closes #174111
closes #174116
closes #173950
closes #173074
closes #170899
closes #170890
closes #167597
closes #169818
closes #167585
closes #167792
closes #168751

#### Other
This test is related, and could be enabled, but since it's been skipped
for months, the business logic has changed, so the test needs to be
updated: #168037

> [!Note]
> If a test fails, the issue contains its error message. If it fails
again in the future with a different error, the same issue will be
reopened, although it's not the same error. And, I searched for the
error message amongst these issues, therefore:
> - I found test fail issues containing the same error message
originally, but recently being failed on a different reason: these are
of course not included in this list as the recent error reason is
something different
> - and probably I did not find test fails that originally failed with a
different reason, but now with this, which is unfortunate

---------

Co-authored-by: Kibana Machine <[email protected]>
@gergoabraham
Copy link
Contributor

hey there, the original flakiness that caused this test to be skipped was hopefully reduced in #184202

i tried to re-enable this test, but during the months it was being skipped, the behaviour must have changed, so now it fails definitely. in case you want to fix it, you can do now hopefully without worrying about the flakiness 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kdelemme kdelemme

Labels
blocker failed-test A test failure on a tracked branch, potentially flaky-test skipped-test Team:Observability Team label for Observability Team (for things that are handled across all of observability) v8.13.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kdelemme @mistic @elasticmachine @gergoabraham @kibanamachine