Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CM] Migrate visualization annotation graph to saved_object_content_storage #167421

Closed
3 tasks
Dosant opened this issue Sep 27, 2023 · 1 comment · Fixed by #168520
Closed
3 tasks

[CM] Migrate visualization annotation graph to saved_object_content_storage #167421

Dosant opened this issue Sep 27, 2023 · 1 comment · Fixed by #168520
Assignees
Labels
enhancement New value added to drive a business result impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@Dosant
Copy link
Contributor

Dosant commented Sep 27, 2023

As a follow up to #167152 #166919, we should migrate the remaining saved object based content types to use the common util https://github.com/elastic/kibana/blob/main/packages/kbn-content-management-utils/src/saved_object_content_storage.ts util

  • visualization
  • annotation
  • graph

This will soften the response validation for these #167152 as we did for other types. This should also help with any other future common changes for simple saved object based storages.

Alternatively, the response validation can be removed manually by replicating the same patten as the saved_object_content_storage.ts

cc @dej611

@Dosant Dosant added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Sep 27, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@stratoula stratoula added enhancement New value added to drive a business result impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Sep 27, 2023
Dosant added a commit that referenced this issue Sep 28, 2023
## Summary

Close #167152

Log a warning instead of throwing an error in
`saved_object_content_storage` when response validation failed.

We decided to do this as a precaution and as a follow up to an issue
found in saved search #166886
where storage started failing because of too strict validation.

As of this PR the saved_object_content_storage covers and this change
cover:

- `search`
- `index_pattern`
- `dashboard`
- `lens`
- `maps`

For other types we agreed with @dej611 that instead of applying the same
change for other types (visualization, graph, annotation) the team would
look into migrating their types to also use
`saved_object_content_storage`
#167421
@drewdaemon drewdaemon self-assigned this Oct 10, 2023
drewdaemon added a commit that referenced this issue Oct 14, 2023
…ent_storage` (#168520)

## Summary

Close #167421

---------

Co-authored-by: kibanamachine <[email protected]>
dej611 pushed a commit to dej611/kibana that referenced this issue Oct 17, 2023
…ent_storage` (elastic#168520)

## Summary

Close elastic#167421

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants