-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Disable android source map API and remove docs #165393
Labels
Comments
Pinging @elastic/apm-ui (Team:APM) |
sorenlouv
added
apm:mobile
8.11 candidate
8.10 candidate
and removed
8.11 candidate
labels
Aug 31, 2023
1 task
gbamparop
pushed a commit
that referenced
this issue
Sep 4, 2023
## Summary Closes #165393 ### Checklist ### Risk Matrix ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Sep 4, 2023
## Summary Closes elastic#165393 ### Checklist ### Risk Matrix ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit 0e98280)
kibanamachine
referenced
this issue
Sep 4, 2023
…165603) # Backport This will backport the following commits from `main` to `8.10`: - [Reverting android upload map file endpoint changes (#165449)](#165449) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"LikeTheSalad","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-09-04T14:07:04Z","message":"Reverting android upload map file endpoint changes (#165449)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/165393\r\n\r\n\r\n### Checklist\r\n\r\n### Risk Matrix\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"0e982807e087edec6053107e6b326251ce9a48d3","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:APM","release_note:skip","v8.10.0","v8.11.0"],"number":165449,"url":"https://github.com/elastic/kibana/pull/165449","mergeCommit":{"message":"Reverting android upload map file endpoint changes (#165449)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/165393\r\n\r\n\r\n### Checklist\r\n\r\n### Risk Matrix\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"0e982807e087edec6053107e6b326251ce9a48d3"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/165449","number":165449,"mergeCommit":{"message":"Reverting android upload map file endpoint changes (#165449)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/165393\r\n\r\n\r\n### Checklist\r\n\r\n### Risk Matrix\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"0e982807e087edec6053107e6b326251ce9a48d3"}}]}] BACKPORT--> Co-authored-by: LikeTheSalad <[email protected]>
bmorelli25
pushed a commit
to bmorelli25/observability-docs
that referenced
this issue
Apr 3, 2024
## Summary Closes elastic/kibana#165393 ### Checklist ### Risk Matrix ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
dedemorton
pushed a commit
to dedemorton/observability-docs
that referenced
this issue
Aug 6, 2024
## Summary Closes elastic/kibana#165393 ### Checklist ### Risk Matrix ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The ability to upload android source maps was added in #161252, so stack traces in errors would show up correctly. However, due to the complexity around deobfuscating stack traces it is not yet known when we'll start consuming the source maps. We should therefore remove the ability to upload source maps for Android, and remove any public documentation around the android source map APIs (
/api/apm/androidmaps
).We can either remove the APIs entirely, or leave the implementation in, and simply return
Android source map documentation: https://www.elastic.co/guide/en/kibana/master/android-sourcemap-api.html.
The text was updated successfully, but these errors were encountered: