Infra UI : When creating an alert for a host via the new host fly-out, the filter cannot be updated #165098
Assignees
Labels
bug
Fixes for quality problems that affect the customer experience
Feature:Metrics UI
Metrics UI feature
Team:Infra Monitoring UI - DEPRECATED
DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Comments
roshan-elastic
added
bug
|
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
|
@smith any chance we can attempt a back-port on this if we can get it done before 8.10 goes out? |
Yes. |
|
Hey @roshan-elastic, I added a fix (PR) but this was actually part of the @elastic/actionable-observability component (I figured that out after I opened the PR so decided to keep the fix PR) |
jennypavlova
added a commit
that referenced
this issue
Sep 8, 2023
… the filter cannot be updated (#165991) Closes #165098 ## Summary This PR fixes an issue with the optional filter component (the user is not able to clear the prefilled input - described in [the issue](#165098 (comment))) - [commit](57b43b6). I saw deprecated styled components used in the component I was adding the fix so I also fixed those - in case there is a valid reason to keep the old version I can remove the [second commit](351d997). ## Testing Open create alert rule flyout from the Inventory page - Create a rule without the optional filter - Create a rule with a new optional filter Open create alert rule flyout from the Hosts view page - Create a rule without the optional filter - Create a rule with a new optional filter https://github.com/elastic/kibana/assets/14139027/8e9fb3f6-4774-4e06-9f49-16b83a60b7b6
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Sep 8, 2023
… the filter cannot be updated (elastic#165991) Closes elastic#165098 ## Summary This PR fixes an issue with the optional filter component (the user is not able to clear the prefilled input - described in [the issue](elastic#165098 (comment))) - [commit](elastic@57b43b6). I saw deprecated styled components used in the component I was adding the fix so I also fixed those - in case there is a valid reason to keep the old version I can remove the [second commit](elastic@351d997). ## Testing Open create alert rule flyout from the Inventory page - Create a rule without the optional filter - Create a rule with a new optional filter Open create alert rule flyout from the Hosts view page - Create a rule without the optional filter - Create a rule with a new optional filter https://github.com/elastic/kibana/assets/14139027/8e9fb3f6-4774-4e06-9f49-16b83a60b7b6 (cherry picked from commit 227a037)
@roshan-elastic fixed and backported to 8.10 🎉 |
kibanamachine
added a commit
that referenced
this issue
Sep 8, 2023
…fly out the filter cannot be updated (#165991) (#166055) # Backport This will backport the following commits from `main` to `8.10`: - [[Infra UI] When creating an alert for a host via the new host fly out the filter cannot be updated (#165991)](#165991) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"jennypavlova","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-09-08T09:17:06Z","message":"[Infra UI] When creating an alert for a host via the new host fly out the filter cannot be updated (#165991)\n\nCloses #165098\r\n\r\n## Summary\r\n\r\nThis PR fixes an issue with the optional filter component (the user is\r\nnot able to clear the prefilled input - described in [the\r\nissue](https://github.com/elastic/kibana/issues/165098#issue-1871701462))\r\n-\r\n[commit](https://github.com/elastic/kibana/commit/57b43b6ef9ea7733cbe24d44416d033529ed98ef).\r\nI saw deprecated styled components used in the component I was adding\r\nthe fix so I also fixed those - in case there is a valid reason to keep\r\nthe old version I can remove the [second\r\ncommit](https://github.com/elastic/kibana/commit/351d997cb62390c18a8b04b312c8bdd238159db1).\r\n\r\n## Testing \r\n\r\nOpen create alert rule flyout from the Inventory page\r\n- Create a rule without the optional filter\r\n- Create a rule with a new optional filter\r\n\r\nOpen create alert rule flyout from the Hosts view page\r\n- Create a rule without the optional filter\r\n- Create a rule with a new optional filter\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/14139027/8e9fb3f6-4774-4e06-9f49-16b83a60b7b6","sha":"227a037ceb80d27e09078144bfc5a492581397e5","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Infra Monitoring UI","release_note:skip","backport:prev-minor","v8.11.0"],"number":165991,"url":"https://github.com/elastic/kibana/pull/165991","mergeCommit":{"message":"[Infra UI] When creating an alert for a host via the new host fly out the filter cannot be updated (#165991)\n\nCloses #165098\r\n\r\n## Summary\r\n\r\nThis PR fixes an issue with the optional filter component (the user is\r\nnot able to clear the prefilled input - described in [the\r\nissue](https://github.com/elastic/kibana/issues/165098#issue-1871701462))\r\n-\r\n[commit](https://github.com/elastic/kibana/commit/57b43b6ef9ea7733cbe24d44416d033529ed98ef).\r\nI saw deprecated styled components used in the component I was adding\r\nthe fix so I also fixed those - in case there is a valid reason to keep\r\nthe old version I can remove the [second\r\ncommit](https://github.com/elastic/kibana/commit/351d997cb62390c18a8b04b312c8bdd238159db1).\r\n\r\n## Testing \r\n\r\nOpen create alert rule flyout from the Inventory page\r\n- Create a rule without the optional filter\r\n- Create a rule with a new optional filter\r\n\r\nOpen create alert rule flyout from the Hosts view page\r\n- Create a rule without the optional filter\r\n- Create a rule with a new optional filter\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/14139027/8e9fb3f6-4774-4e06-9f49-16b83a60b7b6","sha":"227a037ceb80d27e09078144bfc5a492581397e5"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/165991","number":165991,"mergeCommit":{"message":"[Infra UI] When creating an alert for a host via the new host fly out the filter cannot be updated (#165991)\n\nCloses #165098\r\n\r\n## Summary\r\n\r\nThis PR fixes an issue with the optional filter component (the user is\r\nnot able to clear the prefilled input - described in [the\r\nissue](https://github.com/elastic/kibana/issues/165098#issue-1871701462))\r\n-\r\n[commit](https://github.com/elastic/kibana/commit/57b43b6ef9ea7733cbe24d44416d033529ed98ef).\r\nI saw deprecated styled components used in the component I was adding\r\nthe fix so I also fixed those - in case there is a valid reason to keep\r\nthe old version I can remove the [second\r\ncommit](https://github.com/elastic/kibana/commit/351d997cb62390c18a8b04b312c8bdd238159db1).\r\n\r\n## Testing \r\n\r\nOpen create alert rule flyout from the Inventory page\r\n- Create a rule without the optional filter\r\n- Create a rule with a new optional filter\r\n\r\nOpen create alert rule flyout from the Hosts view page\r\n- Create a rule without the optional filter\r\n- Create a rule with a new optional filter\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/14139027/8e9fb3f6-4774-4e06-9f49-16b83a60b7b6","sha":"227a037ceb80d27e09078144bfc5a492581397e5"}}]}] BACKPORT--> Co-authored-by: jennypavlova <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected Behaviour
When you create an inventory rule for a host, you should be able to clear the pre-populated filter.
Current Behaviour
It re-populates the filter as you delete it:
Bug
It should allow you to delete the filter and save it (i.e. to allow you to apply the new rule to all hosts).
The text was updated successfully, but these errors were encountered: