[Security Solution][Browser Issue]Incorrect Elastic AI Assistant icon on Rule Page #164819
Assignees
Labels
bug
Fixes for quality problems that affect the customer experience
fixed
impact:low
Addressing this issue will have a low level of impact on the quality/strength of our product.
QA:Validated
Issue has been validated by QA
Team: SecuritySolution
Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
v8.10.0
Comments
ghost
added
bug
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
ghost
added
the
impact:low
|
@amolnater-qasource please review |
|
Reviewed & assigned to @MadameSheema |
|
@jamesspi can you please take a look at this issue? Thanks! :) |
|
@spong, can you take a look? |
|
I will replace with the EUI Maybe the same |
|
I agree with having the same chat CTA here. |
2 tasks
2 tasks
2 tasks
|
Fixed in #164900, went with the common CTA and removed the header 🪄 ✨ link. It now shows as a
Reopening and marking as |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Aug 28, 2023
…ssistant (elastic#164900) ## Summary Fixes Preconfigured Connectors not working with the Assistant, and also ensures default `model` from connector will be used first if available (instead of defaulting to `gpt-3.5-turbo`). <p align="center"> <img width="500" src="https://github.com/elastic/kibana/assets/2946766/637f5919-7560-40b0-a8db-681096e77ac0" /> </p> Note how `Model` is not displayed even though this is an OpenAI connector: <p align="center"> <img width="500" src="https://github.com/elastic/kibana/assets/2946766/2c4bbe91-2851-48d7-8bfe-20e07db52155" /> </p> Additionally, resolves issue with Detection Rule Assistant CTA not displaying correctly on some platforms/browsers. It now shows as a `Chat` button to the right of the table tabs, matching the other assistant CTA's throughout the application. <p align="center"> <img width="500" src="https://github.com/elastic/kibana/assets/2946766/9fcecd54-8e1a-423a-be05-7137632acbc4" /> </p> And lastly removes `Beta` title from callout since we're going GA in `8.10` 🎉 <p align="center"> <img width="500" src="https://github.com/elastic/kibana/assets/2946766/5beb379a-1bc7-4afc-b4bc-09f1d6085211" /> </p> Resolves: elastic#163394 (comment) Resolves: elastic#164819 ### Checklist Delete any items that are not applicable to this PR. - [X] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials (cherry picked from commit 5f9651e)
kibanamachine
referenced
this issue
Aug 28, 2023
… with Assistant (#164900) (#165046) # Backport This will backport the following commits from `main` to `8.10`: - [[Security Solution] Fixes Preconfigured Connectors not working with Assistant (#164900)](#164900) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Garrett Spong","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-08-28T20:46:33Z","message":"[Security Solution] Fixes Preconfigured Connectors not working with Assistant (#164900)\n\n## Summary\r\n\r\nFixes Preconfigured Connectors not working with the Assistant, and also\r\nensures default `model` from connector will be used first if available\r\n(instead of defaulting to `gpt-3.5-turbo`).\r\n\r\n<p align=\"center\">\r\n<img width=\"500\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2946766/637f5919-7560-40b0-a8db-681096e77ac0\"\r\n/>\r\n</p> \r\n\r\nNote how `Model` is not displayed even though this is an OpenAI\r\nconnector:\r\n<p align=\"center\">\r\n<img width=\"500\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2946766/2c4bbe91-2851-48d7-8bfe-20e07db52155\"\r\n/>\r\n</p> \r\n\r\nAdditionally, resolves issue with Detection Rule Assistant CTA not\r\ndisplaying correctly on some platforms/browsers. It now shows as a\r\n`Chat` button to the right of the table tabs, matching the other\r\nassistant CTA's throughout the application.\r\n\r\n<p align=\"center\">\r\n<img width=\"500\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2946766/9fcecd54-8e1a-423a-be05-7137632acbc4\"\r\n/>\r\n</p> \r\n\r\nAnd lastly removes `Beta` title from callout since we're going GA in\r\n`8.10` 🎉\r\n\r\n<p align=\"center\">\r\n<img width=\"500\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2946766/5beb379a-1bc7-4afc-b4bc-09f1d6085211\"\r\n/>\r\n</p> \r\n\r\nResolves:\r\nhttps://github.com//issues/163394#issuecomment-1693431066\r\nResolves: https://github.com/elastic/kibana/issues/164819\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [X] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials","sha":"5f9651e0ef99e35e9a4a3b5dfbd7e40160038f07","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team: SecuritySolution","Feature:Elastic AI Assistant","v8.10.0","v8.11.0"],"number":164900,"url":"https://github.com/elastic/kibana/pull/164900","mergeCommit":{"message":"[Security Solution] Fixes Preconfigured Connectors not working with Assistant (#164900)\n\n## Summary\r\n\r\nFixes Preconfigured Connectors not working with the Assistant, and also\r\nensures default `model` from connector will be used first if available\r\n(instead of defaulting to `gpt-3.5-turbo`).\r\n\r\n<p align=\"center\">\r\n<img width=\"500\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2946766/637f5919-7560-40b0-a8db-681096e77ac0\"\r\n/>\r\n</p> \r\n\r\nNote how `Model` is not displayed even though this is an OpenAI\r\nconnector:\r\n<p align=\"center\">\r\n<img width=\"500\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2946766/2c4bbe91-2851-48d7-8bfe-20e07db52155\"\r\n/>\r\n</p> \r\n\r\nAdditionally, resolves issue with Detection Rule Assistant CTA not\r\ndisplaying correctly on some platforms/browsers. It now shows as a\r\n`Chat` button to the right of the table tabs, matching the other\r\nassistant CTA's throughout the application.\r\n\r\n<p align=\"center\">\r\n<img width=\"500\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2946766/9fcecd54-8e1a-423a-be05-7137632acbc4\"\r\n/>\r\n</p> \r\n\r\nAnd lastly removes `Beta` title from callout since we're going GA in\r\n`8.10` 🎉\r\n\r\n<p align=\"center\">\r\n<img width=\"500\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2946766/5beb379a-1bc7-4afc-b4bc-09f1d6085211\"\r\n/>\r\n</p> \r\n\r\nResolves:\r\nhttps://github.com//issues/163394#issuecomment-1693431066\r\nResolves: https://github.com/elastic/kibana/issues/164819\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [X] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials","sha":"5f9651e0ef99e35e9a4a3b5dfbd7e40160038f07"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/164900","number":164900,"mergeCommit":{"message":"[Security Solution] Fixes Preconfigured Connectors not working with Assistant (#164900)\n\n## Summary\r\n\r\nFixes Preconfigured Connectors not working with the Assistant, and also\r\nensures default `model` from connector will be used first if available\r\n(instead of defaulting to `gpt-3.5-turbo`).\r\n\r\n<p align=\"center\">\r\n<img width=\"500\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2946766/637f5919-7560-40b0-a8db-681096e77ac0\"\r\n/>\r\n</p> \r\n\r\nNote how `Model` is not displayed even though this is an OpenAI\r\nconnector:\r\n<p align=\"center\">\r\n<img width=\"500\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2946766/2c4bbe91-2851-48d7-8bfe-20e07db52155\"\r\n/>\r\n</p> \r\n\r\nAdditionally, resolves issue with Detection Rule Assistant CTA not\r\ndisplaying correctly on some platforms/browsers. It now shows as a\r\n`Chat` button to the right of the table tabs, matching the other\r\nassistant CTA's throughout the application.\r\n\r\n<p align=\"center\">\r\n<img width=\"500\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2946766/9fcecd54-8e1a-423a-be05-7137632acbc4\"\r\n/>\r\n</p> \r\n\r\nAnd lastly removes `Beta` title from callout since we're going GA in\r\n`8.10` 🎉\r\n\r\n<p align=\"center\">\r\n<img width=\"500\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2946766/5beb379a-1bc7-4afc-b4bc-09f1d6085211\"\r\n/>\r\n</p> \r\n\r\nResolves:\r\nhttps://github.com//issues/163394#issuecomment-1693431066\r\nResolves: https://github.com/elastic/kibana/issues/164819\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [X] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials","sha":"5f9651e0ef99e35e9a4a3b5dfbd7e40160038f07"}}]}] BACKPORT--> Co-authored-by: Garrett Spong <[email protected]>
|
@karanbirsingh-qasource please validate this fix on BC3, thanks! :) |
|
We have validated this issue on 8.10 BC3 and found the issue to be fixed now ✔️ . Now sparkling icon is been removed from bulk rule selection. Kibana/Elasticsearch Stack version Screen-Cast:
Hence we are closing this issue and adding "QA:Validated" tag to it. thanks !! |
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug:
[Browser Issue]Incorrect Elastic AI Assistant icon on Rule Page
Kibana/Elasticsearch Stack version
Version: 8.10.0 BC2
Commit: fa3473f
Build: 66107
Browser and Browser OS Version:
Chrome for windows OS
Version: 116.0.5845.111
Edge for windows OS
Version: 116.0.1938.54
Elastic Endpoint Version:
v8.10.2
Original install method:
Build summary: https://staging.elastic.co/8.10.0-049269aa/summary-8.10.0.html
Functional Area:
Elastic AI Assistant
Initial Setup:
Steps to reproduce
Additional Observation
Current behavior
Expected behavior:
Screen-Cast:
Detection.rules.SIEM.-.Kibana.-.Google.Chrome.2023-08-25.15-06-16.mp4
Errors in browser console:
None
Any additional context (logs, chat logs, magical formulas, etc.):
None
The text was updated successfully, but these errors were encountered: