Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UnifiedFieldList] Redesign #164662

Closed
5 tasks
Tracked by #168084
kertal opened this issue Aug 24, 2023 · 1 comment · Fixed by #165866
Closed
5 tasks
Tracked by #168084

[UnifiedFieldList] Redesign #164662

kertal opened this issue Aug 24, 2023 · 1 comment · Fixed by #165866
Assignees
@jughosta
Labels
enhancement New value added to drive a business result Feature:Discover Discover Application Feature:UnifiedFieldList The unified field list component used by Lens & Discover impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@kertal
Copy link
Member

kertal commented Aug 24, 2023 •
edited by jughosta
Loading

This redesign aims for the compact view of the UnifiedFieldList in Discover

  • [Sidebar] Add a field button should be in its own container (gray horizontal line above it as shown in Figma)
  • [UnifiedFieldList] No more shadows in items
  • [UnifiedFieldList] MVP - The hide/show icons should horizontally align with the Field name search and the Histogram header section

Image

  • [UnifiedFieldList] Add a draggable icon to the items (optional, can be done in a follow up - needs new EUI icon)
  • [UnifiedFieldList] Reduce the margin between elements from 4px to at least 2px

Target outcome

Image
@kertal kertal added Feature:Discover Discover Application Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Aug 24, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kertal kertal added the Feature:UnifiedFieldList The unified field list component used by Lens & Discover label Aug 24, 2023
@kertal kertal added enhancement New value added to drive a business result loe:medium Medium Level of Effort impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. labels Aug 24, 2023
This was referenced Sep 5, 2023
Closed
Merged
jughosta added a commit that referenced this issue Sep 12, 2023
@jughosta @kibanamachine @davismcphee
[Discover] Redesign for the grid, panels and sidebar v1 (#165866)
6cb937a 
## Summary

### Part 1

- Resolves #164287
- Closes #146339
- Previously separate PR #164187

Changes:
- ~~swaps checkbox and row selection~~
- removes vertical borders
- adds rows highlight
- increases cell padding
- adds row stripes
- updates header background
- removes grey background from field name and makes it bolder (part of
#164634)
- updates Surrounding Documents side paddings

### Part 2

- Resolves #164661
- Previously separate PR #165687

Changes:
- removes background from panels, tabs and sidebar
- updates "Add a field" button style
- removes shadow from field list items
- makes field search compact

### Part 3

- Resolves #164662

Changes:
- wraps "Add a field" button in its own container with a top border
- ~~adds a drag handle to sidebar items~~
- ~~adds new Show/Hide buttons to toggle sidebar~~ moves sidebar toggle
button from discover plugin to unified field list
- reduces spaces between sidebar items from 4px to 2px
- reduces padding on Single Document page
- removes border above grid tabs

<img width="600" alt="Screenshot 2023-09-07 at 14 39 48"
src="https://github.com/elastic/kibana/assets/1415710/976db247-fd70-4c9b-8634-552ece45b522">


Please note that "auto" row height is in a separate PR which is also
ready for review #164218

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Davis McPhee <[email protected]>
Co-authored-by: Davis McPhee <[email protected]>
@kertal kertal mentioned this issue Oct 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jughosta jughosta

Labels
enhancement New value added to drive a business result Feature:Discover Discover Application Feature:UnifiedFieldList The unified field list component used by Lens & Discover impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Discover] Redesign for the grid, panels and sidebar v1 jughosta/kibana
3 participants
@kertal @jughosta @elasticmachine