Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test: Security Solution Cypress.x-pack/test/security_solution_cypress/cypress/e2e/investigations/alerts/detection_page_filters·cy·ts - Detections : Page Filters Number fields are not visible in field edit panel Number fields are not visible in field edit panel #164018

Closed
kibanamachine opened this issue Aug 16, 2023 · 2 comments
Assignees
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:Threat Hunting:Investigations Security Solution Investigations Team

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Aug 16, 2023

A test failed on a tracked branch

AssertionError: Timed out retrying after 150000ms: Expected to find element: `[data-test-subj="control-action-3-edit"]`, but never found it.
    at Context.eval (webpack:///./e2e/investigations/alerts/detection_page_filters.cy.ts:389:7)

First failure: CI Build - main

@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Aug 16, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Aug 16, 2023
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@oatkiller oatkiller added the Team:Threat Hunting:Investigations Security Solution Investigations Team label Aug 17, 2023
@botelastic botelastic bot removed the needs-team Issues missing a team label label Aug 17, 2023
logeekal added a commit that referenced this issue Apr 26, 2024
)

## Summary

### Flaky Tests to be fixed
 
  - #163544
  
  - #163757
  
  - #164018
  
  - #168276
  
  - #168277

### Fixes to make the tests more stable

- Disable `scrollBehaviour` for a [particular
test](https://github.com/elastic/kibana/pull/173163/files#diff-864d08982a2a67111903c3308f8b7ee797b34ec736f6747fedf46f8c36e08859R230)
- default `scrollBehavior` was true, which scrolls the element into view
automatically without any scroll Margin if an element has some hover
actions above the element, they get hidden on top of the window. So, we
need to set scrollBehavior to false to avoid scrolling the element into
view and we can scroll ourselves when needed
- Ref :
https://docs.cypress.io/guides/core-concepts/interacting-with-elements#Scrolling
    
- One code change has included a new
[parameter](https://github.com/elastic/kibana/pull/173163/files#diff-864d08982a2a67111903c3308f8b7ee797b34ec736f6747fedf46f8c36e08859R260)
which was a cause of failing a couple of tests. (Not flaky but failing)

 

### Flaky Test Runner Report

- [50
Runs](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5751)
    - Severless -  50/50 Pass
    - ESS -  50/50 Pass
- [100
Runs](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5753)
    - Severless -  100/100 Pass
    - ESS -   100/100 Pass

---------

Co-authored-by: Kibana Machine <[email protected]>
logeekal added a commit to logeekal/kibana that referenced this issue Apr 26, 2024
…tic#173163)

## Summary

### Flaky Tests to be fixed

  - elastic#163544

  - elastic#163757

  - elastic#164018

  - elastic#168276

  - elastic#168277

### Fixes to make the tests more stable

- Disable `scrollBehaviour` for a [particular
test](https://github.com/elastic/kibana/pull/173163/files#diff-864d08982a2a67111903c3308f8b7ee797b34ec736f6747fedf46f8c36e08859R230)
- default `scrollBehavior` was true, which scrolls the element into view
automatically without any scroll Margin if an element has some hover
actions above the element, they get hidden on top of the window. So, we
need to set scrollBehavior to false to avoid scrolling the element into
view and we can scroll ourselves when needed
- Ref :
https://docs.cypress.io/guides/core-concepts/interacting-with-elements#Scrolling

- One code change has included a new
[parameter](https://github.com/elastic/kibana/pull/173163/files#diff-864d08982a2a67111903c3308f8b7ee797b34ec736f6747fedf46f8c36e08859R260)
which was a cause of failing a couple of tests. (Not flaky but failing)

### Flaky Test Runner Report

- [50
Runs](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5751)
    - Severless -  50/50 Pass
    - ESS -  50/50 Pass
- [100
Runs](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5753)
    - Severless -  100/100 Pass
    - ESS -   100/100 Pass

---------

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit b34c8a9)
@logeekal
Copy link
Contributor

fixed with PR merged above.

logeekal referenced this issue Apr 26, 2024
#173163) (#181796)

# Backport

This will backport the following commits from `main` to `8.14`:
- [[Security Solution] Unskip tests - detection_page_filters.cy.ts
(#173163)](#173163)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jatin
Kathuria","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-04-26T05:09:28Z","message":"[Security
Solution] Unskip tests - detection_page_filters.cy.ts (#173163)\n\n##
Summary\r\n\r\n### Flaky Tests to be fixed\r\n \r\n -
https://github.com/elastic/kibana/issues/163544\r\n \r\n -
https://github.com/elastic/kibana/issues/163757\r\n \r\n -
https://github.com/elastic/kibana/issues/164018\r\n \r\n -
https://github.com/elastic/kibana/issues/168276\r\n \r\n -
https://github.com/elastic/kibana/issues/168277\r\n\r\n### Fixes to make
the tests more stable\r\n\r\n- Disable `scrollBehaviour` for a
[particular\r\ntest](https://github.com/elastic/kibana/pull/173163/files#diff-864d08982a2a67111903c3308f8b7ee797b34ec736f6747fedf46f8c36e08859R230)\r\n-
default `scrollBehavior` was true, which scrolls the element into
view\r\nautomatically without any scroll Margin if an element has some
hover\r\nactions above the element, they get hidden on top of the
window. So, we\r\nneed to set scrollBehavior to false to avoid scrolling
the element into\r\nview and we can scroll ourselves when needed\r\n-
Ref
:\r\nhttps://docs.cypress.io/guides/core-concepts/interacting-with-elements#Scrolling\r\n
\r\n- One code change has included a
new\r\n[parameter](https://github.com/elastic/kibana/pull/173163/files#diff-864d08982a2a67111903c3308f8b7ee797b34ec736f6747fedf46f8c36e08859R260)\r\nwhich
was a cause of failing a couple of tests. (Not flaky but
failing)\r\n\r\n \r\n\r\n### Flaky Test Runner Report\r\n\r\n-
[50\r\nRuns](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5751)\r\n
- Severless - 50/50 Pass\r\n - ESS - 50/50 Pass\r\n-
[100\r\nRuns](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5753)\r\n
- Severless - 100/100 Pass\r\n - ESS - 100/100
Pass\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine
<[email protected]>","sha":"b34c8a9ec9b80dc122a45fceae0360351c3fb37c","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Threat
Hunting:Investigations","backport:prev-minor","v8.15.0"],"number":173163,"url":"https://github.com/elastic/kibana/pull/173163","mergeCommit":{"message":"[Security
Solution] Unskip tests - detection_page_filters.cy.ts (#173163)\n\n##
Summary\r\n\r\n### Flaky Tests to be fixed\r\n \r\n -
https://github.com/elastic/kibana/issues/163544\r\n \r\n -
https://github.com/elastic/kibana/issues/163757\r\n \r\n -
https://github.com/elastic/kibana/issues/164018\r\n \r\n -
https://github.com/elastic/kibana/issues/168276\r\n \r\n -
https://github.com/elastic/kibana/issues/168277\r\n\r\n### Fixes to make
the tests more stable\r\n\r\n- Disable `scrollBehaviour` for a
[particular\r\ntest](https://github.com/elastic/kibana/pull/173163/files#diff-864d08982a2a67111903c3308f8b7ee797b34ec736f6747fedf46f8c36e08859R230)\r\n-
default `scrollBehavior` was true, which scrolls the element into
view\r\nautomatically without any scroll Margin if an element has some
hover\r\nactions above the element, they get hidden on top of the
window. So, we\r\nneed to set scrollBehavior to false to avoid scrolling
the element into\r\nview and we can scroll ourselves when needed\r\n-
Ref
:\r\nhttps://docs.cypress.io/guides/core-concepts/interacting-with-elements#Scrolling\r\n
\r\n- One code change has included a
new\r\n[parameter](https://github.com/elastic/kibana/pull/173163/files#diff-864d08982a2a67111903c3308f8b7ee797b34ec736f6747fedf46f8c36e08859R260)\r\nwhich
was a cause of failing a couple of tests. (Not flaky but
failing)\r\n\r\n \r\n\r\n### Flaky Test Runner Report\r\n\r\n-
[50\r\nRuns](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5751)\r\n
- Severless - 50/50 Pass\r\n - ESS - 50/50 Pass\r\n-
[100\r\nRuns](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5753)\r\n
- Severless - 100/100 Pass\r\n - ESS - 100/100
Pass\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine
<[email protected]>","sha":"b34c8a9ec9b80dc122a45fceae0360351c3fb37c"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.15.0","labelRegex":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/173163","number":173163,"mergeCommit":{"message":"[Security
Solution] Unskip tests - detection_page_filters.cy.ts (#173163)\n\n##
Summary\r\n\r\n### Flaky Tests to be fixed\r\n \r\n -
https://github.com/elastic/kibana/issues/163544\r\n \r\n -
https://github.com/elastic/kibana/issues/163757\r\n \r\n -
https://github.com/elastic/kibana/issues/164018\r\n \r\n -
https://github.com/elastic/kibana/issues/168276\r\n \r\n -
https://github.com/elastic/kibana/issues/168277\r\n\r\n### Fixes to make
the tests more stable\r\n\r\n- Disable `scrollBehaviour` for a
[particular\r\ntest](https://github.com/elastic/kibana/pull/173163/files#diff-864d08982a2a67111903c3308f8b7ee797b34ec736f6747fedf46f8c36e08859R230)\r\n-
default `scrollBehavior` was true, which scrolls the element into
view\r\nautomatically without any scroll Margin if an element has some
hover\r\nactions above the element, they get hidden on top of the
window. So, we\r\nneed to set scrollBehavior to false to avoid scrolling
the element into\r\nview and we can scroll ourselves when needed\r\n-
Ref
:\r\nhttps://docs.cypress.io/guides/core-concepts/interacting-with-elements#Scrolling\r\n
\r\n- One code change has included a
new\r\n[parameter](https://github.com/elastic/kibana/pull/173163/files#diff-864d08982a2a67111903c3308f8b7ee797b34ec736f6747fedf46f8c36e08859R260)\r\nwhich
was a cause of failing a couple of tests. (Not flaky but
failing)\r\n\r\n \r\n\r\n### Flaky Test Runner Report\r\n\r\n-
[50\r\nRuns](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5751)\r\n
- Severless - 50/50 Pass\r\n - ESS - 50/50 Pass\r\n-
[100\r\nRuns](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5753)\r\n
- Severless - 100/100 Pass\r\n - ESS - 100/100
Pass\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine
<[email protected]>","sha":"b34c8a9ec9b80dc122a45fceae0360351c3fb37c"}}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:Threat Hunting:Investigations Security Solution Investigations Team
Projects
None yet
Development

No branches or pull requests

5 participants