[Dashboard Navigation] Links editor accessibility review #163802
Assignees
Labels
a11yReviewNeeded
Accessibility design or code review
Feature:Dashboard
Dashboard related features
impact:medium
Addressing this issue will have a medium level of impact on the quality/strength of our product.
loe:medium
Medium Level of Effort
Project:Dashboard Navigation
Related to the Dashboard Navigation Project
Team:Presentation
Presentation Team for Dashboard, Input Controls, and Canvas
Comments
nickpeihl
added
Team:Presentation
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
7 tasks
|
For some context on the Links panel, please see the following:
|
|
@Heenawter Thank you for the nudge. When is GA scheduled? I'm heading out for holiday this afternoon but can pick this up 2 January when I'm back. |
|
@1Copenut Absolutely no rush - we aren't planning to GA until |
|
A11y review completed on 11 January, 2024. Thanks everyone! |
|
Closing this in favour of all the smaller tickets 🙇 Thanks so much for your work on this, @1Copenut 🎉 |
7 tasks
Heenawter
added a commit
that referenced
this issue
Jan 18, 2024
## Summary This PR addresses the a11y issues that were brought up as part of the [a11y review](#163802) via the following: - **Added `aria-current` attribute to the current dashboard link** | Before | After | |--------|--------| |  |  | - **Returned focus to the create flyout after adding/editing a link** | Before | After | |--------|--------| |  |  | - **Added `aria-label` attribute to `Technical preview` badge** | Before | After | |--------|--------| |  |  | - **Added more context to the `aria-label`s for the edit/delete link buttons** | Before | After | |--------|--------| |  |  | ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed ([Link](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4856))  - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
CoenWarmer
pushed a commit
to CoenWarmer/kibana
that referenced
this issue
Feb 15, 2024
## Summary This PR addresses the a11y issues that were brought up as part of the [a11y review](elastic#163802) via the following: - **Added `aria-current` attribute to the current dashboard link** | Before | After | |--------|--------| |  |  | - **Returned focus to the create flyout after adding/editing a link** | Before | After | |--------|--------| |  |  | - **Added `aria-label` attribute to `Technical preview` badge** | Before | After | |--------|--------| |  |  | - **Added more context to the `aria-label`s for the edit/delete link buttons** | Before | After | |--------|--------| |  |  | ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed ([Link](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4856))  - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The Links panel editor could benefit from an accessibility review prior to GA.
The text was updated successfully, but these errors were encountered: