Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UnifiedDocViewer] Filter on field name and value in expanded document view #163275

Closed
Tracked by #163284
jloleysens opened this issue Aug 7, 2023 · 5 comments · Fixed by #192299
Closed
Tracked by #163284

[UnifiedDocViewer] Filter on field name and value in expanded document view #163275

jloleysens opened this issue Aug 7, 2023 · 5 comments · Fixed by #192299
Assignees
Labels
enhancement New value added to drive a business result Feature:UnifiedDocViewer Issues relating to the unified doc viewer component impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Project:OneDiscover Enrich Discover with contextual awareness Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. usability

Comments

@jloleysens
Copy link
Contributor

jloleysens commented Aug 7, 2023

Describe the feature:

In the "Expanded document" today we filter on "field name" only. I often find I am trying to learn something about the values in documents. I realise there are other ways of doing this (view top values per field), but sometimes I have a specific value, or part of a value in mind and it'd be nice to directly search for from the "Expanded document" view (in addition to filtering by field names). The idea here might be to learn which field probably has this value.

Not sure whether this has been considered or if there is an existing request like this.

Screenshot 2023-08-07 at 11 08 45
@jloleysens jloleysens added the Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. label Aug 7, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kertal kertal added enhancement New value added to drive a business result usability impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort labels Aug 7, 2023
@kertal kertal changed the title [Discover] Filter on field name and value in expanded document view [UnifiedDocViewer] Filter on field name and value in expanded document view Aug 9, 2023
@lukasolson lukasolson added the Feature:UnifiedDocViewer Issues relating to the unified doc viewer component label Oct 24, 2023
@kertal
Copy link
Member

kertal commented Jul 19, 2024

I think this is something we could add to OneDiscover, as it's also available on security side, and IMO more useful than filtering by type wdyt @davismcphee @lukasolson

@davismcphee
Copy link
Contributor

+1 from me, this definitely seems like a useful feature IMO.

@kertal
Copy link
Member

kertal commented Jul 29, 2024

Added it to OneDiscover, as a future task

@kertal kertal added the Project:OneDiscover Enrich Discover with contextual awareness label Jul 29, 2024
@jughosta
Copy link
Contributor

jughosta commented Aug 7, 2024

@lukasolson I am reorganising some related code in #189981
Hope it's fine, or would you suggest to approach it differently?

@jughosta jughosta self-assigned this Sep 5, 2024
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Sep 26, 2024
…t view (elastic#192299)

- Closes elastic#163275

## Summary

With this PR users can search by field value (raw and formatted) in
DocViewer flyout.

<img width="569" alt="Screenshot 2024-09-06 at 20 49 57"
src="https://github.com/user-attachments/assets/27e89017-4b8f-437b-9e00-b9a24eb88184">
<img width="544" alt="Screenshot 2024-09-06 at 20 50 09"
src="https://github.com/user-attachments/assets/5086af87-df97-4fdb-84c3-f30c547678e0">
<img width="536" alt="Screenshot 2024-09-12 at 18 45 11"
src="https://github.com/user-attachments/assets/abdfe31d-85a5-41de-bf05-88ecf0ac2b18">

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 7b76160)
kibanamachine referenced this issue Sep 26, 2024
…ocument view (#192299) (#194094)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[UnifiedDocViewer] Filter on field name and value in expanded
document view (#192299)](#192299)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Julia
Rechkunova","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-26T07:11:34Z","message":"[UnifiedDocViewer]
Filter on field name and value in expanded document view (#192299)\n\n-
Closes https://github.com/elastic/kibana/issues/163275\r\n\r\n##
Summary\r\n\r\nWith this PR users can search by field value (raw and
formatted) in\r\nDocViewer flyout.\r\n\r\n<img width=\"569\"
alt=\"Screenshot 2024-09-06 at 20 49
57\"\r\nsrc=\"https://github.com/user-attachments/assets/27e89017-4b8f-437b-9e00-b9a24eb88184\">\r\n<img
width=\"544\" alt=\"Screenshot 2024-09-06 at 20 50
09\"\r\nsrc=\"https://github.com/user-attachments/assets/5086af87-df97-4fdb-84c3-f30c547678e0\">\r\n<img
width=\"536\" alt=\"Screenshot 2024-09-12 at 18 45
11\"\r\nsrc=\"https://github.com/user-attachments/assets/abdfe31d-85a5-41de-bf05-88ecf0ac2b18\">\r\n\r\n\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] This was
checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"7b76160d68af1535c14343725c8280933ae0e937","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","v9.0.0","Team:DataDiscovery","backport:prev-minor","Project:OneDiscover"],"title":"[UnifiedDocViewer]
Filter on field name and value in expanded document
view","number":192299,"url":"https://github.com/elastic/kibana/pull/192299","mergeCommit":{"message":"[UnifiedDocViewer]
Filter on field name and value in expanded document view (#192299)\n\n-
Closes https://github.com/elastic/kibana/issues/163275\r\n\r\n##
Summary\r\n\r\nWith this PR users can search by field value (raw and
formatted) in\r\nDocViewer flyout.\r\n\r\n<img width=\"569\"
alt=\"Screenshot 2024-09-06 at 20 49
57\"\r\nsrc=\"https://github.com/user-attachments/assets/27e89017-4b8f-437b-9e00-b9a24eb88184\">\r\n<img
width=\"544\" alt=\"Screenshot 2024-09-06 at 20 50
09\"\r\nsrc=\"https://github.com/user-attachments/assets/5086af87-df97-4fdb-84c3-f30c547678e0\">\r\n<img
width=\"536\" alt=\"Screenshot 2024-09-12 at 18 45
11\"\r\nsrc=\"https://github.com/user-attachments/assets/abdfe31d-85a5-41de-bf05-88ecf0ac2b18\">\r\n\r\n\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] This was
checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"7b76160d68af1535c14343725c8280933ae0e937"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/192299","number":192299,"mergeCommit":{"message":"[UnifiedDocViewer]
Filter on field name and value in expanded document view (#192299)\n\n-
Closes https://github.com/elastic/kibana/issues/163275\r\n\r\n##
Summary\r\n\r\nWith this PR users can search by field value (raw and
formatted) in\r\nDocViewer flyout.\r\n\r\n<img width=\"569\"
alt=\"Screenshot 2024-09-06 at 20 49
57\"\r\nsrc=\"https://github.com/user-attachments/assets/27e89017-4b8f-437b-9e00-b9a24eb88184\">\r\n<img
width=\"544\" alt=\"Screenshot 2024-09-06 at 20 50
09\"\r\nsrc=\"https://github.com/user-attachments/assets/5086af87-df97-4fdb-84c3-f30c547678e0\">\r\n<img
width=\"536\" alt=\"Screenshot 2024-09-12 at 18 45
11\"\r\nsrc=\"https://github.com/user-attachments/assets/abdfe31d-85a5-41de-bf05-88ecf0ac2b18\">\r\n\r\n\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] This was
checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"7b76160d68af1535c14343725c8280933ae0e937"}}]}]
BACKPORT-->

Co-authored-by: Julia Rechkunova <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:UnifiedDocViewer Issues relating to the unified doc viewer component impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Project:OneDiscover Enrich Discover with contextual awareness Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. usability
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants