Can't remove panel containing missing visualization from dashboard

[cjcenizal]

If a panel is really narrow and the visualization is deleted, then a) the context menu gets cropped off and unusable and b) the panel can't be dragged wider or moved.

CC @elastic/kibana-sharing

[chrisdavies]

Hm. Just reproduced this.

It seems to me this is really a few separate issues:

• If you delete a visualization, there's no point to keeping the panels around, so a "cascade delete" seems like the right behavior
• The fly-out menu should intelligently position itself based on where it is on the screen.
• Panels should probably have overflow auto to avoid this:

[chrisdavies]

I'm going with a simple z-index CSS fix for now. Hopefully no adverse side effects!

[stacey-gammon]

Sounds good! Are you also not able to resize the panel when this happens? If so, that sounds like a bug too.

If you delete a visualization, there's no point to keeping the panels around, so a "cascade delete" seems like the right behavior

I think we should give the option of this. This issue is somewhat relevant: #16912. A great improvement would be to show a list of objects that reference this one, and give the option to possibly delete. We probably don't want this to be automatic because deleting the whole panel would change the layout of the dashboard, so users may want to go in and re-arrange the layout. So a natural step is probably first to remove from all dashboards, then to go and delete the visualization.

The fly-out menu should intelligently position itself based on where it is on the screen.

++

Panels should probably have overflow auto to avoid this:

++

[chrisdavies]

Debating on whether to fix this independently and log those other scenarios separately. The flyout may be positioning itself correctly, as it looks fine now that I have the z-index fix in place. Also, this is tricky to test, since the menu was clickable even with the bug in place. So, I'm leaving off tests for now.

[cjcenizal]

@chrisdavies Your PR fixed the problem with the content menu, but I think the problem with resizing and removing the panel still exists right? If so, could you create new tickets to encapsulate those issues and cross-link to this one?

[chrisdavies]

You're totally right! I forgot to log the other issues. I'll do it this afternoon.

…

On March 8, 2018 12:24:06 PM EST, CJ Cenizal ***@***.***> wrote: @chrisdavies Your PR fixed the problem with the content menu, but I think the problem with resizing and removing the panel still exists right? If so, could you create new tickets to encapsulate those issues and cross-link to this one? -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #16305 (comment)

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

[chrisdavies]

@cjcenizal Following up on this, now that I'm wheels down again.

I can't reproduce this issue any longer now that the z-index is fixed. What browser are you using to repro it? I can resize and delete, and even the text overflow that I mentioned no longer seems to reproduce.

[cjcenizal]

Ahh the mystery deepens... I'm on OS X and I can repro error on Chrome, but not on Firefox or Safari. So it looks like this is a Chrome bug.

[chrisdavies]

Hm. It deepens, indeed. I'm also on OS X, using Chrome, and I can delete, resize, etc in the given scenario. I'm going to just reopen this. I'm at x-school this week, so dunno if I'll be able to take much of a look until next week. We shall see!