-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow variable names with underscores on Console #162205
Labels
enhancement
New value added to drive a business result
Feature:Console
Dev Tools Console Feature
Team:Kibana Management
Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Comments
sakurai-youhei
added
Feature:Console
Dev Tools Console Feature
enhancement
New value added to drive a business result
labels
Jul 19, 2023
sakurai-youhei
added a commit
to sakurai-youhei/kibana
that referenced
this issue
Jul 19, 2023
4 tasks
wayneseymour
added
the
Team:Kibana Management
Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
label
Jul 25, 2023
Pinging @elastic/platform-deployment-management (Team:Deployment Management) |
sakurai-youhei
added a commit
that referenced
this issue
Jul 31, 2023
Closes #162205 ## Summary With this PR, users will be able to define variables with names containing underscores (`_`) like the below picture. ![image](https://github.com/elastic/kibana/assets/721858/d6aa0b4c-0c12-4fe7-ab3f-da0aa5cc8862) ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <[email protected]>
ThomThomson
pushed a commit
to ThomThomson/kibana
that referenced
this issue
Aug 1, 2023
Closes elastic#162205 ## Summary With this PR, users will be able to define variables with names containing underscores (`_`) like the below picture. ![image](https://github.com/elastic/kibana/assets/721858/d6aa0b4c-0c12-4fe7-ab3f-da0aa5cc8862) ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New value added to drive a business result
Feature:Console
Dev Tools Console Feature
Team:Kibana Management
Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Describe the feature:
Variable names with underscores such as
snake_case
,MACRO_CASE
,__python_dunders__
, etc. are very common, but these underscores are not allowed in variable names on Kibana > Dev Tools > Console.Describe a specific use case for the feature:
Without this, the expression is very limited as only
camelCase
andPascalCase
are considerable.The text was updated successfully, but these errors were encountered: