Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Log Explorer] Group uncategorized data streams by dataset #162061

Closed
weltenwort opened this issue Jul 17, 2023 · 4 comments · Fixed by #162144
Closed

[Log Explorer] Group uncategorized data streams by dataset #162061

weltenwort opened this issue Jul 17, 2023 · 4 comments · Fixed by #162144
Assignees
Labels
Feature:LogsExplorer Logs Explorer feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services

Comments

@weltenwort
Copy link
Member

weltenwort commented Jul 17, 2023

📓 Summary

Currently the list of "uncategorized" data streams in the dataset selector lists all data streams of the same type and dataset separately for each namespace. In order to provide a consistent experience with the integration-owned data streams, we want to only show one entry for each dataset and leave the namespace filtering up to the filter control bar.

✔️ Acceptance criteria

  • For a given combination of type and dataset, only one "uncategorized" data stream entry is shown, which uses * for the namespace.
  • Selecting the entry of an "uncategorized" data stream creates a data view targeting ${type}-${dataset}-*.
  • The namespace filter control offers the known values for the namespace for filtering if this is implemented after [Log Explorer] Add filter controls customization point #158561 is merged.

🎨 Examples

Currently the same uncategorized dataset example in three different namespaces one, two, and thre would be listed as:

  • logs-example-one
  • logs-example-two
  • logs-example-three

Instead we want them to be listed as

  • logs-example-*

💡 Implementation hints

  • Since the fleet API should not be tied too closely to our UX concerns, we probably want to perform this grouping on the browser side after fetching the list of uncategorized data streams.
@weltenwort weltenwort added Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Jul 17, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@mohamedhamed-ahmed
Copy link
Contributor

qq: Do we want to list them as logs-example-* or just logs-example

@weltenwort
Copy link
Member Author

weltenwort commented Jul 17, 2023

Good question. I used logs-example-* in the ACs because it reflects better what's going on in the query. If we just removed the namespace I assume it would be harder for the user to understand the connection to their data streams.

While we generally try to not leak unnecessary Elasticsearch concepts, I see the uncategorized data streams as an intentional bridge between the ES world and the integration-based world.

Does that seem like a reasonable argument?

@mohamedhamed-ahmed
Copy link
Contributor

yes makes sense to me, at the beginning I thought it would better be consistent with the categorized dataSets, but your argument makes total sense 👍

@tonyghiani tonyghiani self-assigned this Jul 18, 2023
tonyghiani added a commit that referenced this issue Jul 18, 2023
## 📓 Summary

Closes #162061 

This implementation updates and aggregates the unmanaged datasets once
they are retrieved by the state machine on initialization.

I implemented this step in the state machine against doing it on the
dataset service to keep the service pure and able to serve the whole
response in case we need to use it on other plugins/use cases.


https://github.com/elastic/kibana/assets/34506779/a5883521-6dd7-4291-9b90-0cd7665bed65

---------

Co-authored-by: Marco Antonio Ghiani <[email protected]>
ThomThomson pushed a commit to ThomThomson/kibana that referenced this issue Aug 1, 2023
## 📓 Summary

Closes elastic#162061 

This implementation updates and aggregates the unmanaged datasets once
they are retrieved by the state machine on initialization.

I implemented this step in the state machine against doing it on the
dataset service to keep the service pure and able to serve the whole
response in case we need to use it on other plugins/use cases.


https://github.com/elastic/kibana/assets/34506779/a5883521-6dd7-4291-9b90-0cd7665bed65

---------

Co-authored-by: Marco Antonio Ghiani <[email protected]>
@gbamparop gbamparop added Feature:LogsExplorer Logs Explorer feature and removed Feature:Logs UI Logs UI feature labels Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:LogsExplorer Logs Explorer feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants