Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EMS] Point EMS Landing Page to the root directory #161791

Closed
Tracked by #157094
jsanz opened this issue Jul 12, 2023 · 1 comment · Fixed by #162494
Closed
Tracked by #157094

[EMS] Point EMS Landing Page to the root directory #161791

jsanz opened this issue Jul 12, 2023 · 1 comment · Fixed by #162494
Assignees
Labels
Feature:Maps impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@jsanz
Copy link
Member

jsanz commented Jul 12, 2023

EMS Landing Page link in Kibana should point to https://maps.elastic.co from now on for serverless builds.

On the EMS Landing Page side, the root location of the website is set up get the contents of the main branch (master), mapping to the latest development version of the Stack (8.10 at the time of this update).

Part of #157094

@jsanz jsanz changed the title Point EMS Landing Page to the root directory for Serverless deployments [EMS] Point EMS Landing Page to the root directory for Serverless deployments Jul 12, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Jul 12, 2023
@jsanz jsanz added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Feature:Maps labels Jul 12, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Jul 12, 2023
@jsanz jsanz self-assigned this Jul 12, 2023
@jsanz jsanz added loe:small Small Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Jul 13, 2023
@jsanz jsanz changed the title [EMS] Point EMS Landing Page to the root directory for Serverless deployments [EMS] Point EMS Landing Page to the root directory Jul 25, 2023
jsanz added a commit that referenced this issue Aug 2, 2023
Fixes #161791

Updates the link to the EMS Landing Page website in the Kibana Maps UI
to point to the root directory at https://maps.elastic.co when the build
is `serverless` and to the correct `https://maps.elastic.co/vX.Y` for
`traditional` builds.

To test:

* When running with `yarn start`
* Check the link in the source details of an EMS Administrative
boundaries dataset in the Maps Application
* When running with `yarn start --serverless=es`
* Check the source details of an EMS Administrative boundaries dataset
in the Maps Application

:warning: **Note**: This change does not affect the link in the Tutorial
for the Elastic Maps Service since it only touches the EMS Client
creation and not the `EMSSettings` that happens synchronously. This is
OK since that tutorial should point to the latest Landing Page revision
to offer all the data for our users.

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Maps impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants