[Lens] editor blows up when using dimension panel #161759
Assignees
Labels
bug
Fixes for quality problems that affect the customer experience
Feature:Lens
impact:high
Addressing this issue will have a high level of impact on the quality/strength of our product.
Team:Visualizations
Visualization editors, elastic-charts and infrastructure
Comments
mbondyra
added
bug
|
Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations) |
mbondyra
changed the title
|
This is concerning 🤔 I can't replicate it though. |
|
I did a bisect check and it was caused by my PR with removed #161521 but it's hard to find the root cause yet. Will keep digging. |
mbondyra
changed the title
This was referenced Jul 13, 2023
mbondyra
added a commit
that referenced
this issue
Jul 17, 2023
## Summary Fixes #161759 Fixes #161854 Fixes #161988 Fixes #161666 This bug surfaced by my change with NativeRenderer removal PR. It happens because sometimes there are two updates happening at the same time, in this case *`setState` coming from optimizing middleware to update the relative timerange in a call to es * updating datasource. Two updates is not a problem and works correctly for the same case for visualizations etc, but for the `updateDatasourceState` we break one of the fundamental rules of redux by passing non-serializable prop to action (an `updater` function that is then called internally with the previous state). The problem is that in the meantime the state gets updated from the previous `setState` call. To avoid this problem I rewrote the `updateDatasourceState` action to not accept updater function. To avoid these problems in the future I've also included a `serializableCheck` that ignores dataViews and some other properties (they contain some non-serializable data, I hope we'll take care of them in the future) ``` serializableCheck: { ignoredActionPaths: ['lens.dataViews.indexPatterns'], ignoredPaths: ['lens.dataViews.indexPatterns'], }, ``` I also fixed a few small issues, will leave comments in the code. ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### Risk Matrix Delete this section if it is not applicable to this PR. Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release. When forming the risk matrix, consider some of the following examples and how they may potentially impact the change: | Risk | Probability | Severity | Mitigation/Notes | |---------------------------|-------------|----------|-------------------------| | Multiple Spaces—unexpected behavior in non-default Kibana Space. | Low | High | Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces. | | Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. | High | Low | Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure. | | Code should gracefully handle cases when feature X or plugin Y are disabled. | Medium | High | Unit tests will verify that any feature flag or plugin combination still results in our service operational. | | [See more potential risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) | ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: Stratoula Kalafateli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Kibana version:
main (couldn't reproduce on 8.9, so wasn't released 😌)
Jul-12-2023.14-21-04.mp4
The text was updated successfully, but these errors were encountered: