Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[App Services] Migrate all usages of EuiPage*_Deprecated #161425

Closed
4 tasks done
Tracked by #161872
cee-chen opened this issue Jul 7, 2023 · 4 comments · Fixed by #163409
Closed
4 tasks done
Tracked by #161872

[App Services] Migrate all usages of EuiPage*_Deprecated #161425

cee-chen opened this issue Jul 7, 2023 · 4 comments · Fixed by #163409
Assignees
@vadimkibana
Labels
deprecation_warnings EUI Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)

Comments

@cee-chen
Copy link
Member

cee-chen commented Jul 7, 2023 •
edited by vadimkibana
Loading

👋 Hello from your friendly neighborhood EUI team! It's been almost a year since EUI's new EuiPageTemplate came out (if you can believe it), which means we're about a month away from the old deprecated EUI page template components being permanently removed.

Your team is being pinged in this issue because you have usages of EuiPage*_Deprecated components, which you can find listed here:

How

  • Please see our new EuiPageTemplate guidelines and examples for suggestions on how to migrate over.
  • You can also see more examples of layout conversions in the original EuiPageTemplate PR:
    [Feature] EuiPage and EuiPageTemplate Updates eui#5768
  • Here's a quick conversion map of components that approximately translate to their new equivalents:
    • EuiPageTemplate_Deprecated -> EuiPageTemplate
    • EuiPageSideBar_Deprecated -> EuiPageSidebar or EuiPageTemplate.Sidebar
    • EuiPageContent_Deprecated -> EuiPageSection or EuiPageTemplate.Section
    • EuiPageContentBody_Deprecated -> Use EuiPageSection instead
    • EuiPageContentHeader_Deprecated -> Use EuiPageHeader instead
    • EuiPageContentHeaderSection_Deprecated -> Use EuiPageHeader instead

When

We'd really appreciate it if you could migrate your component usages over before or during August if possible.

If your team does not have the ability or bandwidth to perform this work by that time, please let us know. While we'd really appreciate as many teams as possible taking on this work so we're not having to touch hundreds of files by ourselves and in one go, the EUI team can potentially help you out - but we will need you to help QA that work and ensure your layouts look the same as before.

Thanks, and please feel free to reach out anytime with questions or help with migration!

Tasks
Beta Give feedback
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-team (EUI)

@cee-chen
Copy link
Member Author

cee-chen commented Jul 7, 2023

Pinging @elastic/kibana-app-services

@petrklapka petrklapka mentioned this issue Jul 13, 2023
Closed
1 task
@kertal
Copy link
Member

kertal commented Jul 27, 2023

moving examples/data_view_field_editor_example to @elastic/kibana-data-discovery since it's in out domain in the meantime and AppServicesUx team was distributed among other teams

@vadimkibana vadimkibana added the Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) label Aug 3, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@vadimkibana vadimkibana self-assigned this Aug 3, 2023
This was referenced Aug 8, 2023
Merged
Merged
Merged
vadimkibana added a commit that referenced this issue Aug 8, 2023
@vadimkibana
Update EUI deprecated components in sample screenshot plugin (#163409)
c13dcf4 
## Summary

Closes #161425
vadimkibana added a commit that referenced this issue Aug 8, 2023
@vadimkibana
Updates deprecated EUI components in locators example plugins (#163405)
c523274 
## Summary

Partially addresses #161425

New look:

<img width="2017" alt="image"
src="https://github.com/elastic/kibana/assets/82822460/313fe761-2060-4b7b-b5d3-3f655d2cec02">
vadimkibana added a commit that referenced this issue Aug 8, 2023
@vadimkibana
remove deprecated components, improve spacing and title (#163378)
346fc7e 
## Summary

Partially addresses #161425

New look:

<img width="1645" alt="image"
src="https://github.com/elastic/kibana/assets/82822460/9da0ae4a-9f6e-4744-80c1-9a13b6d23d1c">
bryce-b pushed a commit to bryce-b/kibana that referenced this issue Aug 9, 2023
@vadimkibana @bryce-b
Update EUI deprecated components in sample screenshot plugin (elastic…
a6be4e0 
…#163409)

## Summary

Closes elastic#161425
bryce-b pushed a commit to bryce-b/kibana that referenced this issue Aug 9, 2023
@vadimkibana @bryce-b
Updates deprecated EUI components in locators example plugins (elasti…
b9febac 
…c#163405)

## Summary

Partially addresses elastic#161425

New look:

<img width="2017" alt="image"
src="https://github.com/elastic/kibana/assets/82822460/313fe761-2060-4b7b-b5d3-3f655d2cec02">
bryce-b pushed a commit to bryce-b/kibana that referenced this issue Aug 9, 2023
@vadimkibana @bryce-b
remove deprecated components, improve spacing and title (elastic#163378)
180b7e1 
## Summary

Partially addresses elastic#161425

New look:

<img width="1645" alt="image"
src="https://github.com/elastic/kibana/assets/82822460/9da0ae4a-9f6e-4744-80c1-9a13b6d23d1c">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vadimkibana vadimkibana

Labels
deprecation_warnings EUI Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update EUI deprecated components in sample screenshot plugin vadimkibana/kibana
4 participants
@kertal @cee-chen @elasticmachine @vadimkibana