Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TSVB] Cleanup typos in types #161019

Closed
markov00 opened this issue Jun 30, 2023 · 2 comments · Fixed by #161844
Closed

[TSVB] Cleanup typos in types #161019

markov00 opened this issue Jun 30, 2023 · 2 comments · Fixed by #161844
Labels
bug Fixes for quality problems that affect the customer experience Feature:TSVB TSVB (Time Series Visual Builder) impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@markov00
Copy link
Member

Kibana version: main

There is this magic typo in TSVB Panel model:

kibana/src/plugins/vis_types/timeseries/common/types/panel_model.ts

Lines 104 to 105 in 6f87e1d

separate_axis: number;
seperate_axis: number;

The problem here is that value percolates undisturbed in our saved objects in both of its forms, at least from a quick search I've done around both prop names.
This is also used as a boolean flag but is typed as a number with no real reason.
@markov00 markov00 added bug Fixes for quality problems that affect the customer experience Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jun 30, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

@stratoula stratoula added the impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. label Jul 3, 2023
@stratoula
Copy link
Contributor

The field with the typo is only used on a mock file so I think there is no problem on removing it src/plugins/vis_types/timeseries/public/convert_to_lens/lib/__mocks__/index.ts

@stratoula stratoula added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. and removed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Jul 13, 2023
@stratoula stratoula mentioned this issue Jul 13, 2023
Merged
stratoula added a commit that referenced this issue Jul 13, 2023
@stratoula
[TSVB] Removes unused type (#161844)
3c46440 
## Summary

Closes #161019

Cleanups unused type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:TSVB TSVB (Time Series Visual Builder) impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[TSVB] Removes unused type stratoula/kibana
3 participants
@markov00 @elasticmachine @stratoula