Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing ES Promotion: FTR Configs #52 / Snapshots app Snapshot restore Renders the Snapshot restore form #160929

Closed
mistic opened this issue Jun 29, 2023 · 2 comments · Fixed by #161113
Closed

Failing ES Promotion: FTR Configs #52 / Snapshots app Snapshot restore Renders the Snapshot restore form #160929

mistic opened this issue Jun 29, 2023 · 2 comments · Fixed by #161113
Assignees
@ElenaStoeva
Labels
failed-es-promotion Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@mistic
Copy link
Member

mistic commented Jun 29, 2023

Chrome X-Pack UI Functional Tests
x-pack/test/functional/apps/snapshot_restore/snapshot_restore.ts

Snapshots app Snapshot restore Renders the Snapshot restore form

This failure is preventing the promotion of the current Elasticsearch snapshot.

For more information on the Elasticsearch snapshot process including how to reproduce using the unverified ES build please read the failed promotion annotation. Other important information can be found at:

Error: retry.try timeout: TimeoutError: Waiting for element to be located By(css selector, [data-test-subj="nextButton"])
Wait timed out after 10053ms
    at /var/lib/buildkite-agent/builds/kb-n2-4-spot-c9cc856f11b80dbf/elastic/kibana-elasticsearch-snapshot-verify/kibana/node_modules/selenium-webdriver/lib/webdriver.js:929:17
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at onFailure (retry_for_success.ts:17:9)
    at retryForSuccess (retry_for_success.ts:59:13)
    at RetryService.try (retry.ts:31:12)
    at Proxy.clickByCssSelector (find.ts:417:5)
    at TestSubjects.click (test_subjects.ts:164:5)
    at Context.<anonymous> (snapshot_restore.ts:54:7)
    at Object.apply (wrap_function.js:73:16)
@mistic mistic added blocker Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more skipped-test failed-es-promotion v8.10.0 labels Jun 29, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

mistic added a commit that referenced this issue Jun 29, 2023
@mistic
skip failing es promotion suites (#160929)
f3c6d04
@mistic
Copy link
Member Author

mistic commented Jun 29, 2023

Skipped.

main: f3c6d04

@ElenaStoeva ElenaStoeva mentioned this issue Jul 3, 2023
Merged
ElenaStoeva added a commit that referenced this issue Jul 27, 2023
@ElenaStoeva @kibanamachine
[Snapshot Restore] Fix broken Snapshot restore form (#161113)
fa90a2f 
Fix #160974
Fix #160929

## Summary

From Es 8.10, the `version` field from the Get Snapshot response has a
different format - it will no longer be a string representing the
release version, but rather it will be a string representing the version
id (see
#160974 (comment)
for more details).

This PR replaces the use of the `version` field with the `versionId`
field when checking in the Snapshot Restore form if the current version
is greater than 7.12 (which corresponds to `versionID` 7120099).
The PR also unskips the functional test that failed with the promotion
of Es to 8.10.

**How to test:**

1. Start Es with `yarn es snapshot -E path.repo=./tmp/snap` and Kibana
with `yarn start`
2. Go to Stack Management -> Snapshot and Restore
3. Create a Shared File System repository with location `./tmp/snap`
4. Create a policy that uses the repository created in the previous
step.
5. Run the policy to create a snapshot.
6. Go to the Snapshots tab and click the Restore button for the created
snapshot.
7. Verify that the Snapshot restore form works as expected.

---------

Co-authored-by: Kibana Machine <[email protected]>
ThomThomson pushed a commit to ThomThomson/kibana that referenced this issue Aug 1, 2023
@ElenaStoeva @kibanamachine
[Snapshot Restore] Fix broken Snapshot restore form (elastic#161113)
efbb807 
Fix elastic#160974
Fix elastic#160929

## Summary

From Es 8.10, the `version` field from the Get Snapshot response has a
different format - it will no longer be a string representing the
release version, but rather it will be a string representing the version
id (see
elastic#160974 (comment)
for more details).

This PR replaces the use of the `version` field with the `versionId`
field when checking in the Snapshot Restore form if the current version
is greater than 7.12 (which corresponds to `versionID` 7120099).
The PR also unskips the functional test that failed with the promotion
of Es to 8.10.

**How to test:**

1. Start Es with `yarn es snapshot -E path.repo=./tmp/snap` and Kibana
with `yarn start`
2. Go to Stack Management -> Snapshot and Restore
3. Create a Shared File System repository with location `./tmp/snap`
4. Create a policy that uses the repository created in the previous
step.
5. Run the policy to create a snapshot.
6. Go to the Snapshots tab and click the Restore button for the created
snapshot.
7. Verify that the Snapshot restore form works as expected.

---------

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ElenaStoeva ElenaStoeva

Labels
failed-es-promotion Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Snapshot Restore] Fix broken Snapshot restore form ElenaStoeva/kibana
4 participants
@mistic @elasticmachine @kibanamachine @ElenaStoeva