[ML] Accessibility: Links on job validation step are not distinguished from surrounding text in a way that does not rely on color #160379
Assignees
Labels
bug
Fixes for quality problems that affect the customer experience
Feature:Anomaly Detection
ML anomaly detection
:ml
Project:Accessibility
v8.9.0
Comments
peteharverson
added
bug
|
Pinging @elastic/kibana-accessibility (Project:Accessibility) |
|
Pinging @elastic/ml-ui (:ml) |
|
Beat me to it @peteharverson. I was looking through the Buildkite logs and just about to add an image to the parent ticket. Thank you! |
Merged
1 task
darnautov
added a commit
that referenced
this issue
Jun 27, 2023
…rom surrounding text (#160608) ## Summary Resolves #160379 Adds heading to the validation messages to make all links rendered as part of the text content. <img width="1224" alt="image" src="https://github.com/elastic/kibana/assets/5236598/47416d44-7b3a-4694-88e2-43605bacc04f"> ### Checklist - [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Jun 27, 2023
…rom surrounding text (elastic#160608) ## Summary Resolves elastic#160379 Adds heading to the validation messages to make all links rendered as part of the text content. <img width="1224" alt="image" src="https://github.com/elastic/kibana/assets/5236598/47416d44-7b3a-4694-88e2-43605bacc04f"> ### Checklist - [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) (cherry picked from commit 59bd9f6)
kibanamachine
referenced
this issue
Jun 27, 2023
…shed from surrounding text (#160608) (#160637) # Backport This will backport the following commits from `main` to `8.9`: - [[ML] Accessibility: Make links on job validation step distinguished from surrounding text (#160608)](#160608) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dima Arnautov","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-06-27T14:35:19Z","message":"[ML] Accessibility: Make links on job validation step distinguished from surrounding text (#160608)\n\n## Summary\r\n\r\nResolves https://github.com/elastic/kibana/issues/160379\r\n\r\nAdds heading to the validation messages to make all links rendered as\r\npart of the text content.\r\n\r\n<img width=\"1224\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/5236598/47416d44-7b3a-4694-88e2-43605bacc04f\">\r\n\r\n\r\n### Checklist\r\n\r\n- [x] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))","sha":"59bd9f6459b5c8aa8c0e519eb1c6565586231046","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Project:Accessibility",":ml","Team:ML","v8.9.0","v8.10.0"],"number":160608,"url":"https://github.com/elastic/kibana/pull/160608","mergeCommit":{"message":"[ML] Accessibility: Make links on job validation step distinguished from surrounding text (#160608)\n\n## Summary\r\n\r\nResolves https://github.com/elastic/kibana/issues/160379\r\n\r\nAdds heading to the validation messages to make all links rendered as\r\npart of the text content.\r\n\r\n<img width=\"1224\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/5236598/47416d44-7b3a-4694-88e2-43605bacc04f\">\r\n\r\n\r\n### Checklist\r\n\r\n- [x] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))","sha":"59bd9f6459b5c8aa8c0e519eb1c6565586231046"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/160608","number":160608,"mergeCommit":{"message":"[ML] Accessibility: Make links on job validation step distinguished from surrounding text (#160608)\n\n## Summary\r\n\r\nResolves https://github.com/elastic/kibana/issues/160379\r\n\r\nAdds heading to the validation messages to make all links rendered as\r\npart of the text content.\r\n\r\n<img width=\"1224\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/5236598/47416d44-7b3a-4694-88e2-43605bacc04f\">\r\n\r\n\r\n### Checklist\r\n\r\n- [x] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))","sha":"59bd9f6459b5c8aa8c0e519eb1c6565586231046"}}]}] BACKPORT--> Co-authored-by: Dima Arnautov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The links in the callouts on the validation step of anomaly detection job wizard are failing the accessibility test:
The text was updated successfully, but these errors were encountered: