Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Infra UI] Add overview tab with the first section to asset details view #160376

Closed
jennypavlova opened this issue Jun 23, 2023 · 3 comments · Fixed by #160924
Closed

[Infra UI] Add overview tab with the first section to asset details view #160376

jennypavlova opened this issue Jun 23, 2023 · 3 comments · Fixed by #160924
Assignees
@jennypavlova
Labels
Feature:Metrics UI Metrics UI feature Feature:ObsHosts Hosts feature within Observability Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v8.10.0

Comments

@jennypavlova
Copy link
Member

jennypavlova commented Jun 23, 2023 •
edited
Loading

Summary

An overview tab should be added in the asset details flyout. The scope of the issue is to add the overview tab and the first section of the overview tab (key metrics tiles and metadata).

Design

MVP version
Image

AC

  • The overview tab should be visible and the first default tab

  • The overview tab should show

    • tiles with key metrics trended metrics
    • metadata (host.ip and host.os.version) and show all button that navigates to the metadata tab
      • Updated design with the show all button:
      image

  • Update storybook with the new tab
@jennypavlova jennypavlova added Feature:Metrics UI Metrics UI feature Feature:ObsHosts Hosts feature within Observability Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Jun 23, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@jennypavlova jennypavlova self-assigned this Jun 26, 2023
@crespocarlos
Copy link
Contributor

Thinking here that we've moved all existing node details tabs to the asset details folder. The Metrics tab is now being replaced by the Overview tab. I was wondering if removing the metrics tab folder should be part of this ticket.

Are we planning on continuing to maintain the storybooks for the Asset Details?

@jennypavlova
Copy link
Member Author

Thank you for the comment @crespocarlos - maybe it's a good idea to have it as an overview tab and reuse the implemented metrics inside (as we will probably use the same design/structure everywhere), wdyt? I think maintaining the storybook is a great idea I will update the AC to include it 👍

@jennypavlova jennypavlova mentioned this issue Jun 29, 2023
Merged
jennypavlova added a commit that referenced this issue Jul 7, 2023
@jennypavlova
[infra UI] Add overview tab with the first section to asset details v…
74a7860 
…iew (#160924)

Closes  #160376
## Summary

This PR adds the initial version of the Overview tab including KPI tiles
and metadata summary.
<img width="865" alt="image"
src="https://github.com/elastic/kibana/assets/14139027/36b62899-64e8-4359-a7f5-e09a2a300bba">

The storybook is not showing the lens charts as it will be hard because
of the dependencies (we should consider if it is worth the effort to add
them there in the future) The other parts look Ok:
<img width="2550" alt="image"
src="https://github.com/elastic/kibana/assets/14139027/348b868b-9ed9-4b59-b02c-cb1e91eecb5a">


## Next steps 👣 
There are still some parts that can be addressed separately when other
parts are ready:
- The date is currently relying on the host date picker (passed as an
override) which can be fixed once the date picker is added to the page

## Testing 
- Go to host view and open the flyout - the default tab is now overview
tab
- Hint: to see the chart movements better pick a wider time range (5
days for example)
   
<img width="1468" alt="image"
src="https://github.com/elastic/kibana/assets/14139027/d31faf71-5beb-48f2-b20a-7dfcacd52325">

- Show all button in the metadata section should open the metadata tab
- Storybook: Use `yarn storybook infra` to run the storybook and check
both `Page` and `Flyout`
@jennypavlova jennypavlova mentioned this issue Jul 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jennypavlova jennypavlova

Labels
Feature:Metrics UI Metrics UI feature Feature:ObsHosts Hosts feature within Observability Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v8.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[infra UI] Add overview tab with the first section to asset details view jennypavlova/kibana
3 participants
@crespocarlos @jennypavlova @elasticmachine