Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Surrounding documents fails to load when ID contains a slash #160212

Closed
davismcphee opened this issue Jun 21, 2023 · 1 comment · Fixed by #160239
Closed

[Discover] Surrounding documents fails to load when ID contains a slash #160212

davismcphee opened this issue Jun 21, 2023 · 1 comment · Fixed by #160239
Assignees
@jughosta
Labels
bug Fixes for quality problems that affect the customer experience :DataDiscovery/fix-it-week Feature:Discover Discover Application impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@davismcphee
Copy link
Contributor

The surrounding documents page fails to load for documents with IDs that contain a slash:
context_id

This appears to be a regression as the same or similar issues have been fixed in the past:
@davismcphee davismcphee added bug Fixes for quality problems that affect the customer experience Feature:Discover Discover Application loe:small Small Level of Effort impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. :DataDiscovery/fix-it-week labels Jun 21, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@jughosta jughosta self-assigned this Jun 22, 2023
@jughosta jughosta mentioned this issue Jun 22, 2023
Merged
jughosta added a commit that referenced this issue Jun 23, 2023
@jughosta
[Discover] Encode context anchor ID (#160239)
78ee25d 
- Closes #160212

## Summary

Added the missing encoding and updated tests.

## For testing

An id with special characters like `/` can be specified via `_bulk` API.
Example:

```
POST _bulk
{ "index" : { "_index" : "context-special", "_id" : "test&?#+/=" } }
{ "timestamp":"2023-06-20T20:00:00.123Z", "name": "test" }
```
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Jun 23, 2023
@jughosta
[Discover] Encode context anchor ID (elastic#160239)
793c130 
- Closes elastic#160212

## Summary

Added the missing encoding and updated tests.

## For testing

An id with special characters like `/` can be specified via `_bulk` API.
Example:

```
POST _bulk
{ "index" : { "_index" : "context-special", "_id" : "test&?#+/=" } }
{ "timestamp":"2023-06-20T20:00:00.123Z", "name": "test" }
```

(cherry picked from commit 78ee25d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jughosta jughosta

Labels
bug Fixes for quality problems that affect the customer experience :DataDiscovery/fix-it-week Feature:Discover Discover Application impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Discover] Encode context anchor ID jughosta/kibana
3 participants
@jughosta @elasticmachine @davismcphee