Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show all timestamps including when there is no data in preview charts of APM rules #159928

Closed
benakansara opened this issue Jun 19, 2023 · 1 comment · Fixed by #181978
Closed
Assignees
Labels
Feature:Alerting Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.9.0 v8.15.0
Milestone

Comments

@benakansara
Copy link
Contributor

benakansara commented Jun 19, 2023

If there is no data in the beginning or end of period, the x-axis doesn't show that timestamp. In this case we should show the timestamps even if there is no data for that time instead of calculating time based on what is displayed. It would be good to show that there is no data in that time.

In the screenshot below, the data shown is for last 25 minutes (as per the chart label), but by looking at the timestamps of the chart, it could appear that the data is for last 15 minutes.

image

@botelastic botelastic bot added the needs-team Issues missing a team label label Jun 19, 2023
@benakansara benakansara added the Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" label Jun 19, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Jun 19, 2023
@benakansara benakansara added needs-team Issues missing a team label v8.10.0 labels Jun 19, 2023
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jun 19, 2023
@benakansara benakansara self-assigned this Jun 19, 2023
@emma-raffenne emma-raffenne added this to the 8.11 milestone Aug 7, 2023
benakansara added a commit that referenced this issue Apr 30, 2024
#181978)

Fixes #159928,
#181148,
elastic/sdh-kibana#4596,
#179811

### Threshold: 0, Y: 0
<img width="605" alt="Screenshot 2024-04-29 at 13 00 39"
src="https://github.com/elastic/kibana/assets/69037875/02d72939-4f4c-4d3a-bc77-c5c27559df86">

### Show empty timestamp if there is no data
<img width="604" alt="Screenshot 2024-04-30 at 15 31 58"
src="https://github.com/elastic/kibana/assets/69037875/7d4fcc08-07c9-46f7-a01e-e50c41b7e141">

### Tooltip
<img width="598" alt="Screenshot 2024-04-29 at 14 25 33"
src="https://github.com/elastic/kibana/assets/69037875/2e35887c-0fb8-40d4-a0f0-e5fc7e3f1fd7">
benakansara added a commit to benakansara/kibana that referenced this issue May 7, 2024
elastic#181978)

Fixes elastic#159928,
elastic#181148,
elastic/sdh-kibana#4596,
elastic#179811

### Threshold: 0, Y: 0
<img width="605" alt="Screenshot 2024-04-29 at 13 00 39"
src="https://github.com/elastic/kibana/assets/69037875/02d72939-4f4c-4d3a-bc77-c5c27559df86">

### Show empty timestamp if there is no data
<img width="604" alt="Screenshot 2024-04-30 at 15 31 58"
src="https://github.com/elastic/kibana/assets/69037875/7d4fcc08-07c9-46f7-a01e-e50c41b7e141">

### Tooltip
<img width="598" alt="Screenshot 2024-04-29 at 14 25 33"
src="https://github.com/elastic/kibana/assets/69037875/2e35887c-0fb8-40d4-a0f0-e5fc7e3f1fd7">

(cherry picked from commit db188e7)
benakansara referenced this issue May 13, 2024
… tooltip (#181978) (#182788)

# Backport

This will backport the following commits from `main` to `8.14`:
- [[APM] [Preview Chart] Fix threshold area annotation and enable
tooltip (#181978)](#181978)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Bena
Kansara","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-04-30T20:43:15Z","message":"[APM]
[Preview Chart] Fix threshold area annotation and enable tooltip
(#181978)\n\nFixes
https://github.com/elastic/kibana/issues/159928,\r\nhttps://github.com/elastic/kibana/issues/181148,\r\nhttps://github.com/elastic/sdh-kibana/issues/4596,\r\nhttps://github.com/elastic/kibana/issues/179811\r\n\r\n###
Threshold: 0, Y: 0\r\n<img width=\"605\" alt=\"Screenshot 2024-04-29 at
13 00
39\"\r\nsrc=\"https://github.com/elastic/kibana/assets/69037875/02d72939-4f4c-4d3a-bc77-c5c27559df86\">\r\n\r\n###
Show empty timestamp if there is no data\r\n<img width=\"604\"
alt=\"Screenshot 2024-04-30 at 15 31
58\"\r\nsrc=\"https://github.com/elastic/kibana/assets/69037875/7d4fcc08-07c9-46f7-a01e-e50c41b7e141\">\r\n\r\n###
Tooltip\r\n<img width=\"598\" alt=\"Screenshot 2024-04-29 at 14 25
33\"\r\nsrc=\"https://github.com/elastic/kibana/assets/69037875/2e35887c-0fb8-40d4-a0f0-e5fc7e3f1fd7\">","sha":"db188e7a360227ae97fd103b84b8f37b88b92cf3","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:skip","backport:skip","ci:project-deploy-observability","Team:obs-ux-infra_services","Team:obs-ux-management","apm:review","v8.15.0"],"number":181978,"url":"https://github.com/elastic/kibana/pull/181978","mergeCommit":{"message":"[APM]
[Preview Chart] Fix threshold area annotation and enable tooltip
(#181978)\n\nFixes
https://github.com/elastic/kibana/issues/159928,\r\nhttps://github.com/elastic/kibana/issues/181148,\r\nhttps://github.com/elastic/sdh-kibana/issues/4596,\r\nhttps://github.com/elastic/kibana/issues/179811\r\n\r\n###
Threshold: 0, Y: 0\r\n<img width=\"605\" alt=\"Screenshot 2024-04-29 at
13 00
39\"\r\nsrc=\"https://github.com/elastic/kibana/assets/69037875/02d72939-4f4c-4d3a-bc77-c5c27559df86\">\r\n\r\n###
Show empty timestamp if there is no data\r\n<img width=\"604\"
alt=\"Screenshot 2024-04-30 at 15 31
58\"\r\nsrc=\"https://github.com/elastic/kibana/assets/69037875/7d4fcc08-07c9-46f7-a01e-e50c41b7e141\">\r\n\r\n###
Tooltip\r\n<img width=\"598\" alt=\"Screenshot 2024-04-29 at 14 25
33\"\r\nsrc=\"https://github.com/elastic/kibana/assets/69037875/2e35887c-0fb8-40d4-a0f0-e5fc7e3f1fd7\">","sha":"db188e7a360227ae97fd103b84b8f37b88b92cf3"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.15.0","labelRegex":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/181978","number":181978,"mergeCommit":{"message":"[APM]
[Preview Chart] Fix threshold area annotation and enable tooltip
(#181978)\n\nFixes
https://github.com/elastic/kibana/issues/159928,\r\nhttps://github.com/elastic/kibana/issues/181148,\r\nhttps://github.com/elastic/sdh-kibana/issues/4596,\r\nhttps://github.com/elastic/kibana/issues/179811\r\n\r\n###
Threshold: 0, Y: 0\r\n<img width=\"605\" alt=\"Screenshot 2024-04-29 at
13 00
39\"\r\nsrc=\"https://github.com/elastic/kibana/assets/69037875/02d72939-4f4c-4d3a-bc77-c5c27559df86\">\r\n\r\n###
Show empty timestamp if there is no data\r\n<img width=\"604\"
alt=\"Screenshot 2024-04-30 at 15 31
58\"\r\nsrc=\"https://github.com/elastic/kibana/assets/69037875/7d4fcc08-07c9-46f7-a01e-e50c41b7e141\">\r\n\r\n###
Tooltip\r\n<img width=\"598\" alt=\"Screenshot 2024-04-29 at 14 25
33\"\r\nsrc=\"https://github.com/elastic/kibana/assets/69037875/2e35887c-0fb8-40d4-a0f0-e5fc7e3f1fd7\">","sha":"db188e7a360227ae97fd103b84b8f37b88b92cf3"}}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Alerting Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.9.0 v8.15.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants