Consolidate Shared UX Code Editor Package and Kibana React Code Editor Plugin #159719
Closed
3 tasks
Labels
discuss
Team:SharedUX
Team label for AppEx-SharedUX (formerly Global Experience)
technical debt
Improvement of the software architecture and operational architecture
I'm opening this issue to track consolidation of the Code Editor package and plugin. Currently the @elastic/appex-sharedux is responsible for the Code Editor within the kibana react plugin (src/plugins/kibana_react/public/code_editor) and the shared ux package code editor (packages/shared-ux/code_editor).
This is unnecessary overhead and we can be consolidated. In PR #148550 I migrated the existing code from the kibana react plugin into the shared ux package. From what I recall, we will eventually be removing the kibana react plugin. Due to time constraints at the time, I hadn't migrated existing usages of the Code Editor from Kibana and then deprecate the code editor within kibana react.
@Dosant had a great idea of having the package code be within the plugin code for the code editor. He has recently added grok language support to the kibana react code editor in this PR #155506.
List of PRs that might need to be ported to the package (needs additional review if there is more):
CodeEditor
#155506Next steps:
The text was updated successfully, but these errors were encountered: