Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark saved objects import/export API stable #159454

Closed
rudolf opened this issue Jun 12, 2023 · 4 comments · Fixed by #202173
Closed

Mark saved objects import/export API stable #159454

rudolf opened this issue Jun 12, 2023 · 4 comments · Fixed by #202173
Assignees
Labels
good first issue low hanging fruit Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@rudolf
Copy link
Contributor

rudolf commented Jun 12, 2023

The saved objects import/export APIs are currently still marked as experimental https://www.elastic.co/guide/en/kibana/current/dashboard-import-api.html

We should prioritise making these APIs stable to give users the confidence that they can depend on them.

Related:

@rudolf rudolf added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Jun 12, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@rudolf
Copy link
Contributor Author

rudolf commented Jun 12, 2023

In #54123 (comment) we decided to postpone further work on making the API stable. But I don't think we should block making this API stable until we have a solution to psuedo-copies #91615 (comment)

This is partly because solving psuedo-copies has not been a priority and the timelines are unclear. In addition, even if we decide we need to make a breaking change we have very high adoption of this API. So even if officially marked as preview, in reality we would not be able to make a breaking change to this API, so effectively based on the existing adoption this API should already be treated as "public".

@pgayvallet
Copy link
Contributor

Blocked on: #54123

One of the first issue I remember the team spending lot of time and discussions on 😅 .

But yeah, I agree that in practice, we wouldn't really be able to introduce breaking changes to the current version of this API, given the overall adoption.

However, with the versioned routes / router, we now have a solution to introduce changes such as the ones in #54123, right? So I think we're even more fine moving the APIs (import and export) as stable in their current state?

@lukeelmers
Copy link
Member

Supersedes #90429

@rudolf rudolf added the good first issue low hanging fruit label Nov 5, 2024
@jesuswr jesuswr self-assigned this Nov 28, 2024
jesuswr added a commit that referenced this issue Dec 2, 2024
…rt apis (#202173)

## Summary

resolves #159454

Remove experimental message from saved objects import and export apis.


### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [x]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials

### Identify risks

Does this PR introduce any risks? For example, consider risks like hard
to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified
risk. Invite stakeholders and evaluate how to proceed before merging.

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Dec 9, 2024
…rt apis (elastic#202173)

## Summary

resolves elastic#159454

Remove experimental message from saved objects import and export apis.


### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [x]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials

### Identify risks

Does this PR introduce any risks? For example, consider risks like hard
to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified
risk. Invite stakeholders and evaluate how to proceed before merging.

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Dec 12, 2024
…rt apis (elastic#202173)

## Summary

resolves elastic#159454

Remove experimental message from saved objects import and export apis.


### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [x]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials

### Identify risks

Does this PR introduce any risks? For example, consider risks like hard
to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified
risk. Invite stakeholders and evaluate how to proceed before merging.

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue low hanging fruit Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants