Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: X-Pack session_view API integration tests (basic).x-pack/test/session_view/basic/tests/get_total_io_bytes_route·ts - Session View API (basic) Session view - /internal/session_view/get_total_io_bytes - with a basic license /internal/session_view/get_total_io_bytes returns a page of IO events #159303

Closed
kibanamachine opened this issue Jun 8, 2023 · 18 comments · Fixed by #158710
Closed

Failing test: X-Pack session_view API integration tests (basic).x-pack/test/session_view/basic/tests/get_total_io_bytes_route·ts - Session View API (basic) Session view - /internal/session_view/get_total_io_bytes - with a basic license /internal/session_view/get_total_io_bytes returns a page of IO events #159303

kibanamachine opened this issue Jun 8, 2023 · 18 comments · Fixed by #158710
Labels
failed-test A test failure on a tracked branch, potentially flaky-test

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Jun 8, 2023 •
edited
Loading

A test failed on a tracked branch

Error: expected 400 to equal 200
    at Assertion.assert (expect.js:100:11)
    at Assertion.apply (expect.js:227:8)
    at Assertion.be (expect.js:69:22)
    at Context.<anonymous> (get_total_io_bytes_route.ts:40:34)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at Object.apply (wrap_function.js:73:16)

First failure: CI Build - main
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Jun 8, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Jun 8, 2023
@tonyghiani tonyghiani mentioned this issue Jun 8, 2023
Merged
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

tonyghiani added a commit that referenced this issue Jun 8, 2023
@tonyghiani @kibanamachine
[Logs UI] Versioning for Logs related APIs (#158710)
e3fddf3 
## 📓  Summary

Closes #157324 
Closes #159275 
Closes #159303 

This work converts the APIs related to the Logs UI feature into
versioned APIs using the new [Kibana versioned
router](https://docs.elastic.dev/kibana-dev-docs/versioning-http-apis#4-adhere-to-the-http-versioning-specification).

The converted APIs are the following, where each endpoint now is set to
version `1`:
-
[log_views](https://github.com/elastic/kibana/tree/main/x-pack/plugins/infra/server/routes/log_views)
-
[log_entries](https://github.com/elastic/kibana/tree/main/x-pack/plugins/infra/server/routes/log_entries)
-
[log_analysis](https://github.com/elastic/kibana/tree/main/x-pack/plugins/infra/server/routes/log_analysis)
-
[log_alerts](https://github.com/elastic/kibana/tree/main/x-pack/plugins/infra/server/routes/log_alerts)

The PR also includes moving the interfaces and runtime types relatives
to each endpoint's group into the recommended practices for [versioning
interfaces](https://docs.elastic.dev/kibana-dev-docs/versioning-interfaces).

## 🧪 Testing

- Navigate to the Logs UI settings page and verify the log view is
correctly retrieved and can be successfully updated.
- Navigate to the Logs stream page and verify the stream entries are
retrieved and rendered.
- Navigate to the Anomalies and Categories pages page and verify the
anomalies entries are retrieved and rendered correctly.
- Create a Log threshold alert and verify the chart preview data are
correctly retrieved and shown.

---------

Co-authored-by: Marco Antonio Ghiani <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
@kibanamachine kibanamachine reopened this Jun 8, 2023
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@jbudz
Copy link
Member

jbudz commented Jun 8, 2023

/skip

@kibanamachine
Copy link
Contributor Author

Skipped

main: 1ca29ef

kibanamachine added a commit that referenced this issue Jun 8, 2023
@kibanamachine
skip failing test suite (#159303)
1ca29ef
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jun 8, 2023
@tonyghiani
Copy link
Contributor

@jbudz this one has been fixed right before the latest merged PRs triggered again the failure message and re-open the issue, it shouldn't occur anymore and we could remove the skip ok?

@jbudz
Copy link
Member

jbudz commented Jun 8, 2023

Can you link the fix? Once that passes CI on main I'll revert the skip.

@tonyghiani
Copy link
Contributor

tonyghiani commented Jun 8, 2023 •
edited
Loading

Can you link the fix? Once that passes CI on main I'll revert the skip.

Sure, here is the commit from the PR mentioned above.

Here the commit in main.

@jbudz
Copy link
Member

jbudz commented Jun 8, 2023

Thanks, will update after that run is done and I've pushed a revert.

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

jbudz added a commit that referenced this issue Jun 8, 2023
@jbudz
Revert "skip failing test suite (#159303)"
8e656cf 
This reverts commit 1ca29ef.
@jbudz
Copy link
Member

jbudz commented Jun 8, 2023

Resolved by #158710 - https://buildkite.com/elastic/kibana-on-merge/builds/31300. Unreverted the skip with 8e656cf

@jbudz jbudz closed this as completed Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
failed-test A test failure on a tracked branch, potentially flaky-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Logs UI] Versioning for Logs related APIs tonyghiani/kibana
3 participants
@jbudz @tonyghiani @kibanamachine