Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IndexPatterns] Move internal subroutes to internal #159158

Closed
thomasneirynck opened this issue Jun 6, 2023 · 2 comments · Fixed by #159626
Closed

[IndexPatterns] Move internal subroutes to internal #159158

thomasneirynck opened this issue Jun 6, 2023 · 2 comments · Fixed by #159626
Assignees
@mattkime
Labels
impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@thomasneirynck
Copy link
Contributor

Move routes to internal iso api.

  • /api/index_patterns/_fields_for_wildcard
  • /api/index_pattern_field_editor/field_preview

These are undocumented.

Part of #157056
@thomasneirynck thomasneirynck added the Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. label Jun 6, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@mattkime mattkime mentioned this issue Jun 14, 2023
Merged
mattkime added a commit that referenced this issue Jun 14, 2023
@mattkime
[data views] Move fields_for_wildcard to internal route (#159637)
65205ab 
## Summary

`/api/index_patterns/_fields_for_wildcard` =>
`/internal/data_views/_fields_for_wildcard`

Part of #159158
@mattkime mattkime self-assigned this Jun 17, 2023
@mattkime mattkime mentioned this issue Jun 17, 2023
Merged
@davismcphee davismcphee added loe:medium Medium Level of Effort impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. labels Jun 22, 2023
@mattkime
Copy link
Contributor

Complete

mattkime added a commit that referenced this issue Jun 30, 2023
@mattkime @kibanamachine
[data views] Field editor endpoint versioning and schema validation (#…
a915352 
…159626)

## Summary

- Move field preview to internal route
- Add versioning to route
- Endpoint is called with version
- Response schema validation

Closes #159158

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattkime mattkime

Labels
impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[data views] Field editor endpoint versioning and schema validation mattkime/kibana
4 participants
@mattkime @thomasneirynck @elasticmachine @davismcphee