-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AO] Update context.alertDetailsUrl
and context.viewInAppUrl
description
#158437
Comments
Pinging @elastic/actionable-observability (Team: Actionable Observability) |
context.alertDetailsUrl
descriptioncontext.alertDetailsUrl
and context.viewInAppUrl
description
Yes, that way the URL can at least be copied. |
My proposal for the description: |
@katrin-freihofner Would you please also propose a description for |
@katrin-freihofner can you check this please? |
My proposals for the description for |
…le types (#159571) Closes #157284, closes #158437 ## Summary This PR updates the default action and recovery message for observability rule types. Only uptime is excluded in this PR, I will add that after synching with the synthetics team. [Here](https://docs.google.com/spreadsheets/d/15cJanv0xi4EKo1QZVXsi_NcFcPa_VQze3nQc4P8GZrQ/edit?pli=1#gid=0) you can find the list of default messages and the new proposals. ![image](https://github.com/elastic/kibana/assets/12370520/4f36e971-d8c2-47a9-ac25-9cae567db774) ## 🧪 How to test - Ensure that `server.publicBaseUrl` is configured in kibana.dev.yml - Create an observability rule with an action such as Email to use the default messages (both for alert and recover states) - After an alert is triggered, check the generated action message, it should - match the message mentioned in the list - contain an alert details link pointing to the Alerts page filtered for that specific alert --------- Co-authored-by: kibanamachine <[email protected]>
📝 Summary
We need to revisit and update
alertDetailsUrl
andviewInAppUrl
descriptions to make them more clear and consistent with the rest of the URL variables.Also, at the moment, we don't have any value in
alertDetailsUrl
field ifserver.publicBaseUrl
is not configured (similar to other URLs) If we want this behavior this way, we can include it in the message otherwise we can change the logicserver.publicBaseUrl
is not configured?✅ Acceptance Criteria
alertDetailsUrl
The text was updated successfully, but these errors were encountered: