-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[maps] toolbar action button not filled when selected #158221
Labels
bug
Fixes for quality problems that affect the customer experience
Feature:Maps
regression
Team:Presentation
Presentation Team for Dashboard, Input Controls, and Canvas
Comments
nreese
added
bug
Fixes for quality problems that affect the customer experience
regression
Team:Presentation
Presentation Team for Dashboard, Input Controls, and Canvas
Feature:Maps
labels
May 22, 2023
Pinging @elastic/kibana-presentation (Team:Presentation) |
nreese
added a commit
that referenced
this issue
May 26, 2023
Fixes #158221 Updated CSS selector to look for any class containing "euiButtonIcon-fill" instead of old "euiButtonIcon--fill". Had to use wild card select because class name as dynamic id in it, for example "css-1q7ycil-euiButtonIcon-empty-primary-hoverStyles" Now, button is filled and icon is white when selected. <img width="400" alt="Screen Shot 2023-05-23 at 10 34 42 AM" src="https://github.com/elastic/kibana/assets/373691/821d95da-df7a-4779-a7fa-2ce2aa61fa7d"> --------- Co-authored-by: Kibana Machine <[email protected]>
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
May 26, 2023
…8284) Fixes elastic#158221 Updated CSS selector to look for any class containing "euiButtonIcon-fill" instead of old "euiButtonIcon--fill". Had to use wild card select because class name as dynamic id in it, for example "css-1q7ycil-euiButtonIcon-empty-primary-hoverStyles" Now, button is filled and icon is white when selected. <img width="400" alt="Screen Shot 2023-05-23 at 10 34 42 AM" src="https://github.com/elastic/kibana/assets/373691/821d95da-df7a-4779-a7fa-2ce2aa61fa7d"> --------- Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit 33f5bb6)
kibanamachine
referenced
this issue
May 26, 2023
) (#158556) # Backport This will backport the following commits from `main` to `8.8`: - [[maps] fix toolbar action button not filled when selected (#158284)](#158284) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nathan Reese","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-05-26T12:20:48Z","message":"[maps] fix toolbar action button not filled when selected (#158284)\n\nFixes https://github.com/elastic/kibana/issues/158221\r\n\r\nUpdated CSS selector to look for any class containing\r\n\"euiButtonIcon-fill\" instead of old \"euiButtonIcon--fill\". Had to use\r\nwild card select because class name as dynamic id in it, for example\r\n\"css-1q7ycil-euiButtonIcon-empty-primary-hoverStyles\"\r\n\r\nNow, button is filled and icon is white when selected.\r\n<img width=\"400\" alt=\"Screen Shot 2023-05-23 at 10 34 42 AM\"\r\nsrc=\"https://github.com/elastic/kibana/assets/373691/821d95da-df7a-4779-a7fa-2ce2aa61fa7d\">\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"33f5bb6ba57f533b9ac894f4f6020d6c855ab1ad","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Presentation","Feature:Maps","v8.9.0","v8.8.1"],"number":158284,"url":"https://github.com/elastic/kibana/pull/158284","mergeCommit":{"message":"[maps] fix toolbar action button not filled when selected (#158284)\n\nFixes https://github.com/elastic/kibana/issues/158221\r\n\r\nUpdated CSS selector to look for any class containing\r\n\"euiButtonIcon-fill\" instead of old \"euiButtonIcon--fill\". Had to use\r\nwild card select because class name as dynamic id in it, for example\r\n\"css-1q7ycil-euiButtonIcon-empty-primary-hoverStyles\"\r\n\r\nNow, button is filled and icon is white when selected.\r\n<img width=\"400\" alt=\"Screen Shot 2023-05-23 at 10 34 42 AM\"\r\nsrc=\"https://github.com/elastic/kibana/assets/373691/821d95da-df7a-4779-a7fa-2ce2aa61fa7d\">\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"33f5bb6ba57f533b9ac894f4f6020d6c855ab1ad"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/158284","number":158284,"mergeCommit":{"message":"[maps] fix toolbar action button not filled when selected (#158284)\n\nFixes https://github.com/elastic/kibana/issues/158221\r\n\r\nUpdated CSS selector to look for any class containing\r\n\"euiButtonIcon-fill\" instead of old \"euiButtonIcon--fill\". Had to use\r\nwild card select because class name as dynamic id in it, for example\r\n\"css-1q7ycil-euiButtonIcon-empty-primary-hoverStyles\"\r\n\r\nNow, button is filled and icon is white when selected.\r\n<img width=\"400\" alt=\"Screen Shot 2023-05-23 at 10 34 42 AM\"\r\nsrc=\"https://github.com/elastic/kibana/assets/373691/821d95da-df7a-4779-a7fa-2ce2aa61fa7d\">\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"33f5bb6ba57f533b9ac894f4f6020d6c855ab1ad"}},{"branch":"8.8","label":"v8.8.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nathan Reese <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Fixes for quality problems that affect the customer experience
Feature:Maps
regression
Team:Presentation
Presentation Team for Dashboard, Input Controls, and Canvas
Notice in the screen shot below how the "timeslider" button is not filled even though the timeslider is open
This is a regression from elastic/eui#6150. elastic/eui#6150 removed
euiButtonIcon--fill
class that is being used in CSS to apply specific rules https://github.com/elastic/kibana/blob/main/x-pack/plugins/maps/public/connected_components/toolbar_overlay/_toolbar_overlay.scss#L13The text was updated successfully, but these errors were encountered: