Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: Firefox XPack UI Functional Tests.x-pack/test/functional/apps/infra/home_page·ts - InfraOps App Metrics UI Home page Saved Views should update the current saved view and load it #157740

Closed
kibanamachine opened this issue May 15, 2023 · 12 comments · Fixed by #160503, #160718, #160852 or #162896
Closed

Failing test: Firefox XPack UI Functional Tests.x-pack/test/functional/apps/infra/home_page·ts - InfraOps App Metrics UI Home page Saved Views should update the current saved view and load it #157740

kibanamachine opened this issue May 15, 2023 · 12 comments · Fixed by #160503, #160718, #160852 or #162896
Assignees
@jennypavlova
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented May 15, 2023 •
edited
Loading

A test failed on a tracked branch

TimeoutError: The element [data-test-subj="savedViews-upsertModal"] was still present when it should have disappeared.
Wait timed out after 13189ms
    at /var/lib/buildkite-agent/builds/kb-n2-4-spot-51ba6872b2745881/elastic/kibana-on-merge/kibana/node_modules/selenium-webdriver/lib/webdriver.js:929:17
    at processTicksAndRejections (node:internal/process/task_queues:96:5) {
  remoteStacktrace: ''
}

First failure: CI Build - main
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label May 15, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label May 15, 2023
@dmlemeshko dmlemeshko added the Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services label May 15, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@botelastic botelastic bot removed the needs-team Issues missing a team label label May 15, 2023
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

mistic added a commit that referenced this issue Jun 23, 2023
@mistic
skip flaky suite (#157740)
d2405f0
@mistic
Copy link
Member

mistic commented Jun 23, 2023

Skipped.

main: d2405f0

@jennypavlova jennypavlova self-assigned this Jun 26, 2023
@jennypavlova jennypavlova mentioned this issue Jun 26, 2023
Merged
jennypavlova added a commit that referenced this issue Jun 27, 2023
@jennypavlova
Infra flaky test fixes (#160503)
7e7cf0f 
Closes #157711 and closes #157740
## Summary

This PR fixes the mentioned flaky tests together with the fix done in
#160407
@kibanamachine kibanamachine reopened this Jun 27, 2023
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

mistic added a commit that referenced this issue Jun 27, 2023
@mistic
skip flaky suite (#157740)
3bd43ab
@mistic
Copy link
Member

mistic commented Jun 27, 2023

Skipped.

main: 3bd43ab

@jennypavlova jennypavlova mentioned this issue Jun 28, 2023
Merged
@crespocarlos crespocarlos mentioned this issue Jun 29, 2023
Merged
jennypavlova added a commit that referenced this issue Jun 30, 2023
@jennypavlova
[Infra UI] Saved views test fix (#160718)
2615be5 
Closes #157740 
## Summary

This PR fixes the flaky infra saved views test - applies the fix added
metrics explorer.
crespocarlos added a commit that referenced this issue Jul 5, 2023
@crespocarlos @kibanamachine
[Infrastructure UI] Add strict payload validation to inventory_views …
d79e69a 
…endpoint (#160852)

closes [#157505](#157505)
fixes [#157740](#157740)
## Summary

This PR adds strict payload validation to `inventory_views` endpoint. I
tried to make the types consistent between sever and frontend code and
because of that more changes had to be made. I also refactored the
`toolbar_control` component, decoupling them from Inventory View and
Metrics Explorer View types


### How to test

- Call the endpoint below trying to use invalid values. see
[here](https://github.com/elastic/kibana/pull/160852/files#diff-058b21e249ebbe2795d450d07025d8904a58cfb07a97979e85975f87e931ffceR133-R143).

```bash
[POST|PUT] kbn:/api/infra/inventory_views
{
  "attributes": {
    "metric": {
        "type": [TYPE]
    },
    "sort": {
        "by": "name"
        "direction": "desc"
    },
    "groupBy": [],
    "nodeType": "host",
    "view": "map",
    "customOptions": [],
    "customMetrics": [],
    "boundsOverride": {
        "max": 1,
        "min": 0
    },
    "autoBounds": true,
    "accountId": "",
    "region": "",
    "autoReload": false,
    "filterQuery": {
        "expression": "",
        "kind": "kuery"
    },
    "legend": {
        "palette": "cool",
        "steps": 10,
        "reverseColors": false
    },
    "timelineOpen": false,
    "name": "test-uptime"
  }
}
```

- Set up a local Kibana instance
- Navigate to `Infrastructure`
- In the UI, use the Saved View feature and try different field
combinations

---------

Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine kibanamachine reopened this Jul 5, 2023
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

mistic added a commit that referenced this issue Jul 7, 2023
@mistic
skip flaky suite (#157740)
65fed09
@mistic
Copy link
Member

mistic commented Jul 7, 2023

Skipped.

main: 65fed09

@jennypavlova jennypavlova mentioned this issue Aug 2, 2023
Merged
jennypavlova added a commit that referenced this issue Aug 2, 2023
@jennypavlova
[Infra UI] Add timeout to fix flaky tests (#162896)
446f894 
Closes #157711
Closes #157740

## Summary

Fixes for the flaky tests: I ran the tests 200 and after that 50 times
and with the fix they are not flaky anymore. The fix was setting a
timeout because the element was still present when the test checked for
it.
@crespocarlos crespocarlos mentioned this issue Nov 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jennypavlova jennypavlova

Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Milestone
No milestone
5 participants
@mistic @dmlemeshko @jennypavlova @elasticmachine @kibanamachine