Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Asset Manager] Implicit collection - add telemetry #157377

Closed
Tracked by #157375
klacabane opened this issue May 11, 2023 · 0 comments
Closed
Tracked by #157375

[Asset Manager] Implicit collection - add telemetry #157377

klacabane opened this issue May 11, 2023 · 0 comments
Assignees
@klacabane
Labels
enhancement New value added to drive a business result Feature:Asset Manager Team:Observed Asset Management Label used for engineers working on various parts of observed asset management

Comments

@klacabane
Copy link
Contributor

klacabane commented May 11, 2023 •
edited
Loading

Summary

Implicit collection should be instrumented to store metrics that help monitor performances of the queries/post processing.
APM agent is already available in Kibana and should be straightforward to onboard in asset-manager
@klacabane klacabane mentioned this issue May 11, 2023
Closed
5 tasks
@botelastic botelastic bot added the needs-team Issues missing a team label label May 11, 2023
@klacabane klacabane added enhancement New value added to drive a business result Team:Observed Asset Management Label used for engineers working on various parts of observed asset management Feature:Asset Manager labels May 11, 2023
@botelastic botelastic bot removed the needs-team Issues missing a team label label May 11, 2023
@klacabane klacabane mentioned this issue May 12, 2023
Merged
@klacabane klacabane self-assigned this May 12, 2023
klacabane added a commit that referenced this issue May 30, 2023
@klacabane @jasonrhodes
[Asset Manager] implicit collection telemetry (#157474)
99c617c 
## Summary

Closes #157377

Records performances of implicit collection queries using apm
transactions

### Testing
- configure implicit collection in kibana settings
```
xpack.assetManager:
  implicitCollection:
    enabled: true
    interval: 30s
    
    # elasticsearch cluster we should extract signals from
    input:
      hosts: http://input:9200
      username: ...
      password: ...
    
    # elasticsearch cluster we should write assets to
    output:
      hosts: http://output:9200
      username: ...
      password: ...
```
- (for elastic maintainers) start kibana with `ELASTIC_APM_ACTIVE=true
yarn start`
- look for `transaction.type : "asset_manager-implicit_collection"` in
dev cluster

---------

Co-authored-by: Jason Rhodes <[email protected]>
klacabane added a commit to klacabane/kibana that referenced this issue Jul 19, 2023
@klacabane @jasonrhodes
[Asset Manager] implicit collection telemetry (elastic#157474)
45079fb 
## Summary

Closes elastic#157377

Records performances of implicit collection queries using apm
transactions

### Testing
- configure implicit collection in kibana settings
```
xpack.assetManager:
  implicitCollection:
    enabled: true
    interval: 30s
    
    # elasticsearch cluster we should extract signals from
    input:
      hosts: http://input:9200
      username: ...
      password: ...
    
    # elasticsearch cluster we should write assets to
    output:
      hosts: http://output:9200
      username: ...
      password: ...
```
- (for elastic maintainers) start kibana with `ELASTIC_APM_ACTIVE=true
yarn start`
- look for `transaction.type : "asset_manager-implicit_collection"` in
dev cluster

---------

Co-authored-by: Jason Rhodes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@klacabane klacabane

Labels
enhancement New value added to drive a business result Feature:Asset Manager Team:Observed Asset Management Label used for engineers working on various parts of observed asset management
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@klacabane